Hi Kate,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20210816]
[cannot apply to linus/master v5.14-rc6 v5.14-rc5 v5.14-rc4 v5.14-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Kate-Hsuan/Intel-platform-driver...
base: b9011c7e671dbbf59bb753283ddfd03f0c9eb865
config: i386-randconfig-r023-20210816 (attached as .config)
compiler: clang version 14.0.0 (
https://github.com/llvm/llvm-project
2c6448cdc2f68f8c28fd0bd9404182b81306e6e6)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/30a4d97d4248adef672f46eeb0e32b816...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Kate-Hsuan/Intel-platform-driver-code-movement/20210816-185713
git checkout 30a4d97d4248adef672f46eeb0e32b816b6f531c
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=i386
SHELL=/bin/bash drivers/platform/x86/intel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/platform/x86/intel/scu/ipc.c:478: warning: expecting
prototype for intel_scu_ipc_command_with_size(). Prototype was for
intel_scu_ipc_dev_command_with_size() instead
vim +478 drivers/platform/x86/intel/scu/ipc.c
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
458
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
459 /**
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
460 * intel_scu_ipc_command_with_size() - Command with data
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
461 * @scu: Optional SCU IPC instance
8b236565600833 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-01-22
462 * @cmd: Command
8b236565600833 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-01-22
463 * @sub: Sub type
8b236565600833 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-01-22
464 * @in: Input data
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
465 * @inlen: Input length in bytes
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
466 * @size: Input size written to the IPC command register in whatever
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
467 * units (dword, byte) the particular firmware requires. Normally
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
468 * should be the same as @inlen.
8b236565600833 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-01-22
469 * @out: Output data
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
470 * @outlen: Output length in bytes
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
471 *
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
472 * Issue a command to the SCU which involves data transfers. Do the
8b236565600833 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-01-22
473 * data copies under the lock but leave it for the caller to interpret.
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
474 */
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
475 int intel_scu_ipc_dev_command_with_size(struct intel_scu_ipc_dev *scu, int cmd,
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
476 int sub, const void *in, size_t inlen,
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
477 size_t size, void *out, size_t outlen)
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
@478 {
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
479 size_t outbuflen = DIV_ROUND_UP(outlen, sizeof(u32));
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
480 size_t inbuflen = DIV_ROUND_UP(inlen, sizeof(u32));
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
481 u32 cmdval, inbuf[4] = {};
ecb5646cb098d9 drivers/platform/x86/intel_scu_ipc.c Axel Lin 2011-01-25
482 int i, err;
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
483
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
484 if (inbuflen > 4 || outbuflen > 4)
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
485 return -EINVAL;
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
486
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
487 mutex_lock(&ipclock);
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
488 if (!scu)
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
489 scu = ipcdev;
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
490 if (!scu) {
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
491 mutex_unlock(&ipclock);
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
492 return -ENODEV;
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
493 }
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
494
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
495 memcpy(inbuf, in, inlen);
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
496 for (i = 0; i < inbuflen; i++)
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
497 ipc_data_writel(scu, inbuf[i], 4 * i);
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
498
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
499 cmdval = (size << 16) | (sub << 12) | cmd;
ea608f25fa09b5 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
500 ipc_command(scu, cmdval);
b0b3f578a1c363 drivers/platform/x86/intel_scu_ipc.c Andy Shevchenko 2015-10-12
501 err = intel_scu_ipc_check_status(scu);
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
502
c7094d1d994c23 drivers/platform/x86/intel_scu_ipc.c Kuppuswamy Sathyanarayanan 2013-11-14
503 if (!err) {
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
504 u32 outbuf[4] = {};
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
505
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
506 for (i = 0; i < outbuflen; i++)
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
507 outbuf[i] = ipc_data_readl(scu, 4 * i);
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
508
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
509 memcpy(out, outbuf, outlen);
c7094d1d994c23 drivers/platform/x86/intel_scu_ipc.c Kuppuswamy Sathyanarayanan 2013-11-14
510 }
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
511
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
512 mutex_unlock(&ipclock);
ea608f25fa09b5 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
513 if (err)
ea608f25fa09b5 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
514 dev_err(&scu->dev, "IPC command %#x failed with %d\n", cmdval,
err);
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
515 return err;
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
516 }
f57fa18583f538 drivers/platform/x86/intel_scu_ipc.c Mika Westerberg 2020-04-16
517 EXPORT_SYMBOL(intel_scu_ipc_dev_command_with_size);
9a58a3333923c7 drivers/platform/x86/intel_scu_ipc.c Sreedhara DS 2010-04-26
518
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org