[linux-next:master 5146/6223] drivers/media/platform/rcar-vin/rcar-core.c:220:18: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
3:42 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: da454ebf578f6c542ba9f5b3ddb98db3ede109c1
commit: 0c56f9597adc870e6761822668868fe2930f08bd [5146/6223] media: rcar-vin: Add r8a779a0
support
compiler: riscv64-linux-gcc (GCC) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck warnings: (new ones prefixed by >>)
> drivers/media/platform/rcar-vin/rcar-core.c:220:18: warning: Same
value in both branches of ternary operator. [duplicateValueTernary]
for (i = 0;
i < RVIN_REMOTES_MAX; i++)
^
vim +220 drivers/media/platform/rcar-vin/rcar-core.c
3bb4c3bc85bf77 Niklas Söderlund 2018-04-14 210
87932605cce9cd Niklas Söderlund 2021-07-09 211 /* group lock should be held when calling
this function. */
87932605cce9cd Niklas Söderlund 2021-07-09 212 static int
rvin_group_entity_to_remote_id(struct rvin_group *group,
87932605cce9cd Niklas Söderlund 2021-07-09 213 struct media_entity *entity)
87932605cce9cd Niklas Söderlund 2021-07-09 214 {
87932605cce9cd Niklas Söderlund 2021-07-09 215 struct v4l2_subdev *sd;
87932605cce9cd Niklas Söderlund 2021-07-09 216 unsigned int i;
87932605cce9cd Niklas Söderlund 2021-07-09 217
87932605cce9cd Niklas Söderlund 2021-07-09 218 sd =
media_entity_to_v4l2_subdev(entity);
87932605cce9cd Niklas Söderlund 2021-07-09 219
87932605cce9cd Niklas Söderlund 2021-07-09 @220 for (i = 0; i < RVIN_REMOTES_MAX;
i++)
87932605cce9cd Niklas Söderlund 2021-07-09 221 if (group->remotes[i].subdev == sd)
87932605cce9cd Niklas Söderlund 2021-07-09 222 return i;
87932605cce9cd Niklas Söderlund 2021-07-09 223
87932605cce9cd Niklas Söderlund 2021-07-09 224 return -ENODEV;
87932605cce9cd Niklas Söderlund 2021-07-09 225 }
87932605cce9cd Niklas Söderlund 2021-07-09 226
:::::: The code at line 220 was first introduced by commit
:::::: 87932605cce9cd2a7c986abcbf73666855a2ebc7 media: rcar-vin: Move and rename CSI-2
link notifications
:::::: TO: Niklas Söderlund <niklas.soderlund+renesas(a)ragnatech.se>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
6:15 p.m.
Hello,
I had a look and this is the intended behavior. The macros is defined in
rcar-vin.h as,
enum rvin_csi_id {
RVIN_CSI20,
RVIN_CSI21,
RVIN_CSI40,
RVIN_CSI41,
RVIN_CSI_MAX,
};
enum rvin_isp_id {
RVIN_ISP0,
RVIN_ISP1,
RVIN_ISP2,
RVIN_ISP4,
RVIN_ISP_MAX,
};
#define RVIN_REMOTES_MAX \
(((unsigned int)RVIN_CSI_MAX) > ((unsigned int)RVIN_ISP_MAX) ? \
RVIN_CSI_MAX : RVIN_ISP_MAX)
The idea is to always have RVIN_REMOTES_MAX be the max number of remotes
in either the CSI-2 or ISP remote use-cases. The warning is generated
now as currently both use-cases have a maximum of 4 remotes. In future
this may change and I wanted this to be descibed and addressed by code
instead by a comment to remmeber to increment RVIN_REMOTES_MAX if one of
the use-cases are expanded.
On 2021-08-10 13:42:04 +0800, kernel test robot wrote:
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: da454ebf578f6c542ba9f5b3ddb98db3ede109c1
commit: 0c56f9597adc870e6761822668868fe2930f08bd [5146/6223] media: rcar-vin: Add
r8a779a0 support
compiler: riscv64-linux-gcc (GCC) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck warnings: (new ones prefixed by >>)
>> drivers/media/platform/rcar-vin/rcar-core.c:220:18: warning: Same value in both
branches of ternary operator. [duplicateValueTernary]
for (i = 0; i < RVIN_REMOTES_MAX; i++)
^
vim +220 drivers/media/platform/rcar-vin/rcar-core.c
3bb4c3bc85bf77 Niklas Söderlund 2018-04-14 210
87932605cce9cd Niklas Söderlund 2021-07-09 211 /* group lock should be held when
calling this function. */
87932605cce9cd Niklas Söderlund 2021-07-09 212 static int
rvin_group_entity_to_remote_id(struct rvin_group *group,
87932605cce9cd Niklas Söderlund 2021-07-09 213 struct media_entity *entity)
87932605cce9cd Niklas Söderlund 2021-07-09 214 {
87932605cce9cd Niklas Söderlund 2021-07-09 215 struct v4l2_subdev *sd;
87932605cce9cd Niklas Söderlund 2021-07-09 216 unsigned int i;
87932605cce9cd Niklas Söderlund 2021-07-09 217
87932605cce9cd Niklas Söderlund 2021-07-09 218 sd =
media_entity_to_v4l2_subdev(entity);
87932605cce9cd Niklas Söderlund 2021-07-09 219
87932605cce9cd Niklas Söderlund 2021-07-09 @220 for (i = 0; i < RVIN_REMOTES_MAX;
i++)
87932605cce9cd Niklas Söderlund 2021-07-09 221 if (group->remotes[i].subdev ==
sd)
87932605cce9cd Niklas Söderlund 2021-07-09 222 return i;
87932605cce9cd Niklas Söderlund 2021-07-09 223
87932605cce9cd Niklas Söderlund 2021-07-09 224 return -ENODEV;
87932605cce9cd Niklas Söderlund 2021-07-09 225 }
87932605cce9cd Niklas Söderlund 2021-07-09 226
:::::: The code at line 220 was first introduced by commit
:::::: 87932605cce9cd2a7c986abcbf73666855a2ebc7 media: rcar-vin: Move and rename CSI-2
link notifications
:::::: TO: Niklas Söderlund <niklas.soderlund+renesas(a)ragnatech.se>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
Regards,
Niklas Söderlund
406
days inactive
406
days old
1 comments
2 participants
participants (2)
-
kernel test robot -
Niklas Söderlund