Hi Krzysztof, I love your patch! Yet something to improve: [auto build test ERROR on groeck-staging/hwmon-next] [also build test ERROR on next-20211013] [cannot apply to robh/for-next v5.15-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channe... base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: i386-buildonly-randconfig-r004-20211013 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a8c695542b2987eb9a203d5663a0740cb4725f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4a0f8262fe071b0b27c6fba7455627f3c... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142 git checkout 4a0f8262fe071b0b27c6fba7455627f3c5a5209e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): return err; ^~~ drivers/hwmon/tmp421.c:170:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 1 error generated. vim +/err +178 drivers/hwmon/tmp421.c 167 168 static int tmp421_enable_channels(struct tmp421_data *data) 169 { 170 int err; 171 struct i2c_client *client = data->client; 172 struct device *dev = &client->dev; 173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2); 174 int i; 175 176 if (cfg < 0) { 177 dev_err(dev, "error reading register, can't disable channels\n"); 179 } 180 181 cfg &= ~TMP421_CONFIG_REG_REN_MASK; 182 for (i = 0; i < data->channels; i++) 183 if (data->channel[i].enabled) 184 cfg |= TMP421_CONFIG_REG_REN(i); 185 186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg); 187 if (err < 0) 188 dev_err(dev, "error writing register, can't disable channels\n"); 189 190 return err; 191 } 192 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org