From: kernel test robot <lkp(a)intel.com&gt; drivers/misc/hisi_hikey_usb.c:171:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Wei Xu <xuwei5(a)hisilicon.com&gt; Signed-off-by: kernel test robot <lkp(a)intel.com&gt; --- url: https://github.com/0day-ci/linux/commits/Wei-Xu/misc-hisi_hikey_usb-fix-t... base: f965d3ec86fa89285db0fbb983da76ba9c398efa hisi_hikey_usb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/misc/hisi_hikey_usb.c +++ b/drivers/misc/hisi_hikey_usb.c @@ -168,10 +168,7 @@ static int hisi_hikey_usb_parse_kirin970 hisi_hikey_usb->reset = devm_gpiod_get(&pdev->dev, "hub_reset_en_gpio", GPIOD_OUT_HIGH); - if (IS_ERR(hisi_hikey_usb->reset)) - return PTR_ERR(hisi_hikey_usb->reset); - - return 0; + return PTR_ERR_OR_ZERO(hisi_hikey_usb->reset); } static int hisi_hikey_usb_probe(struct platform_device *pdev)