Hi Chao,
I love your patch! Yet something to improve:
[auto build test ERROR on f2fs/dev-test]
[cannot apply to v5.13-rc1 next-20210510]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-compress-add-compre...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: ia64-randconfig-r011-20210510 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/28d803e509b3847a31e73d7bd20b9f7b7...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Chao-Yu/f2fs-compress-add-compress_inode-to-cache-compressed-blocks/20210510-173127
git checkout 28d803e509b3847a31e73d7bd20b9f7b7e559471
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
In file included from arch/ia64/include/asm/pgtable.h:154,
from include/linux/pgtable.h:6,
from arch/ia64/include/asm/uaccess.h:40,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from fs/f2fs/super.c:10:
arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
arch/ia64/include/asm/mmu_context.h:127:41: warning: variable 'old_rr4' set but
not used [-Wunused-but-set-variable]
127 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
| ^~~~~~~
fs/f2fs/super.c: In function 'kill_f2fs_super':
> fs/f2fs/super.c:4194:31: error: implicit declaration of function
'COMPRESS_MAPPING'; did you mean 'NODE_MAPPING'?
[-Werror=implicit-function-declaration]
4194 |
truncate_inode_pages_final(COMPRESS_MAPPING(sbi));
| ^~~~~~~~~~~~~~~~
| NODE_MAPPING
> fs/f2fs/super.c:4194:31: warning: passing argument 1 of
'truncate_inode_pages_final' makes pointer from integer without a cast
[-Wint-conversion]
4194 | truncate_inode_pages_final(COMPRESS_MAPPING(sbi));
| ^~~~~~~~~~~~~~~~~~~~~
| |
| int
In file included from include/linux/pagemap.h:8,
from include/linux/buffer_head.h:14,
from fs/f2fs/super.c:12:
include/linux/mm.h:2625:40: note: expected 'struct address_space *' but
argument is of type 'int'
2625 | extern void truncate_inode_pages_final(struct address_space *);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +4194 fs/f2fs/super.c
4179
4180 static void kill_f2fs_super(struct super_block *sb)
4181 {
4182 if (sb->s_root) {
4183 struct f2fs_sb_info *sbi = F2FS_SB(sb);
4184
4185 set_sbi_flag(sbi, SBI_IS_CLOSE);
4186 f2fs_stop_gc_thread(sbi);
4187 f2fs_stop_discard_thread(sbi);
4188
4189 /*
4190 * latter evict_inode() can bypass checking and invalidating
4191 * compress inode cache.
4192 */
4193 if (test_opt(sbi, COMPRESS_CACHE))
4194 truncate_inode_pages_final(COMPRESS_MAPPING(sbi));
4195
4196 if (is_sbi_flag_set(sbi, SBI_IS_DIRTY) ||
4197 !is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG)) {
4198 struct cp_control cpc = {
4199 .reason = CP_UMOUNT,
4200 };
4201 f2fs_write_checkpoint(sbi, &cpc);
4202 }
4203
4204 if (is_sbi_flag_set(sbi, SBI_IS_RECOVERED) && f2fs_readonly(sb))
4205 sb->s_flags &= ~SB_RDONLY;
4206 }
4207 kill_block_super(sb);
4208 }
4209
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org