Hi Tian, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on next-20200812] [cannot apply to v5.8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Tian-Tao/hibmc-clean-up-and-code... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git fb893de323e2d39f7a1f6df425703a2edbdf56ea config: arm64-randconfig-r035-20200812 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 30c1633386e7cfb01c0a54b31ccf4c3a3873e71b) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): module_pci_driver(hibmc_pci_driver); ^ include/linux/pci.h:1388:2: note: expanded from macro 'module_pci_driver' module_driver(__pci_driver, pci_register_driver, pci_unregister_driver) ^ include/linux/device/driver.h:262:3: note: expanded from macro 'module_driver' } \ ^ include/linux/pci.h:1388:2: note: expanded from macro 'module_pci_driver' module_driver(__pci_driver, pci_register_driver, pci_unregister_driver) ^ include/linux/device/driver.h:263:13: note: expanded from macro 'module_driver' module_init(__driver##_init); \ ^ <scratch space>:89:1: note: expanded from here hibmc_pci_driver_init ^ include/linux/pci.h:1388:2: note: expanded from macro 'module_pci_driver' module_driver(__pci_driver, pci_register_driver, pci_unregister_driver) ^ include/linux/device/driver.h:267:3: note: expanded from macro 'module_driver' } \ ^ include/linux/pci.h:1388:2: note: expanded from macro 'module_pci_driver' module_driver(__pci_driver, pci_register_driver, pci_unregister_driver) ^ include/linux/device/driver.h:268:13: note: expanded from macro 'module_driver' module_exit(__driver##_exit); ^ <scratch space>:92:1: note: expanded from here hibmc_pci_driver_exit ^ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:391:1: warning: declaration specifier missing, defaulting to 'int' MODULE_DEVICE_TABLE(pci, hibmc_pci_table); ^ int drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:391:21: error: a parameter list without types is only allowed in a function definition MODULE_DEVICE_TABLE(pci, hibmc_pci_table); ^ MODULE_AUTHOR("RongrongZou <zourongrong(a)huawei.com&gt;&quot;); ^ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:392:14: note: to match this '(' MODULE_AUTHOR("RongrongZou <zourongrong(a)huawei.com&gt;&quot;); ^ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:392:1: warning: declaration specifier missing, defaulting to 'int' MODULE_AUTHOR("RongrongZou <zourongrong(a)huawei.com&gt;&quot;); ^ int MODULE_AUTHOR("RongrongZou <zourongrong(a)huawei.com&gt;&quot;); ^ void drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:393:20: error: expected parameter declarator MODULE_DESCRIPTION("DRM Driver for Hisilicon Hibmc"); ^ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:393:20: error: expected ')' drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:393:19: note: to match this '(' MODULE_DESCRIPTION("DRM Driver for Hisilicon Hibmc"); ^ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:393:1: warning: declaration specifier missing, defaulting to 'int' MODULE_DESCRIPTION("DRM Driver for Hisilicon Hibmc"); ^ int drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:393:19: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] MODULE_DESCRIPTION("DRM Driver for Hisilicon Hibmc"); ^ void drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:394:16: error: expected parameter declarator MODULE_LICENSE("GPL v2"); ^ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:394:16: error: expected ')' drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:394:15: note: to match this '(' MODULE_LICENSE("GPL v2"); ^ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:394:1: warning: declaration specifier missing, defaulting to 'int' MODULE_LICENSE("GPL v2"); ^ int drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:394:15: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] MODULE_LICENSE("GPL v2"); ^ void 6 warnings and 12 errors generated. vim +389 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c 5e0df3a08f3d17 Rongrong Zou 2016-11-16 388 4f1a7007d688a7 YueHaibing 2018-04-21 @389 module_pci_driver(hibmc_pci_driver); 5e0df3a08f3d17 Rongrong Zou 2016-11-16 390 5e0df3a08f3d17 Rongrong Zou 2016-11-16 391 MODULE_DEVICE_TABLE(pci, hibmc_pci_table); 5e0df3a08f3d17 Rongrong Zou 2016-11-16 @392 MODULE_AUTHOR("RongrongZou <zourongrong(a)huawei.com&gt;&quot;); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org