Hi Matthew,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20200429]
[also build test ERROR on v5.7-rc3]
[cannot apply to xfs-linux/for-next linux-nvdimm/libnvdimm-for-next ext4/dev f2fs/dev-test
linus/master shaggy/jfs-next v5.7-rc3 v5.7-rc2 v5.7-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Matthew-Wilcox/Large-pages-in-th...
base: 861978d1331b7e988e0295a2275c669c767fa3f1
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/nvdimm/pmem.c: In function 'pmem_rw_page':
> drivers/nvdimm/pmem.c:238:45: error: implicit declaration of
function 'tmp_size'; did you mean 'thp_size'?
[-Werror=implicit-function-declaration]
238 | rc = pmem_do_write(pmem, page,
0, sector, tmp_size(page));
| ^~~~~~~~
| thp_size
cc1: some warnings being treated as errors
vim +238 drivers/nvdimm/pmem.c
230
231 static int pmem_rw_page(struct block_device *bdev, sector_t sector,
232 struct page *page, unsigned int op)
233 {
234 struct pmem_device *pmem = bdev->bd_queue->queuedata;
235 blk_status_t rc;
236
237 if (op_is_write(op))
238 rc = pmem_do_write(pmem, page, 0, sector, tmp_size(page));
239 else
240 rc = pmem_do_read(pmem, page, 0, sector, thp_size(page));
241 /*
242 * The ->rw_page interface is subtle and tricky. The core
243 * retries on any error, so we can only invoke page_endio() in
244 * the successful completion case. Otherwise, we'll see crashes
245 * caused by double completion.
246 */
247 if (rc == 0)
248 page_endio(page, op_is_write(op), 0);
249
250 return blk_status_to_errno(rc);
251 }
252
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org