On line 3033 there are two occurrences of arvif->rate_ctrl[i] julia ---------- Forwarded message ---------- Date: Wed, 19 Aug 2020 09:21:21 +0800 From: kernel test robot <lkp(a)intel.com&gt; To: kbuild(a)lists.01.org Cc: lkp(a)intel.com, Julia Lawall <julia.lawall(a)lip6.fr&gt; Subject: [ath6kl:pending 106/110] drivers/net/wireless/ath/ath10k/mac.c:3033:6-25: duplicated argument to && or || CC: kbuild-all(a)lists.01.org CC: Kalle Valo <kvalo(a)codeaurora.org&gt; CC: ath10k(a)lists.infradead.org TO: Tamizh Chelvam <tamizhr(a)codeaurora.org&gt; CC: Kalle Valo <kvalo(a)codeaurora.org&gt; tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending head: 45b6467afc71b6e19e4ffe264c448409add56f84 commit: cd275e8765b99d313c06d867af6e3fcc90484cfb [106/110] ath10k: Add new api to support TID specific configuration :::::: branch date: 15 hours ago :::::: commit date: 15 hours ago config: x86_64-randconfig-c004-20200818 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Julia Lawall <julia.lawall(a)lip6.fr&gt; coccinelle warnings: (new ones prefixed by >>) # https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=... git remote add ath6kl https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git git fetch --no-tags ath6kl pending git checkout cd275e8765b99d313c06d867af6e3fcc90484cfb vim +3033 drivers/net/wireless/ath/ath10k/mac.c 5e3dd157d7e70f Kalle Valo 2013-06-12 3020 cd275e8765b99d Tamizh Chelvam 2020-08-18 3021 static int ath10k_new_peer_tid_config(struct ath10k *ar, cd275e8765b99d Tamizh Chelvam 2020-08-18 3022 struct ieee80211_sta *sta, cd275e8765b99d Tamizh Chelvam 2020-08-18 3023 struct ath10k_vif *arvif) cd275e8765b99d Tamizh Chelvam 2020-08-18 3024 { cd275e8765b99d Tamizh Chelvam 2020-08-18 3025 struct wmi_per_peer_per_tid_cfg_arg arg = {}; cd275e8765b99d Tamizh Chelvam 2020-08-18 3026 struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv; cd275e8765b99d Tamizh Chelvam 2020-08-18 3027 bool config_apply; cd275e8765b99d Tamizh Chelvam 2020-08-18 3028 int ret, i; cd275e8765b99d Tamizh Chelvam 2020-08-18 3029 cd275e8765b99d Tamizh Chelvam 2020-08-18 3030 for (i = 0; i < ATH10K_TID_MAX; i++) { cd275e8765b99d Tamizh Chelvam 2020-08-18 3031 config_apply = false; cd275e8765b99d Tamizh Chelvam 2020-08-18 3032 if (arvif->retry_long[i] || arvif->ampdu[i] || cd275e8765b99d Tamizh Chelvam 2020-08-18 @3033 arvif->rate_ctrl[i] || arvif->rate_ctrl[i] || cd275e8765b99d Tamizh Chelvam 2020-08-18 3034 arvif->rtscts[i]) { cd275e8765b99d Tamizh Chelvam 2020-08-18 3035 config_apply = true; cd275e8765b99d Tamizh Chelvam 2020-08-18 3036 arg.tid = i; cd275e8765b99d Tamizh Chelvam 2020-08-18 3037 arg.vdev_id = arvif->vdev_id; cd275e8765b99d Tamizh Chelvam 2020-08-18 3038 arg.retry_count = arvif->retry_long[i]; cd275e8765b99d Tamizh Chelvam 2020-08-18 3039 arg.aggr_control = arvif->ampdu[i]; cd275e8765b99d Tamizh Chelvam 2020-08-18 3040 arg.rate_ctrl = arvif->rate_ctrl[i]; cd275e8765b99d Tamizh Chelvam 2020-08-18 3041 arg.rcode_flags = arvif->rate_code[i]; cd275e8765b99d Tamizh Chelvam 2020-08-18 3042 cd275e8765b99d Tamizh Chelvam 2020-08-18 3043 if (arvif->rtscts[i]) cd275e8765b99d Tamizh Chelvam 2020-08-18 3044 arg.ext_tid_cfg_bitmap = cd275e8765b99d Tamizh Chelvam 2020-08-18 3045 WMI_EXT_TID_RTS_CTS_CONFIG; cd275e8765b99d Tamizh Chelvam 2020-08-18 3046 else cd275e8765b99d Tamizh Chelvam 2020-08-18 3047 arg.ext_tid_cfg_bitmap = 0; cd275e8765b99d Tamizh Chelvam 2020-08-18 3048 cd275e8765b99d Tamizh Chelvam 2020-08-18 3049 arg.rtscts_ctrl = arvif->rtscts[i]; cd275e8765b99d Tamizh Chelvam 2020-08-18 3050 } cd275e8765b99d Tamizh Chelvam 2020-08-18 3051 cd275e8765b99d Tamizh Chelvam 2020-08-18 3052 if (arvif->noack[i]) { cd275e8765b99d Tamizh Chelvam 2020-08-18 3053 arg.ack_policy = arvif->noack[i]; cd275e8765b99d Tamizh Chelvam 2020-08-18 3054 arg.rate_ctrl = WMI_TID_CONFIG_RATE_CONTROL_DEFAULT_LOWEST_RATE; cd275e8765b99d Tamizh Chelvam 2020-08-18 3055 arg.aggr_control = WMI_TID_CONFIG_AGGR_CONTROL_DISABLE; cd275e8765b99d Tamizh Chelvam 2020-08-18 3056 config_apply = true; cd275e8765b99d Tamizh Chelvam 2020-08-18 3057 } cd275e8765b99d Tamizh Chelvam 2020-08-18 3058 cd275e8765b99d Tamizh Chelvam 2020-08-18 3059 /* Assign default value(-1) to newly connected station. cd275e8765b99d Tamizh Chelvam 2020-08-18 3060 * This is to identify station specific tid configuration not cd275e8765b99d Tamizh Chelvam 2020-08-18 3061 * configured for the station. cd275e8765b99d Tamizh Chelvam 2020-08-18 3062 */ cd275e8765b99d Tamizh Chelvam 2020-08-18 3063 arsta->retry_long[i] = -1; cd275e8765b99d Tamizh Chelvam 2020-08-18 3064 arsta->noack[i] = -1; cd275e8765b99d Tamizh Chelvam 2020-08-18 3065 arsta->ampdu[i] = -1; cd275e8765b99d Tamizh Chelvam 2020-08-18 3066 cd275e8765b99d Tamizh Chelvam 2020-08-18 3067 if (!config_apply) cd275e8765b99d Tamizh Chelvam 2020-08-18 3068 continue; cd275e8765b99d Tamizh Chelvam 2020-08-18 3069 cd275e8765b99d Tamizh Chelvam 2020-08-18 3070 ether_addr_copy(arg.peer_macaddr.addr, sta->addr); cd275e8765b99d Tamizh Chelvam 2020-08-18 3071 cd275e8765b99d Tamizh Chelvam 2020-08-18 3072 ret = ath10k_wmi_set_per_peer_per_tid_cfg(ar, &arg); cd275e8765b99d Tamizh Chelvam 2020-08-18 3073 if (ret) { cd275e8765b99d Tamizh Chelvam 2020-08-18 3074 ath10k_warn(ar, "failed to set per tid retry/aggr config for sta %pM: %d\n", cd275e8765b99d Tamizh Chelvam 2020-08-18 3075 sta->addr, ret); cd275e8765b99d Tamizh Chelvam 2020-08-18 3076 return ret; cd275e8765b99d Tamizh Chelvam 2020-08-18 3077 } cd275e8765b99d Tamizh Chelvam 2020-08-18 3078 cd275e8765b99d Tamizh Chelvam 2020-08-18 3079 memset(&arg, 0, sizeof(arg)); cd275e8765b99d Tamizh Chelvam 2020-08-18 3080 } cd275e8765b99d Tamizh Chelvam 2020-08-18 3081 cd275e8765b99d Tamizh Chelvam 2020-08-18 3082 return 0; cd275e8765b99d Tamizh Chelvam 2020-08-18 3083 } cd275e8765b99d Tamizh Chelvam 2020-08-18 3084 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org