[bigeasy-staging:lockdep-nesting 6/9] kernel/locking/lockdep.c:3878:12: error: 'struct task_struct' has no member named 'hardirq_context'; did you mean 'audit_context'?
6:57 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/bigeasy/staging.git
lockdep-nesting
head: 7b39687e8b459c32ea6d3c4c454a30917202f1fe
commit: b876daa7d5e509b6b59f48fbadb96535adfb2c9d [6/9] lockdep: Introduce wait-type
checks
config: sparc64-randconfig-a001-20200316 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout b876daa7d5e509b6b59f48fbadb96535adfb2c9d
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/locking/lockdep.c: In function 'check_wait_context':
> kernel/locking/lockdep.c:3878:12: error: 'struct
task_struct' has no member named 'hardirq_context'; did you mean
'audit_context'?
3878 | if (curr->hardirq_context) {
| ^~~~~~~~~~~~~~~
| audit_context
> kernel/locking/lockdep.c:3882:11: error: 'struct
task_struct' has no member named 'hardirq_threaded'
3882 | if
(curr->hardirq_threaded)
| ^~
> kernel/locking/lockdep.c:3886:17: error: 'struct
task_struct' has no member named 'softirq_context'
3886 | } else if
(curr->softirq_context) {
| ^~
vim +3878 kernel/locking/lockdep.c
3835
3836 /*
3837 * Verify the wait_type context.
3838 *
3839 * This check validates we takes locks in the right wait-type order; that is it
3840 * ensures that we do not take mutexes inside spinlocks and do not attempt to
3841 * acquire spinlocks inside raw_spinlocks and the sort.
3842 *
3843 * The entire thing is slightly more complex because of RCU, RCU is a lock that
3844 * can be taken from (pretty much) any context but also has constraints.
3845 * However when taken in a stricter environment the RCU lock does not loosen
3846 * the constraints.
3847 *
3848 * Therefore we must look for the strictest environment in the lock stack and
3849 * compare that to the lock we're trying to acquire.
3850 */
3851 static int check_wait_context(struct task_struct *curr, struct held_lock *next)
3852 {
3853 short next_inner = hlock_class(next)->wait_type_inner;
3854 short next_outer = hlock_class(next)->wait_type_outer;
3855 short curr_inner;
3856 int depth;
3857
3858 if (!curr->lockdep_depth || !next_inner || next->trylock)
3859 return 0;
3860
3861 if (!next_outer)
3862 next_outer = next_inner;
3863
3864 /*
3865 * Find start of current irq_context..
3866 */
3867 for (depth = curr->lockdep_depth - 1; depth >= 0; depth--) {
3868 struct held_lock *prev = curr->held_locks + depth;
3869 if (prev->irq_context != next->irq_context)
3870 break;
3871 }
3872 depth++;
3873
3874 /*
3875 * Set appropriate wait type for the context; for IRQs we have to take
3876 * into account force_irqthread as that is implied by PREEMPT_RT.
3877 */
3878 if (curr->hardirq_context) {
3879 /*
3880 * Check if force_irqthreads will run us threaded.
3881 */
3882 if (curr->hardirq_threaded)
3883 curr_inner =
LD_WAIT_CONFIG;
3884 else
3885 curr_inner = LD_WAIT_SPIN;
3886 } else if (curr->softirq_context) {
3887 /*
3888 * Softirqs are always threaded.
3889 */
3890 curr_inner = LD_WAIT_CONFIG;
3891 } else {
3892 curr_inner = LD_WAIT_MAX;
3893 }
3894
3895 for (; depth < curr->lockdep_depth; depth++) {
3896 struct held_lock *prev = curr->held_locks + depth;
3897 short prev_inner = hlock_class(prev)->wait_type_inner;
3898
3899 if (prev_inner) {
3900 /*
3901 * We can have a bigger inner than a previous one
3902 * when outer is smaller than inner, as with RCU.
3903 *
3904 * Also due to trylocks.
3905 */
3906 curr_inner = min(curr_inner, prev_inner);
3907 }
3908 }
3909
3910 if (next_outer > curr_inner)
3911 return print_lock_invalid_wait_context(curr, next);
3912
3913 return 0;
3914 }
3915
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8:54 p.m.
On 2020-03-16 15:57:38 [+0800], kbuild test robot wrote:
This (including the reports so far) is due to CONFIG_TRACE_IRQFLAGS=n
and CONFIG_LOCKDEP=y. I intend to move check_wait_context() under
CONFIG_PROVE_LOCKING:
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index df74531fd9f85..b2e9062bec1d6 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -3686,126 +3686,6 @@ static int mark_lock(struct task_struct *curr, struct held_lock
*this,
return ret;
}
-#else /* CONFIG_PROVE_LOCKING */
-
-static inline int
-mark_usage(struct task_struct *curr, struct held_lock *hlock, int check)
-{
- return 1;
-}
-
-static inline unsigned int task_irq_context(struct task_struct *task)
-{
- return 0;
-}
-
-static inline int separate_irq_context(struct task_struct *curr,
- struct held_lock *hlock)
-{
- return 0;
-}
-
-#endif /* CONFIG_PROVE_LOCKING */
-
-/*
- * Initialize a lock instance's lock-class mapping info:
- */
-void lockdep_init_map_waits(struct lockdep_map *lock, const char *name,
- struct lock_class_key *key, int subclass,
- short inner, short outer)
-{
- int i;
-
- for (i = 0; i < NR_LOCKDEP_CACHING_CLASSES; i++)
- lock->class_cache[i] = NULL;
-
-#ifdef CONFIG_LOCK_STAT
- lock->cpu = raw_smp_processor_id();
-#endif
-
- /*
- * Can't be having no nameless bastards around this place!
- */
- if (DEBUG_LOCKS_WARN_ON(!name)) {
- lock->name = "NULL";
- return;
- }
-
- lock->name = name;
-
- lock->wait_type_outer = outer;
- lock->wait_type_inner = inner;
-
- /*
- * No key, no joy, we need to hash something.
- */
- if (DEBUG_LOCKS_WARN_ON(!key))
- return;
- /*
- * Sanity check, the lock-class key must either have been allocated
- * statically or must have been registered as a dynamic key.
- */
- if (!static_obj(key) && !is_dynamic_key(key)) {
- if (debug_locks)
- printk(KERN_ERR "BUG: key %px has not been registered!\n", key);
- DEBUG_LOCKS_WARN_ON(1);
- return;
- }
- lock->key = key;
-
- if (unlikely(!debug_locks))
- return;
-
- if (subclass) {
- unsigned long flags;
-
- if (DEBUG_LOCKS_WARN_ON(current->lockdep_recursion))
- return;
-
- raw_local_irq_save(flags);
- current->lockdep_recursion = 1;
- register_lock_class(lock, subclass, 1);
- current->lockdep_recursion = 0;
- raw_local_irq_restore(flags);
- }
-}
-EXPORT_SYMBOL_GPL(lockdep_init_map_waits);
-
-struct lock_class_key __lockdep_no_validate__;
-EXPORT_SYMBOL_GPL(__lockdep_no_validate__);
-
-static void
-print_lock_nested_lock_not_held(struct task_struct *curr,
- struct held_lock *hlock,
- unsigned long ip)
-{
- if (!debug_locks_off())
- return;
- if (debug_locks_silent)
- return;
-
- pr_warn("\n");
- pr_warn("==================================\n");
- pr_warn("WARNING: Nested lock was not taken\n");
- print_kernel_ident();
- pr_warn("----------------------------------\n");
-
- pr_warn("%s/%d is trying to lock:\n", curr->comm, task_pid_nr(curr));
- print_lock(hlock);
-
- pr_warn("\nbut this task is not holding:\n");
- pr_warn("%s\n", hlock->nest_lock->name);
-
- pr_warn("\nstack backtrace:\n");
- dump_stack();
-
- pr_warn("\nother info that might help us debug this:\n");
- lockdep_print_held_locks(curr);
-
- pr_warn("\nstack backtrace:\n");
- dump_stack();
-}
-
static int
print_lock_invalid_wait_context(struct task_struct *curr,
struct held_lock *hlock)
@@ -3913,6 +3793,132 @@ static int check_wait_context(struct task_struct *curr, struct
held_lock *next)
return 0;
}
+#else /* CONFIG_PROVE_LOCKING */
+
+static inline int
+mark_usage(struct task_struct *curr, struct held_lock *hlock, int check)
+{
+ return 1;
+}
+
+static inline unsigned int task_irq_context(struct task_struct *task)
+{
+ return 0;
+}
+
+static inline int separate_irq_context(struct task_struct *curr,
+ struct held_lock *hlock)
+{
+ return 0;
+}
+
+static inline int check_wait_context(struct task_struct *curr,
+ struct held_lock *next)
+{
+ return 0;
+}
+
+#endif /* CONFIG_PROVE_LOCKING */
+
+/*
+ * Initialize a lock instance's lock-class mapping info:
+ */
+void lockdep_init_map_waits(struct lockdep_map *lock, const char *name,
+ struct lock_class_key *key, int subclass,
+ short inner, short outer)
+{
+ int i;
+
+ for (i = 0; i < NR_LOCKDEP_CACHING_CLASSES; i++)
+ lock->class_cache[i] = NULL;
+
+#ifdef CONFIG_LOCK_STAT
+ lock->cpu = raw_smp_processor_id();
+#endif
+
+ /*
+ * Can't be having no nameless bastards around this place!
+ */
+ if (DEBUG_LOCKS_WARN_ON(!name)) {
+ lock->name = "NULL";
+ return;
+ }
+
+ lock->name = name;
+
+ lock->wait_type_outer = outer;
+ lock->wait_type_inner = inner;
+
+ /*
+ * No key, no joy, we need to hash something.
+ */
+ if (DEBUG_LOCKS_WARN_ON(!key))
+ return;
+ /*
+ * Sanity check, the lock-class key must either have been allocated
+ * statically or must have been registered as a dynamic key.
+ */
+ if (!static_obj(key) && !is_dynamic_key(key)) {
+ if (debug_locks)
+ printk(KERN_ERR "BUG: key %px has not been registered!\n", key);
+ DEBUG_LOCKS_WARN_ON(1);
+ return;
+ }
+ lock->key = key;
+
+ if (unlikely(!debug_locks))
+ return;
+
+ if (subclass) {
+ unsigned long flags;
+
+ if (DEBUG_LOCKS_WARN_ON(current->lockdep_recursion))
+ return;
+
+ raw_local_irq_save(flags);
+ current->lockdep_recursion = 1;
+ register_lock_class(lock, subclass, 1);
+ current->lockdep_recursion = 0;
+ raw_local_irq_restore(flags);
+ }
+}
+EXPORT_SYMBOL_GPL(lockdep_init_map_waits);
+
+struct lock_class_key __lockdep_no_validate__;
+EXPORT_SYMBOL_GPL(__lockdep_no_validate__);
+
+static void
+print_lock_nested_lock_not_held(struct task_struct *curr,
+ struct held_lock *hlock,
+ unsigned long ip)
+{
+ if (!debug_locks_off())
+ return;
+ if (debug_locks_silent)
+ return;
+
+ pr_warn("\n");
+ pr_warn("==================================\n");
+ pr_warn("WARNING: Nested lock was not taken\n");
+ print_kernel_ident();
+ pr_warn("----------------------------------\n");
+
+ pr_warn("%s/%d is trying to lock:\n", curr->comm, task_pid_nr(curr));
+ print_lock(hlock);
+
+ pr_warn("\nbut this task is not holding:\n");
+ pr_warn("%s\n", hlock->nest_lock->name);
+
+ pr_warn("\nstack backtrace:\n");
+ dump_stack();
+
+ pr_warn("\nother info that might help us debug this:\n");
+ lockdep_print_held_locks(curr);
+
+ pr_warn("\nstack backtrace:\n");
+ dump_stack();
+}
+
static int __lock_is_held(const struct lockdep_map *lock, int read);
/*
Sebastian
918
days inactive
918
days old
1 comments
2 participants
participants (2)
-
kbuild test robot -
Sebastian Andrzej Siewior