From: kernel test robot <lkp(a)intel.com&gt; drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 7d272e63e097 ("net: phy: mscc: timestamping and PHC support") CC: Antoine Tenart <antoine.tenart(a)bootlin.com&gt; Signed-off-by: kernel test robot <lkp(a)intel.com&gt; --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b966b5cf71790478be7726593d011cb085a97a94 commit: 7d272e63e0979d38a6256108adbe462d621c26c5 [2625/6900] net: phy: mscc: timestamping and PHC support mscc_ptp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/net/phy/mscc/mscc_ptp.c +++ b/drivers/net/phy/mscc/mscc_ptp.c @@ -1493,10 +1493,7 @@ static int __vsc8584_init_ptp(struct phy vsc8531->ptp->ptp_clock = ptp_clock_register(&vsc8531->ptp->caps, &phydev->mdio.dev); - if (IS_ERR(vsc8531->ptp->ptp_clock)) - return PTR_ERR(vsc8531->ptp->ptp_clock); - - return 0; + return PTR_ERR_OR_ZERO(vsc8531->ptp->ptp_clock); } void vsc8584_config_ts_intr(struct phy_device *phydev)