Hi Huacai,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/irq/core]
[also build test WARNING on linux/master linus/master v5.15-rc5 next-20211011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Huacai-Chen/irqchip-Add-LoongArc...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
b70e13885cf63b6f99cbd9a1dbb6beaa2622bf68
config: mips-loongson2k_defconfig (attached as .config)
compiler: mips64el-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/2bea942946e85ba99a5ff261f18347f2b...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Huacai-Chen/irqchip-Add-LoongArch-related-irqchip-drivers/20211011-164738
git checkout 2bea942946e85ba99a5ff261f18347f2b36b8742
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=mips SHELL=/bin/bash drivers/irqchip/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/irqchip/irq-loongson-pch-lpc.c:149:48: warning:
'struct acpi_madt_lpc_pic' declared inside parameter list will not be visible
outside of this definition or declaration
149 |
struct acpi_madt_lpc_pic *acpi_pchlpc)
| ^~~~~~~~~~~~~~~~~
> drivers/irqchip/irq-loongson-pch-lpc.c:148:20: warning: no
previous prototype for 'pch_lpc_acpi_init' [-Wmissing-prototypes]
148 |
struct irq_domain *pch_lpc_acpi_init(struct irq_domain *parent,
| ^~~~~~~~~~~~~~~~~
In file included from arch/mips/include/asm/mmiowb.h:5,
from include/linux/spinlock.h:65,
from include/linux/wait.h:9,
from include/linux/pid.h:6,
from include/linux/sched.h:14,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from drivers/irqchip/irq-loongson-pch-lpc.c:10:
drivers/irqchip/irq-loongson-pch-lpc.c: In function 'pch_lpc_acpi_init':
drivers/irqchip/irq-loongson-pch-lpc.c:164:41: error: invalid use of undefined type
'struct acpi_madt_lpc_pic'
164 | priv->base = ioremap(acpi_pchlpc->address,
acpi_pchlpc->size);
| ^~
arch/mips/include/asm/io.h:180:23: note: in definition of macro 'ioremap'
180 | ioremap_prot((offset), (size), _CACHE_UNCACHED)
| ^~~~~~
drivers/irqchip/irq-loongson-pch-lpc.c:164:63: error: invalid use of undefined type
'struct acpi_madt_lpc_pic'
164 | priv->base = ioremap(acpi_pchlpc->address,
acpi_pchlpc->size);
| ^~
arch/mips/include/asm/io.h:180:33: note: in definition of macro 'ioremap'
180 | ioremap_prot((offset), (size), _CACHE_UNCACHED)
| ^~~~
drivers/irqchip/irq-loongson-pch-lpc.c:187:38: error: invalid use of undefined type
'struct acpi_madt_lpc_pic'
187 | fwspec.param[0] = acpi_pchlpc->cascade;
| ^~
vim +149 drivers/irqchip/irq-loongson-pch-lpc.c
147
148 struct irq_domain *pch_lpc_acpi_init(struct irq_domain *parent,
149 struct acpi_madt_lpc_pic *acpi_pchlpc)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org