Hi Mingwei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/queue] [also build test WARNING on cryptodev/master linus/master v5.14-rc6 next-20210816] [cannot apply to crypto/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mingwei-Zhang/clean-up-interface... base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/9e861d15c92e637c18f50884ef30352ed... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mingwei-Zhang/clean-up-interface-between-KVM-and-psp/20210817-042720 git checkout 9e861d15c92e637c18f50884ef30352edb0da7aa # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): drivers/crypto/ccp/sev-dev.c: In function 'sev_guest_decommission': drivers/crypto/ccp/sev-dev.c:914:42: error: 'data' undeclared (first use in this function); did you mean '_data'? 914 | return sev_do_cmd(SEV_CMD_DECOMMISSION, data, error); | ^~~~ | _data drivers/crypto/ccp/sev-dev.c:914:42: note: each undeclared identifier is reported only once for each function it appears in 908 | struct sev_data_decommission decommission; | ^~~~~~~~~~~~ drivers/crypto/ccp/sev-dev.c:915:1: error: control reaches end of non-void function [-Werror=return-type] 915 | } | ^ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for PHY_SPARX5_SERDES Depends on (ARCH_SPARX5 || COMPILE_TEST && OF && HAS_IOMEM Selected by - SPARX5_SWITCH && NETDEVICES && ETHERNET && NET_VENDOR_MICROCHIP && NET_SWITCHDEV && HAS_IOMEM && OF vim +/decommission +908 drivers/crypto/ccp/sev-dev.c 905 906 int sev_guest_decommission(unsigned int handle, int *error) 907 { 909 910 if (!handle) 911 return -EINVAL; 912 913 decommission.handle = handle; 915 } 916 EXPORT_SYMBOL_GPL(sev_guest_decommission); 917 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org