Hi Ezequiel, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on rockchip/for-next pza/reset/next v5.13-rc7 next-20210621] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ezequiel-Garcia/hantro-Small-nit... base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-a006-20210622 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b3634d3e88b7f26534a5057bff182b7dced584fc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/a4118b182653ffbf6229d186eb46052c3... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ezequiel-Garcia/hantro-Small-nitpicks/20210622-071354 git checkout a4118b182653ffbf6229d186eb46052c34ae995c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): hdr->last_frame_ts); ^~~~~~~~~~~~~~~~~~ drivers/staging/media/hantro/hantro.h:322:28: note: expanded from macro 'vpu_debug' __func__, __LINE__, ##args); \ ^~~~ include/linux/printk.h:373:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/media/hantro/hantro_g1_vp8_dec.c:389:6: warning: format specifies type 'long' but the argument has type '__u64' (aka 'unsigned long long') [-Wformat] hdr->golden_frame_ts); ^~~~~~~~~~~~~~~~~~~~ drivers/staging/media/hantro/hantro.h:322:28: note: expanded from macro 'vpu_debug' __func__, __LINE__, ##args); \ ^~~~ include/linux/printk.h:373:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/media/hantro/hantro_g1_vp8_dec.c:399:6: warning: format specifies type 'long' but the argument has type '__u64' (aka 'unsigned long long') [-Wformat] hdr->alt_frame_ts); ^~~~~~~~~~~~~~~~~ drivers/staging/media/hantro/hantro.h:322:28: note: expanded from macro 'vpu_debug' __func__, __LINE__, ##args); \ ^~~~ include/linux/printk.h:373:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ 3 warnings generated. -- hdr->last_frame_ts); ^~~~~~~~~~~~~~~~~~ drivers/staging/media/hantro/hantro.h:322:28: note: expanded from macro 'vpu_debug' __func__, __LINE__, ##args); \ ^~~~ include/linux/printk.h:373:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:466:6: warning: format specifies type 'long' but the argument has type '__u64' (aka 'unsigned long long') [-Wformat] hdr->golden_frame_ts); ^~~~~~~~~~~~~~~~~~~~ drivers/staging/media/hantro/hantro.h:322:28: note: expanded from macro 'vpu_debug' __func__, __LINE__, ##args); \ ^~~~ include/linux/printk.h:373:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:476:6: warning: format specifies type 'long' but the argument has type '__u64' (aka 'unsigned long long') [-Wformat] hdr->alt_frame_ts); ^~~~~~~~~~~~~~~~~ drivers/staging/media/hantro/hantro.h:322:28: note: expanded from macro 'vpu_debug' __func__, __LINE__, ##args); \ ^~~~ include/linux/printk.h:373:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ 3 warnings generated. vim +381 drivers/staging/media/hantro/hantro_g1_vp8_dec.c 368 369 static void cfg_ref(struct hantro_ctx *ctx, 370 const struct v4l2_ctrl_vp8_frame *hdr) 371 { 372 struct hantro_dev *vpu = ctx->dev; 373 struct vb2_v4l2_buffer *vb2_dst; 374 dma_addr_t ref; 375 376 vb2_dst = hantro_get_dst_buf(ctx); 377 378 ref = hantro_get_ref(ctx, hdr->last_frame_ts); 379 if (!ref) { 380 vpu_debug(0, "failed to find last frame ts=%ld\n", 382 ref = vb2_dma_contig_plane_dma_addr(&vb2_dst->vb2_buf, 0); 383 } 384 vdpu_write_relaxed(vpu, ref, G1_REG_ADDR_REF(0)); 385 386 ref = hantro_get_ref(ctx, hdr->golden_frame_ts); 387 if (!ref && hdr->golden_frame_ts) 388 vpu_debug(0, "failed to find golden frame ts=%ld\n", 389 hdr->golden_frame_ts); 390 if (!ref) 391 ref = vb2_dma_contig_plane_dma_addr(&vb2_dst->vb2_buf, 0); 392 if (hdr->flags & V4L2_VP8_FRAME_FLAG_SIGN_BIAS_GOLDEN) 393 ref |= G1_REG_ADDR_REF_TOPC_E; 394 vdpu_write_relaxed(vpu, ref, G1_REG_ADDR_REF(4)); 395 396 ref = hantro_get_ref(ctx, hdr->alt_frame_ts); 397 if (!ref && hdr->alt_frame_ts) 398 vpu_debug(0, "failed to find alt frame ts=%ld\n", 399 hdr->alt_frame_ts); 400 if (!ref) 401 ref = vb2_dma_contig_plane_dma_addr(&vb2_dst->vb2_buf, 0); 402 if (hdr->flags & V4L2_VP8_FRAME_FLAG_SIGN_BIAS_ALT) 403 ref |= G1_REG_ADDR_REF_TOPC_E; 404 vdpu_write_relaxed(vpu, ref, G1_REG_ADDR_REF(5)); 405 } 406 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org