Hi Ezequiel, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on rockchip/for-next pza/reset/next v5.13-rc7 next-20210622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ezequiel-Garcia/hantro-Small-nit... base: git://linuxtv.org/media_tree.git master config: microblaze-randconfig-r026-20210622 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/a4118b182653ffbf6229d186eb46052c3... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ezequiel-Garcia/hantro-Small-nitpicks/20210622-071354 git checkout a4118b182653ffbf6229d186eb46052c34ae995c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7, from include/linux/kernel.h:17, from include/linux/videodev2.h:60, from include/media/videobuf2-v4l2.h:15, from include/media/v4l2-mem2mem.h:16, from drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:15: drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c: In function 'cfg_ref': 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO' 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/media/hantro/hantro.h:321:4: note: in expansion of macro 'pr_info' 321 | pr_info("%s:%d: " fmt, \ | ^~~~~~~ drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:457:3: note: in expansion of macro 'vpu_debug' 457 | vpu_debug(0, "failed to find last frame ts=%ld\n", | ^~~~~~~~~ drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:457:48: note: format string is defined here 457 | vpu_debug(0, "failed to find last frame ts=%ld\n", | ~~^ | | | long int | %lld In file included from include/linux/printk.h:7, from include/linux/kernel.h:17, from include/linux/videodev2.h:60, from include/media/videobuf2-v4l2.h:15, from include/media/v4l2-mem2mem.h:16, from drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:15: 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO' 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/media/hantro/hantro.h:321:4: note: in expansion of macro 'pr_info' 321 | pr_info("%s:%d: " fmt, \ | ^~~~~~~ drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:465:3: note: in expansion of macro 'vpu_debug' 465 | vpu_debug(0, "failed to find golden frame ts=%ld\n", | ^~~~~~~~~ drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:465:50: note: format string is defined here 465 | vpu_debug(0, "failed to find golden frame ts=%ld\n", | ~~^ | | | long int | %lld In file included from include/linux/printk.h:7, from include/linux/kernel.h:17, from include/linux/videodev2.h:60, from include/media/videobuf2-v4l2.h:15, from include/media/v4l2-mem2mem.h:16, from drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:15: 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO' 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/media/hantro/hantro.h:321:4: note: in expansion of macro 'pr_info' 321 | pr_info("%s:%d: " fmt, \ | ^~~~~~~ drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:475:3: note: in expansion of macro 'vpu_debug' 475 | vpu_debug(0, "failed to find alt frame ts=%ld\n", | ^~~~~~~~~ drivers/staging/media/hantro/rockchip_vpu2_hw_vp8_dec.c:475:47: note: format string is defined here 475 | vpu_debug(0, "failed to find alt frame ts=%ld\n", | ~~^ | | | long int | %lld -- In file included from include/linux/printk.h:7, from include/linux/kernel.h:17, from include/linux/videodev2.h:60, from include/media/videobuf2-v4l2.h:15, from include/media/v4l2-mem2mem.h:16, from drivers/staging/media/hantro/hantro_g1_vp8_dec.c:12: drivers/staging/media/hantro/hantro_g1_vp8_dec.c: In function 'cfg_ref': 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO' 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/media/hantro/hantro.h:321:4: note: in expansion of macro 'pr_info' 321 | pr_info("%s:%d: " fmt, \ | ^~~~~~~ drivers/staging/media/hantro/hantro_g1_vp8_dec.c:380:3: note: in expansion of macro 'vpu_debug' 380 | vpu_debug(0, "failed to find last frame ts=%ld\n", | ^~~~~~~~~ drivers/staging/media/hantro/hantro_g1_vp8_dec.c:380:48: note: format string is defined here 380 | vpu_debug(0, "failed to find last frame ts=%ld\n", | ~~^ | | | long int | %lld In file included from include/linux/printk.h:7, from include/linux/kernel.h:17, from include/linux/videodev2.h:60, from include/media/videobuf2-v4l2.h:15, from include/media/v4l2-mem2mem.h:16, from drivers/staging/media/hantro/hantro_g1_vp8_dec.c:12: 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO' 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/media/hantro/hantro.h:321:4: note: in expansion of macro 'pr_info' 321 | pr_info("%s:%d: " fmt, \ | ^~~~~~~ drivers/staging/media/hantro/hantro_g1_vp8_dec.c:388:3: note: in expansion of macro 'vpu_debug' 388 | vpu_debug(0, "failed to find golden frame ts=%ld\n", | ^~~~~~~~~ drivers/staging/media/hantro/hantro_g1_vp8_dec.c:388:50: note: format string is defined here 388 | vpu_debug(0, "failed to find golden frame ts=%ld\n", | ~~^ | | | long int | %lld In file included from include/linux/printk.h:7, from include/linux/kernel.h:17, from include/linux/videodev2.h:60, from include/media/videobuf2-v4l2.h:15, from include/media/v4l2-mem2mem.h:16, from drivers/staging/media/hantro/hantro_g1_vp8_dec.c:12: 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO' 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/media/hantro/hantro.h:321:4: note: in expansion of macro 'pr_info' 321 | pr_info("%s:%d: " fmt, \ | ^~~~~~~ drivers/staging/media/hantro/hantro_g1_vp8_dec.c:398:3: note: in expansion of macro 'vpu_debug' 398 | vpu_debug(0, "failed to find alt frame ts=%ld\n", | ^~~~~~~~~ drivers/staging/media/hantro/hantro_g1_vp8_dec.c:398:47: note: format string is defined here 398 | vpu_debug(0, "failed to find alt frame ts=%ld\n", | ~~^ | | | long int | %lld vim +5 include/linux/kern_levels.h 314ba3520e513a Joe Perches 2012-07-30 4 04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c83d0e3a Joe Perches 2012-07-30 7 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org