[frank-w-bpi-r2-4.14:5.8-rc 5/38] drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/assoc.c:1549:44-45: WARNING: Use ARRAY_SIZE
10:19 p.m.
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
config: arm-randconfig-c023-20200712 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
coccinelle warnings: (new ones prefixed by >>)
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/assoc.c:1549:44-45: WARNING: Use
ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/auth.c:820:39-40: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/auth.c:389:37-38:
WARNING: Use ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/auth.c:426:37-38: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/auth.c:483:37-38: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/auth.c:559:37-38: WARNING: Use
ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_init.c:799:45-46: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_init.c:801:45-46: WARNING: Use
ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_proc.c:899:31-32: WARNING: Use
ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_wext.c:412:41-42: WARNING: Use
ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/hem_mbox.c:610:29-30: WARNING: Use
ARRAY_SIZE
--
> drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic.c:681:66-67:
WARNING: Use ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:3176:38-39: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:3212:43-44: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:2927:42-43: WARNING: Use
ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_ie.c:472:41-42: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_ie.c:507:46-47:
WARNING: Use ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/scan.c:2062:42-43: WARNING: Use
ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/swcr.c:970:38-39: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/swcr.c:947:36-37:
WARNING: Use ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:4252:35-36: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:2677:55-56: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:2680:57-58: WARNING: Use
ARRAY_SIZE
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:3361:43-44: WARNING: Use
ARRAY_SIZE
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_cfg80211.c:1587:54-55: WARNING
comparing pointer to 0
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_cfg80211.c:999:54-55: WARNING
comparing pointer to 0
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_kal.c:1070:68-73: WARNING:
conversion to bool not needed here
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_bow.c:328:1-3: ERROR: test of a
variable/field address
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c:414:7-15: ERROR: iterator
variable bound on line 412 cannot be NULL
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_wext_priv.c:2821:12-19: WARNING
opportunity for memdup_user
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/ais_fsm.c:4945:13-24: Unneeded variable:
"rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 5003
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_kal.c:1356:13-20: Unneeded
variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 1368
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p.c:2435:5-13: Unneeded
variable: "i4Status". Return "0" on line 2490
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p.c:2350:5-13: Unneeded
variable: "i4Status". Return "0" on line 2411
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_cfg80211.c:1607:5-11:
Unneeded variable: "status". Return "0" on line 1688
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_cfg80211.c:1795:5-11:
Unneeded variable: "status". Return "0" on line 1848
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_wext_priv.c:2649:13-20: Unneeded
variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 2662
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3012:13-20: Unneeded variable:
"rStatus". Return "WLAN_STATUS_SUCCESS" on line 3022
> drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3068:13-24: Unneeded
variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 3091
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3036:13-24: Unneeded
variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 3049
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:2056:9-26: Unneeded variable:
"fgIsReplyProbeRsp". Return "FALSE" on line 2077
> drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:1301:13-24: Unneeded
variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 1373
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:1689:13-21: Unneeded
variable: "u4Status". Return "WLAN_STATUS_SUCCESS" on line 1775
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_oid.c:5224:15-22: Unneeded
variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 5227
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_oid.c:5259:15-22: Unneeded
variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 5262
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_p2p.c:1259:13-24: Unneeded
variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 1282
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_pwr_mgt.c:650:2-3: Unneeded semicolon
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_tx.c:1955:2-3: Unneeded semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_tx.c:1129:2-3: Unneeded
semicolon
--
>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:1719:4-5: Unneeded
semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:3173:2-3: Unneeded
semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:2994:2-3: Unneeded
semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:2916:2-3: Unneeded
semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:2646:2-3: Unneeded
semicolon
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10:19 p.m.
New subject: [PATCH] mt6625l: fix badzero.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_cfg80211.c:1587:54-55: WARNING
comparing pointer to 0
Compare pointer-typed values to NULL rather than 0
Semantic patch information:
This makes an effort to choose between !x and x == NULL. !x is used
if it has previously been used with the function used to initialize x.
This relies on type information. More type information can be obtained
using the option -all_includes and the option -I to specify an
include path.
Generated by: scripts/coccinelle/null/badzero.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
gl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_cfg80211.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_cfg80211.c
@@ -1584,7 +1584,7 @@ mtk_cfg80211_mgmt_tx(struct wiphy *wiphy
DBGLOG(REQ, TRACE, "--> %s()\n", __func__);
#endif
- if ((wiphy == NULL) || (wdev == NULL) || (params == 0) || (cookie == NULL))
+ if ((wiphy == NULL) || (wdev == NULL) || (params == NULL) || (cookie == NULL))
break;
prGlueInfo = (P_GLUE_INFO_T) wiphy_priv(wiphy);
10:19 p.m.
New subject: [PATCH] mt6625l: fix badzero.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_cfg80211.c:999:54-55: WARNING
comparing pointer to 0
Compare pointer-typed values to NULL rather than 0
Semantic patch information:
This makes an effort to choose between !x and x == NULL. !x is used
if it has previously been used with the function used to initialize x.
This relies on type information. More type information can be obtained
using the option -all_includes and the option -I to specify an
include path.
Generated by: scripts/coccinelle/null/badzero.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
gl_p2p_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_cfg80211.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_cfg80211.c
@@ -996,7 +996,7 @@ int mtk_p2p_cfg80211_mgmt_tx(struct wiph
PUINT_8 pucFrameBuf = (PUINT_8) NULL;
do {
- if ((wiphy == NULL) || (wdev == NULL) || (params == 0) || (cookie == NULL))
+ if ((wiphy == NULL) || (wdev == NULL) || (params == NULL) || (cookie == NULL))
break;
/* DBGLOG(P2P, TRACE, ("mtk_p2p_cfg80211_mgmt_tx\n")); */
10:19 p.m.
New subject: [PATCH] mt6625l: fix boolconv.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_kal.c:1070:68-73: WARNING:
conversion to bool not needed here
Remove unneeded conversion to bool
Semantic patch information:
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.
Generated by: scripts/coccinelle/misc/boolconv.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
gl_p2p_kal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_kal.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_kal.c
@@ -1067,7 +1067,7 @@ kalP2PGCIndicateConnectionStatus(IN P_GL
/* Disconnect, what if u2StatusReason == 0? */
cfg80211_disconnected(prGlueP2pInfo->prDevHandler, /* struct net_device * dev, */
u2StatusReason, pucRxIEBuf, u2RxIELen,
- eStatus == WLAN_STATUS_MEDIA_DISCONNECT_LOCALLY ? true : false,
+ eStatus == WLAN_STATUS_MEDIA_DISCONNECT_LOCALLY,
GFP_KERNEL);
}
10:19 p.m.
New subject: [PATCH] mt6625l: fix itnull.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c:414:7-15: ERROR: iterator
variable bound on line 412 cannot be NULL
Many iterators have the property that the first argument is always bound
to a real list element, never NULL.
Semantic patch information:
False positives arise for some iterators that do not have this property,
or in cases when the loop cursor is reassigned. The latter should only
happen when the matched code is on the way to a loop exit (break, goto,
or return).
Generated by: scripts/coccinelle/iterators/itnull.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
p2p_rlm.c | 4 ----
1 file changed, 4 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c
@@ -411,10 +411,6 @@ VOID rlmUpdateParamsForAP(P_ADAPTER_T pr
LINK_FOR_EACH_ENTRY(prStaRec, prStaList, rLinkEntry, STA_RECORD_T) {
/* ASSERT(prStaRec); */
- if (!prStaRec) {
- DBGLOG(P2P, TRACE, "prStaRec is NULL in rlmUpdateParamsForAP()\n");
- break;
- }
if (prStaRec->fgIsInUse && prStaRec->ucStaState == STA_STATE_3
&&
prStaRec->ucNetTypeIndex == prBssInfo->ucNetTypeIndex) {
if (!(prStaRec->ucPhyTypeSet & (PHY_TYPE_SET_802_11GN | PHY_TYPE_SET_802_11A)))
{
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/ais_fsm.c:4945:13-24: Unneeded variable:
"rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 5003
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
ais_fsm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/ais_fsm.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/ais_fsm.c
@@ -4942,7 +4942,6 @@ WLAN_STATUS
aisFuncTxMgmtFrame(IN P_ADAPTER_T prAdapter,
IN P_AIS_MGMT_TX_REQ_INFO_T prMgmtTxReqInfo, IN P_MSDU_INFO_T prMgmtTxMsdu, IN
UINT_64 u8Cookie)
{
- WLAN_STATUS rWlanStatus = WLAN_STATUS_SUCCESS;
P_MSDU_INFO_T prTxMsduInfo = (P_MSDU_INFO_T) NULL;
P_WLAN_MAC_HEADER_T prWlanHdr = (P_WLAN_MAC_HEADER_T) NULL;
P_STA_RECORD_T prStaRec = (P_STA_RECORD_T) NULL;
@@ -5000,7 +4999,7 @@ aisFuncTxMgmtFrame(IN P_ADAPTER_T prAdap
} while (FALSE);
- return rWlanStatus;
+ return WLAN_STATUS_SUCCESS;
} /* aisFuncTxMgmtFrame */
/*----------------------------------------------------------------------------*/
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_kal.c:1356:13-20: Unneeded
variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 1368
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
gl_kal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_kal.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_kal.c
@@ -1353,7 +1353,6 @@ kalProcessRxPacket(IN P_GLUE_INFO_T prGl
/* IN PBOOLEAN pfgIsRetain, */
IN BOOLEAN fgIsRetain, IN ENUM_CSUM_RESULT_T aerCSUM[])
{
- WLAN_STATUS rStatus = WLAN_STATUS_SUCCESS;
struct sk_buff *skb = (struct sk_buff *)pvPacket;
skb->data = pucPacketStart;
@@ -1365,7 +1364,7 @@ kalProcessRxPacket(IN P_GLUE_INFO_T prGl
kalUpdateRxCSUMOffloadParam(skb, aerCSUM);
#endif
- return rStatus;
+ return WLAN_STATUS_SUCCESS;
}
#if (CONF_HIF_LOOPBACK_AUTO == 1)
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p.c:2435:5-13: Unneeded
variable: "i4Status". Return "0" on line 2490
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p.c:2350:5-13: Unneeded
variable: "i4Status". Return "0" on line 2411
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
gl_p2p.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p.c
@@ -2347,7 +2347,6 @@ int
mtk_p2p_wext_invitation_request(IN struct net_device *prDev,
IN struct iw_request_info *info, IN OUT union iwreq_data *wrqu, IN OUT char *extra)
{
- int i4Status = 0;
#if 0
P_ADAPTER_T prAdapter = (P_ADAPTER_T) NULL;
P_GLUE_INFO_T prGlueInfo = (P_GLUE_INFO_T) NULL;
@@ -2408,7 +2407,7 @@ mtk_p2p_wext_invitation_request(IN struc
} while (FALSE);
#endif
- return i4Status;
+ return 0;
}
@@ -2432,7 +2431,6 @@ int
mtk_p2p_wext_invitation_abort(IN struct net_device *prDev,
IN struct iw_request_info *info, IN OUT union iwreq_data *wrqu, IN OUT char
*extra)
{
- int i4Status = 0;
#if 0
P_ADAPTER_T prAdapter = (P_ADAPTER_T) NULL;
P_GLUE_INFO_T prGlueInfo = (P_GLUE_INFO_T) NULL;
@@ -2487,7 +2485,7 @@ mtk_p2p_wext_invitation_abort(IN struct
} while (FALSE);
#endif
- return i4Status;
+ return 0;
}
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_wext_priv.c:2649:13-20: Unneeded
variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 2662
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
gl_wext_priv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_wext_priv.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_wext_priv.c
@@ -2646,8 +2646,6 @@ static WLAN_STATUS
reqExtSetAcpiDevicePowerState(IN P_GLUE_INFO_T prGlueInfo,
IN PVOID pvSetBuffer, IN UINT_32 u4SetBufferLen, OUT PUINT_32 pu4SetInfoLen)
{
- WLAN_STATUS rStatus = WLAN_STATUS_SUCCESS;
-
ASSERT(prGlueInfo);
ASSERT(pvSetBuffer);
ASSERT(pu4SetInfoLen);
@@ -2659,7 +2657,7 @@ reqExtSetAcpiDevicePowerState(IN P_GLUE_
/* pvSetBuffer, */
/* u4SetBufferLen, */
/* pu4SetInfoLen); */
- return rStatus;
+ return WLAN_STATUS_SUCCESS;
}
int priv_driver_set_chip_config(IN struct net_device *prNetDev, IN char *pcCommand, IN
int i4TotalLen)
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3012:13-20: Unneeded variable:
"rStatus". Return "WLAN_STATUS_SUCCESS" on line 3022
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3068:13-24: Unneeded variable:
"rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 3091
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3036:13-24: Unneeded variable:
"rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 3049
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
p2p_fsm.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c
@@ -3009,8 +3009,6 @@ WLAN_STATUS p2pRunEventAAAComplete(IN P_
/*----------------------------------------------------------------------------*/
WLAN_STATUS p2pRunEventAAASuccess(IN P_ADAPTER_T prAdapter, IN P_STA_RECORD_T prStaRec)
{
- WLAN_STATUS rStatus = WLAN_STATUS_SUCCESS;
-
do {
ASSERT_BREAK((prAdapter != NULL) && (prStaRec != NULL));
@@ -3019,7 +3017,7 @@ WLAN_STATUS p2pRunEventAAASuccess(IN P_A
} while (FALSE);
- return rStatus;
+ return WLAN_STATUS_SUCCESS;
} /* p2pRunEventAAASuccess */
/*----------------------------------------------------------------------------*/
@@ -3033,7 +3031,6 @@ WLAN_STATUS p2pRunEventAAASuccess(IN P_A
/*----------------------------------------------------------------------------*/
WLAN_STATUS p2pRxPublicActionFrame(IN P_ADAPTER_T prAdapter, IN P_SW_RFB_T prSwRfb)
{
- WLAN_STATUS rWlanStatus = WLAN_STATUS_SUCCESS;
P_P2P_PUBLIC_ACTION_FRAME_T prPublicActionFrame = (P_P2P_PUBLIC_ACTION_FRAME_T) NULL;
P_P2P_FSM_INFO_T prP2pFsmInfo = (P_P2P_FSM_INFO_T) NULL;
@@ -3046,7 +3043,7 @@ WLAN_STATUS p2pRxPublicActionFrame(IN P_
DBGLOG(P2P, TRACE, "RX Public Action Frame Token:%d.\n",
prPublicActionFrame->ucDialogToken);
if (prPublicActionFrame->ucCategory != CATEGORY_PUBLIC_ACTION)
- return rWlanStatus;
+ return WLAN_STATUS_SUCCESS;
switch (prPublicActionFrame->ucAction) {
case ACTION_PUBLIC_WIFI_DIRECT:
@@ -3060,12 +3057,11 @@ WLAN_STATUS p2pRxPublicActionFrame(IN P_
break;
}
- return rWlanStatus;
+ return WLAN_STATUS_SUCCESS;
} /* p2pRxPublicActionFrame */
WLAN_STATUS p2pRxActionFrame(IN P_ADAPTER_T prAdapter, IN P_SW_RFB_T prSwRfb)
{
- WLAN_STATUS rWlanStatus = WLAN_STATUS_SUCCESS;
P_P2P_ACTION_FRAME_T prP2pActionFrame = (P_P2P_ACTION_FRAME_T) NULL;
UINT_8 aucOui[3] = VENDOR_OUI_WFA_SPECIFIC;
@@ -3088,7 +3084,7 @@ WLAN_STATUS p2pRxActionFrame(IN P_ADAPTE
} while (FALSE);
- return rWlanStatus;
+ return WLAN_STATUS_SUCCESS;
} /* p2pRxActionFrame */
VOID
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:2056:9-26: Unneeded variable:
"fgIsReplyProbeRsp". Return "FALSE" on line 2077
drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:1301:13-24: Unneeded
variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 1373
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
p2p_func.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c
@@ -1298,7 +1298,6 @@ WLAN_STATUS
p2pFuncTxMgmtFrame(IN P_ADAPTER_T prAdapter,
IN P_P2P_MGMT_TX_REQ_INFO_T prMgmtTxReqInfo, IN P_MSDU_INFO_T prMgmtTxMsdu, IN
UINT_64 u8Cookie)
{
- WLAN_STATUS rWlanStatus = WLAN_STATUS_SUCCESS;
P_MSDU_INFO_T prTxMsduInfo = (P_MSDU_INFO_T) NULL;
P_WLAN_MAC_HEADER_T prWlanHdr = (P_WLAN_MAC_HEADER_T) NULL;
P_STA_RECORD_T prStaRec = (P_STA_RECORD_T) NULL;
@@ -1370,7 +1369,7 @@ p2pFuncTxMgmtFrame(IN P_ADAPTER_T prAdap
} while (FALSE);
- return rWlanStatus;
+ return WLAN_STATUS_SUCCESS;
} /* p2pFuncTxMgmtFrame */
VOID p2pFuncSetChannel(IN P_ADAPTER_T prAdapter, IN P_RF_CHANNEL_INFO_T prRfChannelInfo)
@@ -2053,7 +2052,6 @@ BOOLEAN p2pFuncParseCheckForP2PInfoElem(
/*----------------------------------------------------------------------------*/
BOOLEAN p2pFuncValidateProbeReq(IN P_ADAPTER_T prAdapter, IN P_SW_RFB_T prSwRfb, OUT
PUINT_32 pu4ControlFlags)
{
- BOOLEAN fgIsReplyProbeRsp = FALSE;
P_P2P_FSM_INFO_T prP2pFsmInfo = (P_P2P_FSM_INFO_T) NULL;
DEBUGFUNC("p2pFuncValidateProbeReq");
@@ -2074,7 +2072,7 @@ BOOLEAN p2pFuncValidateProbeReq(IN P_ADA
} while (FALSE);
- return fgIsReplyProbeRsp;
+ return FALSE;
} /* end of p2pFuncValidateProbeReq() */
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:1689:13-21: Unneeded
variable: "u4Status". Return "WLAN_STATUS_SUCCESS" on line 1775
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
wlan_lib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c
@@ -1686,7 +1686,6 @@ wlanAdapterStart(IN P_ADAPTER_T prAdapte
WLAN_STATUS wlanAdapterStop(IN P_ADAPTER_T prAdapter)
{
UINT_32 i, u4Value = 0;
- WLAN_STATUS u4Status = WLAN_STATUS_SUCCESS;
ASSERT(prAdapter);
@@ -1772,7 +1771,7 @@ WLAN_STATUS wlanAdapterStop(IN P_ADAPTER
nicRestoreSpiDefMode(prAdapter);
#endif
- return u4Status;
+ return WLAN_STATUS_SUCCESS;
} /* wlanAdapterStop */
#if 0
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_oid.c:5224:15-22: Unneeded
variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 5227
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_oid.c:5259:15-22: Unneeded
variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 5262
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
wlan_oid.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_oid.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_oid.c
@@ -5221,10 +5221,9 @@ wlanoidSetMcrWrite(IN P_ADAPTER_T prAdap
#if 1
/* low power test special command */
if (prMcrWrInfo->u4McrOffset == 0x11111110) {
- WLAN_STATUS rStatus = WLAN_STATUS_SUCCESS;
/* DbgPrint("Enter test mode\n"); */
prAdapter->fgTestMode = TRUE;
- return rStatus;
+ return WLAN_STATUS_SUCCESS;
}
if (prMcrWrInfo->u4McrOffset == 0x11111111) {
/* DbgPrint("nicpmSetAcpiPowerD3\n"); */
@@ -5256,10 +5255,9 @@ wlanoidSetMcrWrite(IN P_ADAPTER_T prAdap
#if 1
/* low power test special command */
if (prMcrWrInfo->u4McrOffset == 0x11111110) {
- WLAN_STATUS rStatus = WLAN_STATUS_SUCCESS;
/* DbgPrint("Enter test mode\n"); */
prAdapter->fgTestMode = TRUE;
- return rStatus;
+ return WLAN_STATUS_SUCCESS;
}
if (prMcrWrInfo->u4McrOffset == 0x11111111) {
/* DbgPrint("nicpmSetAcpiPowerD3\n"); */
10:19 p.m.
New subject: [PATCH] mt6625l: fix returnvar.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_p2p.c:1259:13-24: Unneeded
variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 1282
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
wlan_p2p.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_p2p.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_p2p.c
@@ -1256,7 +1256,6 @@ WLAN_STATUS
wlanoidGetSecCheckResponse(IN P_ADAPTER_T prAdapter,
IN PVOID pvQueryBuffer, IN UINT_32 u4QueryBufferLen, OUT PUINT_32 pu4QueryInfoLen)
{
- WLAN_STATUS rWlanStatus = WLAN_STATUS_SUCCESS;
/* P_WLAN_MAC_HEADER_T prWlanHdr = (P_WLAN_MAC_HEADER_T)NULL; */
P_GLUE_INFO_T prGlueInfo;
@@ -1279,7 +1278,7 @@ wlanoidGetSecCheckResponse(IN P_ADAPTER_
kalMemCopy((PUINT_8) (pvQueryBuffer + OFFSET_OF(IW_P2P_TRANSPORT_STRUCT, aucBuffer)),
prGlueInfo->prP2PInfo->aucSecCheckRsp, u4QueryBufferLen);
- return rWlanStatus;
+ return WLAN_STATUS_SUCCESS;
} /* end of wlanoidGetSecCheckResponse() */
#endif
10:19 p.m.
New subject: [PATCH] mt6625l: fix semicolon.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_pwr_mgt.c:650:2-3: Unneeded
semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
nic_pwr_mgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_pwr_mgt.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_pwr_mgt.c
@@ -647,7 +647,7 @@ BOOLEAN nicpmSetAcpiPowerD3(IN P_ADAPTER
i = 0;
while (i < CFG_IST_LOOP_COUNT && nicProcessIST(prAdapter) !=
WLAN_STATUS_NOT_INDICATING) {
i++;
- };
+ }
/* 5. Remove pending TX */
nicTxRelease(prAdapter);
10:19 p.m.
New subject: [PATCH] mt6625l: fix semicolon.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_tx.c:1955:2-3: Unneeded semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_tx.c:1129:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
nic_tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_tx.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/nic/nic_tx.c
@@ -1126,7 +1126,7 @@ VOID nicTxReturnMsduInfoProfiling(IN P_A
}
prMsduInfo = prNextMsduInfo;
- };
+ }
#if CFG_PRINT_RTP_PROFILE
/* 4 4. record the lifetime of current round last pkt */
@@ -1952,7 +1952,7 @@ VOID nicTxReturnMsduInfo(IN P_ADAPTER_T
QUEUE_INSERT_TAIL(&prTxCtrl->rFreeMsduInfoList, (P_QUE_ENTRY_T) prMsduInfo);
KAL_RELEASE_SPIN_LOCK(prAdapter, SPIN_LOCK_TX_MSDU_INFO_LIST);
prMsduInfo = prNextMsduInfo;
- };
+ }
}
10:19 p.m.
New subject: [PATCH] mt6625l: fix semicolon.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:1719:4-5: Unneeded
semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:3173:2-3: Unneeded
semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:2994:2-3: Unneeded
semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:2916:2-3: Unneeded
semicolon
drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c:2646:2-3: Unneeded
semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head: ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder
wlan_lib.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- a/drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/common/wlan_lib.c
@@ -1716,7 +1716,7 @@ WLAN_STATUS wlanAdapterStop(IN P_ADAPTER
i = 0;
while (i < CFG_IST_LOOP_COUNT && nicProcessIST(prAdapter) !=
WLAN_STATUS_NOT_INDICATING) {
i++;
- };
+ }
/* 3. Wait til RDY bit has been cleaerd */
i = 0;
@@ -2643,7 +2643,7 @@ WLAN_STATUS wlanSendNicPowerCtrlCmd(IN P
}
break;
- };
+ }
/* 4. Free CMD Info Packet. */
cmdBufFreeCmdInfo(prAdapter, prCmdInfo);
@@ -2913,7 +2913,7 @@ wlanImageSectionDownload(IN P_ADAPTER_T
}
break;
- };
+ }
#if CFG_ENABLE_FW_DOWNLOAD_ACK
/* 7. Wait for INIT_EVENT_ID_CMD_RESULT */
@@ -2991,7 +2991,7 @@ WLAN_STATUS wlanImageQueryStatus(IN P_AD
}
break;
- };
+ }
/* 6. Wait for INIT_EVENT_ID_PENDING_ERROR */
do {
@@ -3170,7 +3170,7 @@ WLAN_STATUS wlanConfigWifiFunc(IN P_ADAP
}
break;
- };
+ }
/* 6. Free CMD Info Packet. */
cmdBufFreeCmdInfo(prAdapter, prCmdInfo);
800
days inactive
800
days old
16 comments
1 participants
participants (1)
-
kernel test robot