Hi Tony,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20211011]
[cannot apply to robh/for-next linus/master ulf-hansson-mmc-mirror/next v5.15-rc5
v5.15-rc4 v5.15-rc3 v5.15-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Tony-Lindgren/More-SoCs-for-sdhc...
base: d3134eb5de8546a214c028fb7195e764b89da7d4
config: riscv-randconfig-r042-20211012 (attached as .config)
compiler: clang version 14.0.0 (
https://github.com/llvm/llvm-project
c3dcf39554dbea780d6cb7e12239451ba47a2668)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
#
https://github.com/0day-ci/linux/commit/66e8ed22a31746643373772ef2fca668c...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Tony-Lindgren/More-SoCs-for-sdhci-omap-to-deprecate-omap_hsmmc/20211012-183855
git checkout 66e8ed22a31746643373772ef2fca668ca7d1a8f
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=riscv SHELL=/bin/bash drivers/mmc/host/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/mmc/host/sdhci-omap.c:948:10: warning: implicit conversion from 'unsigned
long' to 'unsigned int' changes value from 18446744073709551615 to 4294967295
[-Wconstant-conversion]
return ~0UL;
~~~~~~ ^~~~
drivers/mmc/host/sdhci-omap.c:975:29: warning: result of comparison of constant
18446744073709551615 with expression of type 'unsigned int' is always false
[-Wtautological-constant-out-of-range-compare]
if (pbias != ~0UL && vqmmc == ~0UL)
~~~~~ ^ ~~~~
drivers/mmc/host/sdhci-omap.c:975:12: warning: result of comparison of constant
18446744073709551615 with expression of type 'unsigned int' is always true
[-Wtautological-constant-out-of-range-compare]
if (pbias != ~0UL && vqmmc == ~0UL)
~~~~~ ^ ~~~~
drivers/mmc/host/sdhci-omap.c:977:16: warning: result of comparison of constant
18446744073709551615 with expression of type 'unsigned int' is always false
[-Wtautological-constant-out-of-range-compare]
else if (caps == ~0UL)
~~~~ ^ ~~~~
drivers/mmc/host/sdhci-omap.c:984:12: warning: result of comparison of constant
18446744073709551615 with expression of type 'unsigned int' is always true
[-Wtautological-constant-out-of-range-compare]
if (pbias != ~0UL && (pbias & SDHCI_CAN_VDD_330) &&
~~~~~ ^ ~~~~
> drivers/mmc/host/sdhci-omap.c:1485:21: error: use of undeclared
identifier 'sdhci_omap_runtime_suspend'; did you mean
'__pm_runtime_suspend'?
SET_RUNTIME_PM_OPS(sdhci_omap_runtime_suspend,
^~~~~~~~~~~~~~~~~~~~~~~~~~
__pm_runtime_suspend
include/linux/pm.h:341:21: note: expanded from macro 'SET_RUNTIME_PM_OPS'
.runtime_suspend = suspend_fn, \
^
include/linux/pm_runtime.h:39:12: note: '__pm_runtime_suspend' declared here
extern int __pm_runtime_suspend(struct device *dev, int rpmflags);
^
> drivers/mmc/host/sdhci-omap.c:1486:7: error: use of undeclared
identifier 'sdhci_omap_runtime_resume'; did you mean
'__pm_runtime_resume'?
sdhci_omap_runtime_resume, NULL)
^~~~~~~~~~~~~~~~~~~~~~~~~
__pm_runtime_resume
include/linux/pm.h:342:20: note: expanded from macro 'SET_RUNTIME_PM_OPS'
.runtime_resume = resume_fn, \
^
include/linux/pm_runtime.h:40:12: note: '__pm_runtime_resume' declared here
extern int __pm_runtime_resume(struct device *dev, int rpmflags);
^
> drivers/mmc/host/sdhci-omap.c:1485:21: error: incompatible
function pointer types initializing 'int (*)(struct device *)' with an expression
of type 'int (struct device *, int)'
[-Werror,-Wincompatible-function-pointer-types]
SET_RUNTIME_PM_OPS(sdhci_omap_runtime_suspend,
^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/pm.h:341:21: note: expanded from macro 'SET_RUNTIME_PM_OPS'
.runtime_suspend = suspend_fn, \
^~~~~~~~~~
drivers/mmc/host/sdhci-omap.c:1486:7: error: incompatible function pointer types
initializing 'int (*)(struct device *)' with an expression of type 'int
(struct device *, int)' [-Werror,-Wincompatible-function-pointer-types]
sdhci_omap_runtime_resume, NULL)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/pm.h:342:20: note: expanded from macro 'SET_RUNTIME_PM_OPS'
.runtime_resume = resume_fn, \
^~~~~~~~~
5 warnings and 4 errors generated.
vim +1485 drivers/mmc/host/sdhci-omap.c
1483
1484 static const struct dev_pm_ops sdhci_omap_dev_pm_ops = {
1485 SET_RUNTIME_PM_OPS(sdhci_omap_runtime_suspend,
1486 sdhci_omap_runtime_resume, NULL)
1487 SET_SYSTEM_SLEEP_PM_OPS(sdhci_omap_suspend, sdhci_omap_resume)
1488 };
1489
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org