Hi Muchun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hnaz-linux-mm/master]
[also build test ERROR on cgroup/for-next v5.9-rc4 next-20200911]
[cannot apply to mmotm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Muchun-Song/mm-memcontrol-Add-th...
base:
https://github.com/hnaz/linux-mm master
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/mm.h:672,
from arch/powerpc/include/asm/io.h:29,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/powerpc/include/asm/hardirq.h:6,
from include/linux/hardirq.h:10,
from include/linux/interrupt.h:11,
from include/linux/kernel_stat.h:9,
from include/linux/cgroup.h:26,
from include/linux/memcontrol.h:13,
from mm/memcontrol.c:26:
mm/memcontrol.c: In function 'memory_numa_stat_format':
> include/linux/huge_mm.h:120:24: error: initializer element is not
constant
120 | #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT)
| ^
mm/memcontrol.c:6422:17: note: in expansion of macro 'HPAGE_PMD_SIZE'
6422 | { "anon_thp", HPAGE_PMD_SIZE, NR_ANON_THPS },
| ^~~~~~~~~~~~~~
include/linux/huge_mm.h:120:24: note: (near initialization for
'stats[7].ratio')
120 | #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT)
| ^
mm/memcontrol.c:6422:17: note: in expansion of macro 'HPAGE_PMD_SIZE'
6422 | { "anon_thp", HPAGE_PMD_SIZE, NR_ANON_THPS },
| ^~~~~~~~~~~~~~
#
https://github.com/0day-ci/linux/commit/1fadd691a289cdae3e267de7cb5e9444f...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Muchun-Song/mm-memcontrol-Add-the-missing-numa_stat-interface-for-cgroup-v2/20200912-234140
git checkout 1fadd691a289cdae3e267de7cb5e9444f8b7705d
vim +120 include/linux/huge_mm.h
d8c37c480678ebe Naoya Horiguchi 2012-03-21 117
71e3aac0724ffe8 Andrea Arcangeli 2011-01-13 118 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
fde52796d487b67 Aneesh Kumar K.V 2013-06-05 119 #define HPAGE_PMD_SHIFT PMD_SHIFT
fde52796d487b67 Aneesh Kumar K.V 2013-06-05 @120 #define HPAGE_PMD_SIZE ((1UL) <<
HPAGE_PMD_SHIFT)
fde52796d487b67 Aneesh Kumar K.V 2013-06-05 121 #define HPAGE_PMD_MASK (~(HPAGE_PMD_SIZE
- 1))
71e3aac0724ffe8 Andrea Arcangeli 2011-01-13 122
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org