Hi Srikar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on next-20200317]
[cannot apply to linus/master asm-generic/master mpe/next v5.6-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Srikar-Dronamraju/Fix-kmalloc_no...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/topology.h:36,
from include/linux/gfp.h:9,
from include/linux/slab.h:15,
from include/linux/crypto.h:19,
from include/crypto/hash.h:11,
from include/linux/uio.h:10,
from include/linux/socket.h:8,
from include/linux/compat.h:15,
from arch/powerpc/kernel/asm-offsets.c:14:
arch/powerpc/include/asm/topology.h: In function 'update_default_numa_mem':
> arch/powerpc/include/asm/topology.h:77:4: error: implicit
declaration of function 'reset_numa_mem' [-Werror=implicit-function-declaration]
77 | reset_numa_mem(node);
| ^~~~~~~~~~~~~~
arch/powerpc/include/asm/topology.h:79:1: warning: no return statement in function
returning non-void [-Wreturn-type]
79 | }
| ^
In file included from include/linux/gfp.h:9,
from include/linux/slab.h:15,
from include/linux/crypto.h:19,
from include/crypto/hash.h:11,
from include/linux/uio.h:10,
from include/linux/socket.h:8,
from include/linux/compat.h:15,
from arch/powerpc/kernel/asm-offsets.c:14:
include/linux/topology.h: At top level:
> include/linux/topology.h:151:20: warning: conflicting types for
'reset_numa_mem'
151 | static inline void reset_numa_mem(int node)
| ^~~~~~~~~~~~~~
> include/linux/topology.h:151:20: error: static declaration of
'reset_numa_mem' follows non-static declaration
In file included from
include/linux/topology.h:36,
from include/linux/gfp.h:9,
from include/linux/slab.h:15,
from include/linux/crypto.h:19,
from include/crypto/hash.h:11,
from include/linux/uio.h:10,
from include/linux/socket.h:8,
from include/linux/compat.h:15,
from arch/powerpc/kernel/asm-offsets.c:14:
arch/powerpc/include/asm/topology.h:77:4: note: previous implicit declaration of
'reset_numa_mem' was here
77 | reset_numa_mem(node);
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:101: arch/powerpc/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1112: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:179: sub-make] Error 2
256 real 58 user 115 sys 67.93% cpu make prepare
vim +/reset_numa_mem +77 arch/powerpc/include/asm/topology.h
65
66 static inline int update_default_numa_mem(void)
67 {
68 unsigned int node;
69
70 for_each_node(node) {
71 /*
72 * For all possible but not yet online nodes, ensure their
73 * node_numa_mem is set correctly so that kmalloc_node works
74 * for such nodes.
75 */
76 if (!node_online(node))
77 reset_numa_mem(node);
78 }
79 }
80 #else
81
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org