I guess this needs to be a no-op if the media controller API isn't configured. On 16/12/2021 11:10, kernel test robot wrote: > Hi Daniel, > > I love your patch! Yet something to improve: > > [auto build test ERROR on media-tree/master] > [also build test ERROR on v5.16-rc5 next-20211215] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Daniel-Scally/Introduce-ancillar... > base: git://linuxtv.org/media_tree.git master > config: x86_64-randconfig-r015-20211216 (https://download.01.org/0day-ci/archive/20211216/202112161906.gHHRLukN-lk...) > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dd245bab9fbb364faa1581e4f92ba3119a872fba) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/7e7fcd65e8144f3ffa337760c26fb786f... > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Daniel-Scally/Introduce-ancillary-links/20211214-073020 > git checkout 7e7fcd65e8144f3ffa337760c26fb786f4028466 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/media/v4l2-core/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp(a)intel.com&gt; > > All errors (new ones prefixed by >>): > >>> drivers/media/v4l2-core/v4l2-async.c:284:10: error: no member named 'entity' in 'struct v4l2_subdev' > if (sd->entity.function != MEDIA_ENT_F_LENS && > ~~ ^ > drivers/media/v4l2-core/v4l2-async.c:285:10: error: no member named 'entity' in 'struct v4l2_subdev' > sd->entity.function != MEDIA_ENT_F_FLASH) > ~~ ^ > drivers/media/v4l2-core/v4l2-async.c:288:52: error: no member named 'entity' in 'struct v4l2_subdev' > link = media_create_ancillary_link(&notifier->sd->entity, &sd->entity, > ~~~~~~~~~~~~ ^ > drivers/media/v4l2-core/v4l2-async.c:288:65: error: no member named 'entity' in 'struct v4l2_subdev' > link = media_create_ancillary_link(&notifier->sd->entity, &sd->entity, > ~~ ^ > drivers/media/v4l2-core/v4l2-async.c:309:24: error: no member named 'entity' in 'struct v4l2_subdev' > switch (notifier->sd->entity.function) { > ~~~~~~~~~~~~ ^ > 5 errors generated. > > > vim +284 drivers/media/v4l2-core/v4l2-async.c > > 277 > 278 static int > 279 __v4l2_async_create_ancillary_link(struct v4l2_async_notifier *notifier, > 280 struct v4l2_subdev *sd) > 281 { > 282 struct media_link *link; > 283 > > 284 if (sd->entity.function != MEDIA_ENT_F_LENS && > 285 sd->entity.function != MEDIA_ENT_F_FLASH) > 286 return -EINVAL; > 287 > 288 link = media_create_ancillary_link(&notifier->sd->entity, &sd->entity, > 289 MEDIA_LNK_FL_ENABLED | > 290 MEDIA_LNK_FL_IMMUTABLE); > 291 > 292 return IS_ERR(link) ? PTR_ERR(link) : 0; > 293 } > 294 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org