Hi Thomas, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master next-20200807] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm/drm-next v5.8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-mgag200-Su... base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-randconfig-m001-20200807 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; smatch warnings: drivers/gpu/drm/mgag200/mgag200_drv.c:91 mgag200_regs_init() error: uninitialized symbol 'option'. vim +/option +91 drivers/gpu/drm/mgag200/mgag200_drv.c 59 60 static int mgag200_regs_init(struct mga_device *mdev) 61 { 62 struct drm_device *dev = &mdev->base; 63 u32 option, option2; 64 65 switch (mdev->type) { 66 case G200_SE_A: 67 case G200_SE_B: 68 if (mgag200_has_sgram(mdev)) 69 option |= PCI_MGA_OPTION_HARDPWMSK; 70 option2 = 0x00008000; 71 break; 72 case G200_WB: 73 case G200_EW3: 74 option = 0x41049120; 75 option2 = 0x0000b000; 76 break; 77 case G200_EV: 78 option = 0x00000120; 79 option2 = 0x0000b000; 80 break; 81 case G200_EH: 82 case G200_EH3: 83 option = 0x00000120; 84 option2 = 0x0000b000; 85 break; 86 default: 87 option = 0; 88 option2 = 0; 89 } 90 92 pci_write_config_dword(dev->pdev, PCI_MGA_OPTION, option); 93 if (option2) 94 pci_write_config_dword(dev->pdev, PCI_MGA_OPTION2, option2); 95 96 /* BAR 1 contains registers */ 97 mdev->rmmio_base = pci_resource_start(dev->pdev, 1); 98 mdev->rmmio_size = pci_resource_len(dev->pdev, 1); 99 100 if (!devm_request_mem_region(dev->dev, mdev->rmmio_base, 101 mdev->rmmio_size, "mgadrmfb_mmio")) { 102 drm_err(dev, "can't reserve mmio registers\n"); 103 return -ENOMEM; 104 } 105 106 mdev->rmmio = pcim_iomap(dev->pdev, 1, 0); 107 if (mdev->rmmio == NULL) 108 return -ENOMEM; 109 110 return 0; 111 } 112 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org