Hi Thomas, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc3] [cannot apply to next-20201112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Build-fixe... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f8394f232b1eab649ce2df5c5f15b0e528c92091 config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1e81f225d3ffc9e951faab8deb96ef620... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Thomas-Zimmermann/drm-Build-fixes-for-msm-and-mediatek/20201109-183736 git checkout 1e81f225d3ffc9e951faab8deb96ef6209db7742 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from drivers/gpu/drm/mediatek/mtk_drm_crtc.c:23: 48 | int mtk_drm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map); | ^~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.h:49:66: warning: 'struct dma_buf_map' declared inside parameter list will not be visible outside of this definition or declaration 49 | void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map); | ^~~~~~~~~~~ -- In file included from drivers/gpu/drm/mediatek/mtk_drm_drv.c:32: 48 | int mtk_drm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map); | ^~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.h:49:66: warning: 'struct dma_buf_map' declared inside parameter list will not be visible outside of this definition or declaration 49 | void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map); | ^~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_drv.c:316:24: warning: no previous prototype for 'mtk_drm_gem_prime_import' [-Wmissing-prototypes] 316 | struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_drv.c:337:20: error: initialization of 'void * (*)(struct drm_gem_object *)' from incompatible pointer type 'int (*)(struct drm_gem_object *, struct dma_buf_map *)' [-Werror=incompatible-pointer-types] 337 | .gem_prime_vmap = mtk_drm_gem_prime_vmap, | ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_drv.c:337:20: note: (near initialization for 'mtk_drm_driver.gem_prime_vmap') drivers/gpu/drm/mediatek/mtk_drm_drv.c:338:22: error: initialization of 'void (*)(struct drm_gem_object *, void *)' from incompatible pointer type 'void (*)(struct drm_gem_object *, struct dma_buf_map *)' [-Werror=incompatible-pointer-types] 338 | .gem_prime_vunmap = mtk_drm_gem_prime_vunmap, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_drv.c:338:22: note: (near initialization for 'mtk_drm_driver.gem_prime_vunmap') cc1: some warnings being treated as errors -- In file included from drivers/gpu/drm/mediatek/mtk_drm_gem.c:14: 48 | int mtk_drm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map); | ^~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.h:49:66: warning: 'struct dma_buf_map' declared inside parameter list will not be visible outside of this definition or declaration 49 | void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map); | ^~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.c:232:63: warning: 'struct dma_buf_map' declared inside parameter list will not be visible outside of this definition or declaration 232 | int mtk_drm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map) | ^~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.c:232:5: error: conflicting types for 'mtk_drm_gem_prime_vmap' 232 | int mtk_drm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map) | ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/mediatek/mtk_drm_gem.c:14: drivers/gpu/drm/mediatek/mtk_drm_gem.h:48:5: note: previous declaration of 'mtk_drm_gem_prime_vmap' was here 48 | int mtk_drm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map); | ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.c: In function 'mtk_drm_gem_prime_vmap': drivers/gpu/drm/mediatek/mtk_drm_gem.c:259:2: error: implicit declaration of function 'dma_buf_map_set_vaddr' [-Werror=implicit-function-declaration] 259 | dma_buf_map_set_vaddr(map, mtk_gem->kvaddr); | ^~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.c: At top level: drivers/gpu/drm/mediatek/mtk_drm_gem.c:264:66: warning: 'struct dma_buf_map' declared inside parameter list will not be visible outside of this definition or declaration 264 | void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map) | ^~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.c:264:6: error: conflicting types for 'mtk_drm_gem_prime_vunmap' 264 | void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map) | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/mediatek/mtk_drm_gem.c:14: drivers/gpu/drm/mediatek/mtk_drm_gem.h:49:6: note: previous declaration of 'mtk_drm_gem_prime_vunmap' was here 49 | void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_drm_gem.c: In function 'mtk_drm_gem_prime_vunmap': drivers/gpu/drm/mediatek/mtk_drm_gem.c:267:19: error: dereferencing pointer to incomplete type 'struct dma_buf_map' 267 | void *vaddr = map->vaddr; | ^~ cc1: some warnings being treated as errors vim +48 drivers/gpu/drm/mediatek/mtk_drm_gem.h 36 37 void mtk_drm_gem_free_object(struct drm_gem_object *gem); 38 struct mtk_drm_gem_obj *mtk_drm_gem_create(struct drm_device *dev, size_t size, 39 bool alloc_kmap); 40 int mtk_drm_gem_dumb_create(struct drm_file *file_priv, struct drm_device *dev, 41 struct drm_mode_create_dumb *args); 42 int mtk_drm_gem_mmap(struct file *filp, struct vm_area_struct *vma); 43 int mtk_drm_gem_mmap_buf(struct drm_gem_object *obj, 44 struct vm_area_struct *vma); 45 struct sg_table *mtk_gem_prime_get_sg_table(struct drm_gem_object *obj); 46 struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev, 47 struct dma_buf_attachment *attach, struct sg_table *sg); 49 void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map); 50 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org