[linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer
3:01 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e098d7762d602be640c53565ceca342f81e55ad2
commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703] rtw88: set power trim
according to efuse PG values
config: i386-randconfig-a002-20200514 (attached as .config)
compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
reproduce:
git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function 'rtw8822c_power_trim':
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
missing braces around initializer [-Wmissing-braces]
s8 bb_gain[2][8] = {0};
^
drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near initialization for
'bb_gain[0]') [-Wmissing-braces]
vim +1039 drivers/net/wireless/realtek/rtw88/rtw8822c.c
1035
1036 static void rtw8822c_power_trim(struct rtw_dev *rtwdev)
1037 {
1038 u8 pg_pwr = 0xff, i, path, idx;
1039 s8 bb_gain[2][8] = {0};
1040 u16 rf_efuse_2g[3] =
{PPG_2GL_TXAB, PPG_2GM_TXAB, PPG_2GH_TXAB};
1041 u16 rf_efuse_5g[2][5] = {{PPG_5GL1_TXA, PPG_5GL2_TXA, PPG_5GM1_TXA,
1042 PPG_5GM2_TXA, PPG_5GH1_TXA},
1043 {PPG_5GL1_TXB, PPG_5GL2_TXB, PPG_5GM1_TXB,
1044 PPG_5GM2_TXB, PPG_5GH1_TXB} };
1045 bool set = false;
1046
1047 for (i = 0; i < ARRAY_SIZE(rf_efuse_2g); i++) {
1048 rtw_read8_physical_efuse(rtwdev, rf_efuse_2g[i], &pg_pwr);
1049 if (pg_pwr == EFUSE_READ_FAIL)
1050 continue;
1051 set = true;
1052 bb_gain[RF_PATH_A][i] = FIELD_GET(PPG_2G_A_MASK, pg_pwr);
1053 bb_gain[RF_PATH_B][i] = FIELD_GET(PPG_2G_B_MASK, pg_pwr);
1054 }
1055
1056 for (i = 0; i < ARRAY_SIZE(rf_efuse_5g[0]); i++) {
1057 for (path = 0; path < rtwdev->hal.rf_path_num; path++) {
1058 rtw_read8_physical_efuse(rtwdev, rf_efuse_5g[path][i],
1059 &pg_pwr);
1060 if (pg_pwr == EFUSE_READ_FAIL)
1061 continue;
1062 set = true;
1063 idx = i + ARRAY_SIZE(rf_efuse_2g);
1064 bb_gain[path][idx] = FIELD_GET(PPG_5G_MASK, pg_pwr);
1065 }
1066 }
1067 if (set)
1068 rtw8822c_set_power_trim(rtwdev, bb_gain);
1069
1070 rtw_write32_mask(rtwdev, REG_DIS_DPD, DIS_DPD_MASK, DIS_DPD_RATEALL);
1071 }
1072
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10:24 p.m.
+ linux-wireless
kbuild test robot <lkp(a)intel.com> writes:
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e098d7762d602be640c53565ceca342f81e55ad2
commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703] rtw88:
set power trim according to efuse PG values
config: i386-randconfig-a002-20200514 (attached as .config)
compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
reproduce:
git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
'rtw8822c_power_trim':
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> missing braces around initializer [-Wmissing-braces]
s8 bb_gain[2][8] = {0};
^
drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
initialization for 'bb_gain[0]') [-Wmissing-braces]
Tony, please check this and fix it. If it's a false warning please let
us know.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa...
7:16 p.m.
Kalle Valo <kvalo(a)codeaurora.org> writes:
+ linux-wireless
kbuild test robot <lkp(a)intel.com> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
> head: e098d7762d602be640c53565ceca342f81e55ad2
> commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
rtw88:
> set power trim according to efuse PG values
> config: i386-randconfig-a002-20200514 (attached as .config)
> compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> reproduce:
> git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> # save the attached .config to linux build tree
> make ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp(a)intel.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
'rtw8822c_power_trim':
>>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
>> missing braces around initializer [-Wmissing-braces]
> s8 bb_gain[2][8] = {0};
> ^
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> initialization for 'bb_gain[0]') [-Wmissing-braces]
Tony, please check this and fix it. If it's a false warning please let
us know.
I tried to re-pro by:
git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
# save the attached .config to linux build tree
make ARCH=i386
But cannot see it. And I checked the code, looks fine to me.
It seems to be a false warning.
Yen-Hsuan
10:30 p.m.
Kalle Valo <kvalo(a)codeaurora.org> writes:
>
> + linux-wireless
>
> kbuild test robot <lkp(a)intel.com> writes:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> master
> > head: e098d7762d602be640c53565ceca342f81e55ad2
> > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> rtw88:
> > set power trim according to efuse PG values
> > config: i386-randconfig-a002-20200514 (attached as .config)
> > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > reproduce:
> > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > # save the attached .config to linux build tree
> > make ARCH=i386
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp(a)intel.com>
> >
> > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> >
> > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> 'rtw8822c_power_trim':
> >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> >> missing braces around initializer [-Wmissing-braces]
> > s8 bb_gain[2][8] = {0};
> > ^
> > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> > initialization for 'bb_gain[0]') [-Wmissing-braces]
>
> Tony, please check this and fix it. If it's a false warning please let
> us know.
>
I tried to re-pro by:
git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
# save the attached .config to linux build tree
make ARCH=i386
But cannot see it. And I checked the code, looks fine to me.
It seems to be a false warning.
Hi, what's your compiler? we can reproduce by gcc-4.9 and follow above steps.
From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 , the warning should be only on
old compilers.
If made below change, the warning will disappear.
@@ -1036,7 +1036,7 @@ static void rtw8822c_set_power_trim(struct rtw_dev *rtwdev, s8
bb_gain[2][8])
static void rtw8822c_power_trim(struct rtw_dev *rtwdev)
{
u8 pg_pwr = 0xff, i, path, idx;
- s8 bb_gain[2][8] = {0};
+ s8 bb_gain[2][8] = {};
u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB, PPG_2GH_TXAB};
Similar fix could be seen, as an example, on https://lkml.org/lkml/2017/9/12/159
>
> Yen-Hsuan
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org To unsubscribe send an email to
> kbuild-all-leave(a)lists.01.org
1:49 p.m.
> Kalle Valo <kvalo(a)codeaurora.org> writes:
>
> >
> > + linux-wireless
> >
> > kbuild test robot <lkp(a)intel.com> writes:
> >
> > > tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > master
> > > head: e098d7762d602be640c53565ceca342f81e55ad2
> > > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> > rtw88:
> > > set power trim according to efuse PG values
> > > config: i386-randconfig-a002-20200514 (attached as .config)
> > > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > > reproduce:
> > > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > > # save the attached .config to linux build tree
> > > make ARCH=i386
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kbuild test robot <lkp(a)intel.com>
> > >
> > > All warnings (new ones prefixed by >>, old ones prefixed by
<<):
> > >
> > > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> > 'rtw8822c_power_trim':
> > >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > >> missing braces around initializer [-Wmissing-braces]
> > > s8 bb_gain[2][8] = {0};
> > > ^
> > > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> > > initialization for 'bb_gain[0]') [-Wmissing-braces]
> >
> > Tony, please check this and fix it. If it's a false warning please let
> > us know.
> >
>
> I tried to re-pro by:
> git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> # save the attached .config to linux build tree
> make ARCH=i386
>
> But cannot see it. And I checked the code, looks fine to me.
> It seems to be a false warning.
Hi, what's your compiler? we can reproduce by gcc-4.9 and follow above steps.
From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 , the warning
should be only on old compilers.
If made below change, the warning will disappear.
@@ -1036,7 +1036,7 @@ static void rtw8822c_set_power_trim(struct
rtw_dev *rtwdev, s8 bb_gain[2][8])
static void rtw8822c_power_trim(struct rtw_dev *rtwdev)
{
u8 pg_pwr = 0xff, i, path, idx;
- s8 bb_gain[2][8] = {0};
+ s8 bb_gain[2][8] = {};
u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB,
PPG_2GH_TXAB};
Similar fix could be seen, as an example, on
https://lkml.org/lkml/2017/9/12/159
Oh, my gcc version is 5.5.0 20171010.
OK, then I know it should be fixed for old gcc versions.
Thanks!
Yen-Hsuan
9:31 p.m.
From: Tony Chuang <yhchuang(a)realtek.com>
>
> > Kalle Valo <kvalo(a)codeaurora.org> writes:
> >
> > >
> > > + linux-wireless
> > >
> > > kbuild test robot <lkp(a)intel.com> writes:
> > >
> > > > tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > > master
> > > > head: e098d7762d602be640c53565ceca342f81e55ad2
> > > > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> > > rtw88:
> > > > set power trim according to efuse PG values
> > > > config: i386-randconfig-a002-20200514 (attached as .config)
> > > > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > > > reproduce:
> > > > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > > > # save the attached .config to linux build tree
> > > > make ARCH=i386
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kbuild test robot <lkp(a)intel.com>
> > > >
> > > > All warnings (new ones prefixed by >>, old ones prefixed by
<<):
> > > >
> > > > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> > > 'rtw8822c_power_trim':
> > > >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2:
warning:
> > > >> missing braces around initializer [-Wmissing-braces]
> > > > s8 bb_gain[2][8] = {0};
> > > > ^
> > > > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > > > (near initialization for 'bb_gain[0]') [-Wmissing-braces]
> > >
> > > Tony, please check this and fix it. If it's a false warning please
> > > let us know.
> > >
> >
> > I tried to re-pro by:
> > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > # save the attached .config to linux build tree
> > make ARCH=i386
> >
> > But cannot see it. And I checked the code, looks fine to me.
> > It seems to be a false warning.
>
> Hi, what's your compiler? we can reproduce by gcc-4.9 and follow above steps.
>
> From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 , the warning
> should be only on old compilers.
> If made below change, the warning will disappear.
> @@ -1036,7 +1036,7 @@ static void rtw8822c_set_power_trim(struct
> rtw_dev *rtwdev, s8 bb_gain[2][8]) static void
> rtw8822c_power_trim(struct rtw_dev *rtwdev) {
> u8 pg_pwr = 0xff, i, path, idx;
> - s8 bb_gain[2][8] = {0};
> + s8 bb_gain[2][8] = {};
> u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB,
> PPG_2GH_TXAB};
>
> Similar fix could be seen, as an example, on
> https://lkml.org/lkml/2017/9/12/159
>
Oh, my gcc version is 5.5.0 20171010.
OK, then I know it should be fixed for old gcc versions.
Thanks!
Thank you
>
> Yen-Hsuan
850
days inactive
859
days old
5 comments
4 participants
participants (4)
-
Kalle Valo -
kbuild test robot -
Sang, Oliver -
Tony Chuang