Hi Christoph, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v5.14-rc1 next-20210712] [cannot apply to mkp-scsi/for-next scsi/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/bsg-remove-sup... base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: powerpc64-randconfig-r005-20210712 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7cec3a06b11a61835f2fad5d32a67536a... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christoph-Hellwig/bsg-remove-support-for-SCSI_IOCTL_SEND_COMMAND/20210712-144839 git checkout 7cec3a06b11a61835f2fad5d32a67536aea04a7b # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): block/bsg.c: In function 'bsg_sg_io': 64 | if (!q->bsg_dev.class_dev) | ^~ block/bsg.c:69:9: error: 'struct request_queue' has no member named 'bsg_dev' 69 | ret = q->bsg_dev.ops->check_proto(&hdr); | ^~ block/bsg.c:78:9: error: 'struct request_queue' has no member named 'bsg_dev' 78 | ret = q->bsg_dev.ops->fill_hdr(rq, &hdr, mode); | ^~ block/bsg.c:106:13: error: 'struct request_queue' has no member named 'bsg_dev' 106 | ret = rq->q->bsg_dev.ops->complete_rq(rq, &hdr); | ^~ block/bsg.c:110:7: error: 'struct request_queue' has no member named 'bsg_dev' 110 | rq->q->bsg_dev.ops->free_rq(rq); | ^~ block/bsg.c: In function 'bsg_add_device': block/bsg.c:178:31: error: 'struct request_queue' has no member named 'bsg_dev' 178 | strncpy(bd->name, dev_name(rq->bsg_dev.class_dev), sizeof(bd->name) - 1); | ^~ block/bsg.c: In function 'bsg_get_device': 218 | bd = __bsg_get_device(iminor(inode), bcd->queue); | ^~ block/bsg.c: At top level: 333 | void bsg_unregister_queue(struct request_queue *q) | ^~~~~~~~~~~~~~~~~~~~ In file included from include/linux/blkdev.h:21, from block/bsg.c:8: include/linux/bsg.h:30:20: note: previous definition of 'bsg_unregister_queue' was here 30 | static inline void bsg_unregister_queue(struct request_queue *q) | ^~~~~~~~~~~~~~~~~~~~ block/bsg.c: In function 'bsg_unregister_queue': block/bsg.c:335:35: error: 'struct request_queue' has no member named 'bsg_dev' 335 | struct bsg_class_device *bcd = &q->bsg_dev; | ^~ block/bsg.c:337:10: error: dereferencing pointer to incomplete type 'struct bsg_class_device' 337 | if (!bcd->class_dev) | ^~ block/bsg.c: At top level: 351 | const char *name, const struct bsg_ops *ops) | ^~~~~~~ 350 | int bsg_register_queue(struct request_queue *q, struct device *parent, | ^~~~~~~~~~~~~~~~~~ block/bsg.c: In function 'bsg_register_queue': block/bsg.c:364:10: error: 'struct request_queue' has no member named 'bsg_dev' 364 | bcd = &q->bsg_dev; | ^~ block/bsg.c:365:24: error: dereferencing pointer to incomplete type 'struct bsg_class_device' 365 | memset(bcd, 0, sizeof(*bcd)); | ^~~~ vim +64 block/bsg.c 17cb960f29c29e Christoph Hellwig 2018-03-13 53 ccf3209f0044e4 Christoph Hellwig 2018-11-09 54 static int bsg_sg_io(struct request_queue *q, fmode_t mode, void __user *uarg) 3d6392cfbd7dc1 Jens Axboe 2007-07-09 55 { 972248e9111ee6 Christoph Hellwig 2019-01-29 56 struct request *rq; 972248e9111ee6 Christoph Hellwig 2019-01-29 57 struct bio *bio; ccf3209f0044e4 Christoph Hellwig 2018-11-09 58 struct sg_io_v4 hdr; aebf526b53aea1 Christoph Hellwig 2017-01-31 59 int ret; c7a841f3aca469 James Smart 2010-11-14 60 ccf3209f0044e4 Christoph Hellwig 2018-11-09 61 if (copy_from_user(&hdr, uarg, sizeof(hdr))) ccf3209f0044e4 Christoph Hellwig 2018-11-09 62 return -EFAULT; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 63 ccf3209f0044e4 Christoph Hellwig 2018-11-09 @64 if (!q->bsg_dev.class_dev) ccf3209f0044e4 Christoph Hellwig 2018-11-09 65 return -ENXIO; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 66 ccf3209f0044e4 Christoph Hellwig 2018-11-09 67 if (hdr.guard != 'Q') ccf3209f0044e4 Christoph Hellwig 2018-11-09 68 return -EINVAL; ccf3209f0044e4 Christoph Hellwig 2018-11-09 69 ret = q->bsg_dev.ops->check_proto(&hdr); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 70 if (ret) ccf3209f0044e4 Christoph Hellwig 2018-11-09 71 return ret; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 72 ccf3209f0044e4 Christoph Hellwig 2018-11-09 73 rq = blk_get_request(q, hdr.dout_xfer_len ? da6269da4cfe29 Christoph Hellwig 2021-06-24 74 REQ_OP_DRV_OUT : REQ_OP_DRV_IN, 0); a492f075450f3b Joe Lawrence 2014-08-28 75 if (IS_ERR(rq)) ccf3209f0044e4 Christoph Hellwig 2018-11-09 76 return PTR_ERR(rq); f27b087b81b705 Jens Axboe 2014-06-06 77 ccf3209f0044e4 Christoph Hellwig 2018-11-09 78 ret = q->bsg_dev.ops->fill_hdr(rq, &hdr, mode); 0f7b4bc6bb1e57 Pan Bian 2021-01-19 79 if (ret) { 0f7b4bc6bb1e57 Pan Bian 2021-01-19 80 blk_put_request(rq); 972248e9111ee6 Christoph Hellwig 2019-01-29 81 return ret; 0f7b4bc6bb1e57 Pan Bian 2021-01-19 82 } 2c9ecdf40af055 FUJITA Tomonori 2007-07-16 83 ccf3209f0044e4 Christoph Hellwig 2018-11-09 84 rq->timeout = msecs_to_jiffies(hdr.timeout); 17cb960f29c29e Christoph Hellwig 2018-03-13 85 if (!rq->timeout) 17cb960f29c29e Christoph Hellwig 2018-03-13 86 rq->timeout = q->sg_timeout; 17cb960f29c29e Christoph Hellwig 2018-03-13 87 if (!rq->timeout) 17cb960f29c29e Christoph Hellwig 2018-03-13 88 rq->timeout = BLK_DEFAULT_SG_TIMEOUT; 17cb960f29c29e Christoph Hellwig 2018-03-13 89 if (rq->timeout < BLK_MIN_SG_TIMEOUT) 17cb960f29c29e Christoph Hellwig 2018-03-13 90 rq->timeout = BLK_MIN_SG_TIMEOUT; 17cb960f29c29e Christoph Hellwig 2018-03-13 91 ccf3209f0044e4 Christoph Hellwig 2018-11-09 92 if (hdr.dout_xfer_len) { ccf3209f0044e4 Christoph Hellwig 2018-11-09 93 ret = blk_rq_map_user(q, rq, NULL, uptr64(hdr.dout_xferp), ccf3209f0044e4 Christoph Hellwig 2018-11-09 94 hdr.dout_xfer_len, GFP_KERNEL); ccf3209f0044e4 Christoph Hellwig 2018-11-09 95 } else if (hdr.din_xfer_len) { ccf3209f0044e4 Christoph Hellwig 2018-11-09 96 ret = blk_rq_map_user(q, rq, NULL, uptr64(hdr.din_xferp), ccf3209f0044e4 Christoph Hellwig 2018-11-09 97 hdr.din_xfer_len, GFP_KERNEL); 70e36eceaf897d FUJITA Tomonori 2006-12-20 98 } c1c201200a359c Boaz Harrosh 2009-02-03 99 17cb960f29c29e Christoph Hellwig 2018-03-13 100 if (ret) 972248e9111ee6 Christoph Hellwig 2019-01-29 101 goto out_free_rq; 17cb960f29c29e Christoph Hellwig 2018-03-13 102 ccf3209f0044e4 Christoph Hellwig 2018-11-09 103 bio = rq->bio; 70e36eceaf897d FUJITA Tomonori 2006-12-20 104 684da7628d93bb Guoqing Jiang 2021-01-25 105 blk_execute_rq(NULL, rq, !(hdr.flags & BSG_FLAG_Q_AT_TAIL)); ccf3209f0044e4 Christoph Hellwig 2018-11-09 106 ret = rq->q->bsg_dev.ops->complete_rq(rq, &hdr); 70e36eceaf897d FUJITA Tomonori 2006-12-20 107 blk_rq_unmap_user(bio); 972248e9111ee6 Christoph Hellwig 2019-01-29 108 972248e9111ee6 Christoph Hellwig 2019-01-29 109 out_free_rq: 17cb960f29c29e Christoph Hellwig 2018-03-13 @110 rq->q->bsg_dev.ops->free_rq(rq); 70e36eceaf897d FUJITA Tomonori 2006-12-20 111 blk_put_request(rq); 972248e9111ee6 Christoph Hellwig 2019-01-29 112 if (!ret && copy_to_user(uarg, &hdr, sizeof(hdr))) ccf3209f0044e4 Christoph Hellwig 2018-11-09 113 return -EFAULT; ccf3209f0044e4 Christoph Hellwig 2018-11-09 114 return ret; 70e36eceaf897d FUJITA Tomonori 2006-12-20 115 } 70e36eceaf897d FUJITA Tomonori 2006-12-20 116 3d6392cfbd7dc1 Jens Axboe 2007-07-09 117 static struct bsg_device *bsg_alloc_device(void) 3d6392cfbd7dc1 Jens Axboe 2007-07-09 118 { 3d6392cfbd7dc1 Jens Axboe 2007-07-09 119 struct bsg_device *bd; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 120 3d6392cfbd7dc1 Jens Axboe 2007-07-09 121 bd = kzalloc(sizeof(struct bsg_device), GFP_KERNEL); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 122 if (unlikely(!bd)) 3d6392cfbd7dc1 Jens Axboe 2007-07-09 123 return NULL; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 124 3d6392cfbd7dc1 Jens Axboe 2007-07-09 125 spin_lock_init(&bd->lock); 5309cb38de65ed Jens Axboe 2007-01-23 126 bd->max_queue = BSG_DEFAULT_CMDS; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 127 INIT_HLIST_NODE(&bd->dev_list); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 128 return bd; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 129 } 3d6392cfbd7dc1 Jens Axboe 2007-07-09 130 3d6392cfbd7dc1 Jens Axboe 2007-07-09 131 static int bsg_put_device(struct bsg_device *bd) 3d6392cfbd7dc1 Jens Axboe 2007-07-09 132 { 97f46ae45c7085 FUJITA Tomonori 2008-04-19 133 struct request_queue *q = bd->queue; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 134 3d6392cfbd7dc1 Jens Axboe 2007-07-09 135 mutex_lock(&bsg_mutex); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 136 db193954ed9e35 John Pittman 2018-08-27 137 if (!refcount_dec_and_test(&bd->ref_count)) { 3f27e3ed11e67c FUJITA Tomonori 2008-05-29 138 mutex_unlock(&bsg_mutex); 28519c891c5ad5 Christoph Hellwig 2018-07-12 139 return 0; 3f27e3ed11e67c FUJITA Tomonori 2008-05-29 140 } 3f27e3ed11e67c FUJITA Tomonori 2008-05-29 141 3f27e3ed11e67c FUJITA Tomonori 2008-05-29 142 hlist_del(&bd->dev_list); 3f27e3ed11e67c FUJITA Tomonori 2008-05-29 143 mutex_unlock(&bsg_mutex); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 144 3124b65dad946c Johannes Thumshirn 2018-01-24 145 bsg_dbg(bd, "tearing down\n"); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 146 3d6392cfbd7dc1 Jens Axboe 2007-07-09 147 /* 3d6392cfbd7dc1 Jens Axboe 2007-07-09 148 * close can always block 3d6392cfbd7dc1 Jens Axboe 2007-07-09 149 */ 5309cb38de65ed Jens Axboe 2007-01-23 150 kfree(bd); 97f46ae45c7085 FUJITA Tomonori 2008-04-19 151 blk_put_queue(q); 28519c891c5ad5 Christoph Hellwig 2018-07-12 152 return 0; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 153 } 3d6392cfbd7dc1 Jens Axboe 2007-07-09 154 3d6392cfbd7dc1 Jens Axboe 2007-07-09 155 static struct bsg_device *bsg_add_device(struct inode *inode, d351af01b93075 FUJITA Tomonori 2007-07-09 156 struct request_queue *rq, 3d6392cfbd7dc1 Jens Axboe 2007-07-09 157 struct file *file) 3d6392cfbd7dc1 Jens Axboe 2007-07-09 158 { 25fd164303cd69 Jens Axboe 2007-07-17 159 struct bsg_device *bd; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 160 unsigned char buf[32]; d9f972644606ec Bart Van Assche 2017-05-31 161 d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 162 lockdep_assert_held(&bsg_mutex); d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 163 09ac46c429464c Tejun Heo 2011-12-14 164 if (!blk_get_queue(rq)) c3ff1b90d8924d FUJITA Tomonori 2008-03-31 165 return ERR_PTR(-ENXIO); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 166 3d6392cfbd7dc1 Jens Axboe 2007-07-09 167 bd = bsg_alloc_device(); c3ff1b90d8924d FUJITA Tomonori 2008-03-31 168 if (!bd) { c3ff1b90d8924d FUJITA Tomonori 2008-03-31 169 blk_put_queue(rq); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 170 return ERR_PTR(-ENOMEM); c3ff1b90d8924d FUJITA Tomonori 2008-03-31 171 } 3d6392cfbd7dc1 Jens Axboe 2007-07-09 172 d351af01b93075 FUJITA Tomonori 2007-07-09 173 bd->queue = rq; 0b07de85a76e13 Adel Gadllah 2008-06-26 174 db193954ed9e35 John Pittman 2018-08-27 175 refcount_set(&bd->ref_count, 1); 842ea771c38a3f FUJITA Tomonori 2008-03-31 176 hlist_add_head(&bd->dev_list, bsg_dev_idx_hash(iminor(inode))); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 177 3ada8b7e980dac Kay Sievers 2009-01-06 @178 strncpy(bd->name, dev_name(rq->bsg_dev.class_dev), sizeof(bd->name) - 1); 3124b65dad946c Johannes Thumshirn 2018-01-24 179 bsg_dbg(bd, "bound to <%s>, max queue %d\n", 9e69fbb5373f7c FUJITA Tomonori 2006-12-20 180 format_dev_t(buf, inode->i_rdev), bd->max_queue); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 181 3d6392cfbd7dc1 Jens Axboe 2007-07-09 182 return bd; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 183 } 3d6392cfbd7dc1 Jens Axboe 2007-07-09 184 842ea771c38a3f FUJITA Tomonori 2008-03-31 185 static struct bsg_device *__bsg_get_device(int minor, struct request_queue *q) 3d6392cfbd7dc1 Jens Axboe 2007-07-09 186 { 43ac9e62c4a0a4 FUJITA Tomonori 2008-03-31 187 struct bsg_device *bd; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 188 d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 189 lockdep_assert_held(&bsg_mutex); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 190 b67bfe0d42cac5 Sasha Levin 2013-02-27 191 hlist_for_each_entry(bd, bsg_dev_idx_hash(minor), dev_list) { 842ea771c38a3f FUJITA Tomonori 2008-03-31 192 if (bd->queue == q) { db193954ed9e35 John Pittman 2018-08-27 193 refcount_inc(&bd->ref_count); 43ac9e62c4a0a4 FUJITA Tomonori 2008-03-31 194 goto found; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 195 } 3d6392cfbd7dc1 Jens Axboe 2007-07-09 196 } 43ac9e62c4a0a4 FUJITA Tomonori 2008-03-31 197 bd = NULL; 43ac9e62c4a0a4 FUJITA Tomonori 2008-03-31 198 found: 3d6392cfbd7dc1 Jens Axboe 2007-07-09 199 return bd; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 200 } 3d6392cfbd7dc1 Jens Axboe 2007-07-09 201 3d6392cfbd7dc1 Jens Axboe 2007-07-09 202 static struct bsg_device *bsg_get_device(struct inode *inode, struct file *file) 3d6392cfbd7dc1 Jens Axboe 2007-07-09 203 { 598443a2124618 FUJITA Tomonori 2007-07-23 204 struct bsg_device *bd; 598443a2124618 FUJITA Tomonori 2007-07-23 205 struct bsg_class_device *bcd; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 206 3d6392cfbd7dc1 Jens Axboe 2007-07-09 207 /* 3d6392cfbd7dc1 Jens Axboe 2007-07-09 208 * find the class device 3d6392cfbd7dc1 Jens Axboe 2007-07-09 209 */ 3d6392cfbd7dc1 Jens Axboe 2007-07-09 210 mutex_lock(&bsg_mutex); 598443a2124618 FUJITA Tomonori 2007-07-23 211 bcd = idr_find(&bsg_minor_idr, iminor(inode)); 3d6392cfbd7dc1 Jens Axboe 2007-07-09 212 d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 213 if (!bcd) { d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 214 bd = ERR_PTR(-ENODEV); d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 215 goto out_unlock; d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 216 } 3d6392cfbd7dc1 Jens Axboe 2007-07-09 217 842ea771c38a3f FUJITA Tomonori 2008-03-31 @218 bd = __bsg_get_device(iminor(inode), bcd->queue); d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 219 if (!bd) d45ac4fa8f277e FUJITA Tomonori 2008-03-31 220 bd = bsg_add_device(inode, bcd->queue, file); d45ac4fa8f277e FUJITA Tomonori 2008-03-31 221 d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 222 out_unlock: d6c73964f1e2a0 Anatoliy Glagolev 2018-06-13 223 mutex_unlock(&bsg_mutex); d45ac4fa8f277e FUJITA Tomonori 2008-03-31 224 return bd; 3d6392cfbd7dc1 Jens Axboe 2007-07-09 225 } 3d6392cfbd7dc1 Jens Axboe 2007-07-09 226 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org