Hi Scott, I love your patch! Yet something to improve: [auto build test ERROR on driver-core/driver-core-testing] [also build test ERROR on linus/master next-20200611] [cannot apply to char-misc/char-misc-testing kselftest/next integrity/next-integrity v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-reque... base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git abfbb29297c27e3f101f348dc9e467b0fe70f919 config: nios2-randconfig-r015-20200612 (attached as .config) compiler: nios2-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>, old ones prefixed by <<): In file included from drivers/staging/gs_fpgaboot/gs_fpgaboot.c:15: 112 | void *buf, size_t size, offset) | ^~~~~~ | off_t vim +112 include/linux/firmware.h 107 108 static inline int request_partial_firmware_into_buf 109 (const struct firmware **firmware_p, 110 const char *name, 111 struct device *device, 113 { 114 return -EINVAL; 115 } 116 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org