Hi "Toke,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/bpf-Rewor...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: h8300-randconfig-r001-20201014 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/49323d0d5b278524de4bd9450ce2962a4...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Toke-H-iland-J-rgensen/bpf-Rework-bpf_redirect_neigh-to-allow-supplying-nexthop-from-caller/20201015-234710
git checkout 49323d0d5b278524de4bd9450ce2962a44311fec
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/core/filter.c:20:
include/linux/scatterlist.h: In function 'sg_set_buf':
include/asm-generic/page.h:93:50: warning: ordered comparison of pointer with null
pointer [-Wextra]
93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET)
&& \
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro
'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
net/core/filter.c: In function '__bpf_redirect_neigh':
> net/core/filter.c:2404:10: error: too many arguments to function
'__bpf_redirect_neigh_v6'
2404 | return __bpf_redirect_neigh_v6(skb,
dev, nh);
| ^~~~~~~~~~~~~~~~~~~~~~~
net/core/filter.c:2267:12: note: declared here
2267 | static int __bpf_redirect_neigh_v6(struct sk_buff *skb, struct net_device
*dev)
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/h8300/include/asm/atomic.h:7,
from include/linux/atomic.h:7,
from include/asm-generic/bitops/lock.h:5,
from arch/h8300/include/asm/bitops.h:170,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/core/filter.c:20:
net/core/filter.c: In function 'bpf_clear_redirect_map':
arch/h8300/include/asm/cmpxchg.h:54:3: warning: value computed is not used
[-Wunused-value]
54 | ((__typeof__(*(ptr)))__cmpxchg_local_generic((ptr), \
| ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
55 | (unsigned long)(o), \
| ~~~~~~~~~~~~~~~~~~~~~
56 | (unsigned long)(n), \
| ~~~~~~~~~~~~~~~~~~~~~
57 | sizeof(*(ptr))))
| ~~~~~~~~~~~~~~~~
include/asm-generic/cmpxchg.h:106:28: note: in expansion of macro
'cmpxchg_local'
106 | #define cmpxchg(ptr, o, n) cmpxchg_local((ptr), (o), (n))
| ^~~~~~~~~~~~~
net/core/filter.c:3978:4: note: in expansion of macro 'cmpxchg'
3978 | cmpxchg(&ri->map, map, NULL);
| ^~~~~~~
vim +/__bpf_redirect_neigh_v6 +2404 net/core/filter.c
2385
2386 static int __bpf_redirect_neigh(struct sk_buff *skb, struct net_device *dev,
2387 struct bpf_nh_params *nh)
2388 {
2389 struct ethhdr *ethh = eth_hdr(skb);
2390
2391 if (unlikely(skb->mac_header >= skb->network_header))
2392 goto out;
2393 bpf_push_mac_rcsum(skb);
2394 if (is_multicast_ether_addr(ethh->h_dest))
2395 goto out;
2396
2397 skb_pull(skb, sizeof(*ethh));
2398 skb_unset_mac_header(skb);
2399 skb_reset_network_header(skb);
2400
2401 if (skb->protocol == htons(ETH_P_IP))
2402 return __bpf_redirect_neigh_v4(skb, dev, nh);
2403 else if (skb->protocol == htons(ETH_P_IPV6))
2404 return __bpf_redirect_neigh_v6(skb, dev, nh);
2405 out:
2406 kfree_skb(skb);
2407 return -ENOTSUPP;
2408 }
2409
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org