[android-common:android-4.19-stable 15107/24076] drivers/nvmem/core.c:347:5: warning: no previous prototype for 'nvmem_add_cells'
9:16 a.m.
tree: https://android.googlesource.com/kernel/common android-4.19-stable
head: a513b1ef96dcd295f77365400c8574d930c7662e
commit: e96a10625581a499e8a4218ef504f3f53918408b [15107/24076] UPSTREAM: nvmem: add
support for cell info
config: i386-randconfig-r036-20210929 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android-4.19-stable
git checkout e96a10625581a499e8a4218ef504f3f53918408b
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/nvmem/core.c:347:5: warning: no previous prototype for
'nvmem_add_cells' [-Wmissing-prototypes]
347 | int
nvmem_add_cells(struct nvmem_device *nvmem,
| ^~~~~~~~~~~~~~~
vim +/nvmem_add_cells +347 drivers/nvmem/core.c
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 337
b3db17e4b864e4 Andrew Lunn 2018-05-11 338 /**
b3db17e4b864e4 Andrew Lunn 2018-05-11 339 * nvmem_add_cells() - Add cell
information to an nvmem device
b3db17e4b864e4 Andrew Lunn 2018-05-11 340 *
b3db17e4b864e4 Andrew Lunn 2018-05-11 341 * @nvmem: nvmem device to add cells
to.
b3db17e4b864e4 Andrew Lunn 2018-05-11 342 * @info: nvmem cell info to add to
the device
b3db17e4b864e4 Andrew Lunn 2018-05-11 343 * @ncells: number of cells in info
b3db17e4b864e4 Andrew Lunn 2018-05-11 344 *
b3db17e4b864e4 Andrew Lunn 2018-05-11 345 * Return: 0 or negative error code on
failure.
b3db17e4b864e4 Andrew Lunn 2018-05-11 346 */
b3db17e4b864e4 Andrew Lunn 2018-05-11 @347 int nvmem_add_cells(struct
nvmem_device *nvmem,
b3db17e4b864e4 Andrew Lunn 2018-05-11 348 const struct nvmem_cell_info
*info,
b3db17e4b864e4 Andrew Lunn 2018-05-11 349 int ncells)
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 350 {
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 351 struct nvmem_cell **cells;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 352 int i, rval;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 353
b3db17e4b864e4 Andrew Lunn 2018-05-11 354 cells = kcalloc(ncells,
sizeof(*cells), GFP_KERNEL);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 355 if (!cells)
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 356 return -ENOMEM;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 357
b3db17e4b864e4 Andrew Lunn 2018-05-11 358 for (i = 0; i < ncells; i++) {
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 359 cells[i] = kzalloc(sizeof(**cells),
GFP_KERNEL);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 360 if (!cells[i]) {
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 361 rval = -ENOMEM;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 362 goto err;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 363 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 364
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 365 rval =
nvmem_cell_info_to_nvmem_cell(nvmem, &info[i], cells[i]);
287980e49ffc0f Arnd Bergmann 2016-05-27 366 if (rval) {
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 367 kfree(cells[i]);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 368 goto err;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 369 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 370
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 371 nvmem_cell_add(cells[i]);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 372 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 373
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 374 /* remove tmp array */
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 375 kfree(cells);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 376
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 377 return 0;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 378 err:
dfdf141429f089 Rasmus Villemoes 2016-02-08 379 while (i--)
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 380 nvmem_cell_drop(cells[i]);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 381
dfdf141429f089 Rasmus Villemoes 2016-02-08 382 kfree(cells);
dfdf141429f089 Rasmus Villemoes 2016-02-08 383
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 384 return rval;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 385 }
b3db17e4b864e4 Andrew Lunn 2018-05-11 386 EXPORT_SYMBOL_GPL(nvmem_add_cells);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 387
:::::: The code at line 347 was first introduced by commit
:::::: b3db17e4b864e46ad150ebef69c0e0130a1c5fca drivers: nvmem: Export nvmem_add_cells()
:::::: TO: Andrew Lunn <andrew(a)lunn.ch>
:::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
312
days inactive
312
days old
0 comments
1 participants
participants (1)
-
kernel test robot