Hi Rodrigo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.14-rc1 next-20210713]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Rodrigo-Siqueira/drm-amd-display...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
7fef2edf7cc753b51f7ccc74993971b0a9c81eca
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/a35eeee5a7e5682f85e0d466a6160aaf4...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Rodrigo-Siqueira/drm-amd-display-Base-changes-for-isolating-FPU-operation-in-a-single-place/20210713-220840
git checkout a35eeee5a7e5682f85e0d466a6160aaf49b1dd5f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:44:6:
warning: no previous prototype for 'dc_fpu_begin' [-Wmissing-prototypes]
44 | void dc_fpu_begin(const char *function_name, const int line)
| ^~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c: In function
'dc_fpu_begin':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:47:2: error: too few arguments
to function 'kernel_fpu_begin'
47 | kernel_fpu_begin();
| ^~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:29:
arch/s390/include/asm/fpu/api.h:96:20: note: declared here
96 | static inline void kernel_fpu_begin(struct kernel_fpu *state, u32 flags)
| ^~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c: At top level:
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:60:6:
warning: no previous prototype for 'dc_fpu_end' [-Wmissing-prototypes]
60 | void dc_fpu_end(const char *function_name, const int line)
| ^~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c: In function
'dc_fpu_end':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:63:2: error: too few arguments
to function 'kernel_fpu_end'
63 | kernel_fpu_end();
| ^~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:29:
arch/s390/include/asm/fpu/api.h:109:20: note: declared here
109 | static inline void kernel_fpu_end(struct kernel_fpu *state, u32 flags)
| ^~~~~~~~~~~~~~
vim +/dc_fpu_begin +44 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c
30
31 /**
32 * dc_fpu_begin - Enables FPU protection
33 * @function_name: A string containing the function name for debug purposes
34 * (usually __func__)
35 *
36 * @line: A line number where DC_FP_START was invoked for debug purpose
37 * (usually __LINE__)
38 *
39 * This function is responsible for managing the use of kernel_fpu_begin() with
40 * the advantage of providing an event trace for debugging.
41 *
42 * Note: Do not call this function directly; always use DC_FP_START().
43 */
44 void dc_fpu_begin(const char *function_name, const int line)
45 {
46 TRACE_DCN_FPU(true, function_name, line);
47 kernel_fpu_begin();
48 }
49
50 /**
51 * dc_fpu_end - Disable FPU protection
52 * @function_name: A string containing the function name for debug purposes
53 * @line: A-line number where DC_FP_END was invoked for debug purpose
54 *
55 * This function is responsible for managing the use of kernel_fpu_end() with
56 * the advantage of providing an event trace for debugging.
57 *
58 * Note: Do not call this function directly; always use DC_FP_END().
59 */
60 void dc_fpu_end(const char *function_name, const int line)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org