Hi Florian,
I love your patch! Yet something to improve:
[auto build test ERROR on net/master]
url:
https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-phy-broadco...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
8515455720c52a0841bd1c9c5f457c9616900110
config: nios2-randconfig-r006-20210309 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/06734c5da3238dad0a1ec26dac3d46987...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Florian-Fainelli/net-phy-broadcom-Suspend-fixes/20210311-044539
git checkout 06734c5da3238dad0a1ec26dac3d4698724157ac
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/phy/broadcom.c: In function 'bcm54xx_resume':
> drivers/net/phy/broadcom.c:405:2: error: implicit declaration of
function 'usleep'; did you mean 'fsleep'?
[-Werror=implicit-function-declaration]
405 | usleep(40);
| ^~~~~~
| fsleep
cc1: some warnings being treated as errors
vim +405 drivers/net/phy/broadcom.c
390
391 static int bcm54xx_resume(struct phy_device *phydev)
392 {
393 int ret;
394
395 /* Writes to register other than BMCR would be ignored
396 * unless we clear the PDOWN bit first
397 */
398 ret = genphy_resume(phydev);
399 if (ret < 0)
400 return ret;
401
402 /* Upon exiting power down, the PHY remains in an internal reset state
403 * for 40us
404 */
405 usleep(40);
406
407 return bcm54xx_config_init(phydev);
408 }
409
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org