[agd5f:drm-next 51/92] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning: no previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'
7 a.m.
tree: https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head: eaae0714f4a82df81a60c6aae74c568e8974a716
commit: f140fc51a32ef8637b522a880b8f9f14683ce8df [51/92] drm/amdgpu: Pin MMIO/DOORBELL
BO's in GTT domain
config: x86_64-randconfig-r001-20211118 (attached as .config)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f drm-next
git checkout f140fc51a32ef8637b522a880b8f9f14683ce8df
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning:
no previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'
[-Wmissing-prototypes]
void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
^
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:1: note: declare 'static'
if the function is not intended to be used outside of this translation unit
void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
^
static
1 warning generated.
vim +/amdgpu_amdkfd_gpuvm_unpin_bo +1335 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
1326
1327 /**
1328 * amdgpu_amdkfd_gpuvm_unpin_bo() - Unpins BO using following criteria
1329 * @bo: Handle of buffer object being unpinned
1330 *
1331 * - Is a illegal request for USERPTR BOs and is ignored
1332 * - All other BO types (GTT, VRAM, MMIO and DOORBELL) will have their
1333 * PIN count decremented. Calls to UNPIN must balance calls to PIN
1334 */
1335 void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
1336 {
1337 int ret = 0;
1338
1339 ret = amdgpu_bo_reserve(bo, false);
1340 if (unlikely(ret))
1341 return;
1342
1343 amdgpu_bo_unpin(bo);
1344 amdgpu_bo_unreserve(bo);
1345 }
1346
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8:52 a.m.
[AMD Official Use Only]
Felix,
Could you advise if I should submit a patch to fix the warning. The api under question
(amdgpu_amdkfd_gpuvm_unpin_bo) MUST be non-static in DKMS branch. However it could be
specified as static on drm-next. What is the policy under such situations. Let me know.
Regards,
Ramesh
-----Original Message-----
From: kernel test robot <lkp(a)intel.com>
Sent: Thursday, November 18, 2021 2:00 PM
To: Errabolu, Ramesh <Ramesh.Errabolu(a)amd.com>
Cc: llvm(a)lists.linux.dev; kbuild-all(a)lists.01.org; linux-kernel(a)vger.kernel.org; Deucher,
Alexander <Alexander.Deucher(a)amd.com>; Kuehling, Felix
<Felix.Kuehling(a)amd.com>
Subject: [agd5f:drm-next 51/92] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6:
warning: no previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'
[CAUTION: External Email]
tree:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab....
drm-next
head: eaae0714f4a82df81a60c6aae74c568e8974a716
commit: f140fc51a32ef8637b522a880b8f9f14683ce8df [51/92] drm/amdgpu: Pin MMIO/DOORBELL
BO's in GTT domain
config: x86_64-randconfig-r001-20211118 (attached as .config) reproduce (this is a W=1
build):
wget
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.git...
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab....
git fetch --no-tags agd5f drm-next
git checkout f140fc51a32ef8637b522a880b8f9f14683ce8df
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning:
no
> previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'
> [-Wmissing-prototypes]
void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo
*bo)
^
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:1: note: declare 'static'
if the function is not intended to be used outside of this translation unit
void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
^
static
1 warning generated.
vim +/amdgpu_amdkfd_gpuvm_unpin_bo +1335 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
1326
1327 /**
1328 * amdgpu_amdkfd_gpuvm_unpin_bo() - Unpins BO using following criteria
1329 * @bo: Handle of buffer object being unpinned
1330 *
1331 * - Is a illegal request for USERPTR BOs and is ignored
1332 * - All other BO types (GTT, VRAM, MMIO and DOORBELL) will have their
1333 * PIN count decremented. Calls to UNPIN must balance calls to PIN
1334 */
1335 void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
1336 {
1337 int ret = 0;
1338
1339 ret = amdgpu_bo_reserve(bo, false);
1340 if (unlikely(ret))
1341 return;
1342
1343 amdgpu_bo_unpin(bo);
1344 amdgpu_bo_unreserve(bo);
1345 }
1346
---
0-DAY CI Kernel Test Service, Intel Corporation
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.0...
306
days inactive
306
days old
1 comments
2 participants
participants (2)
-
Errabolu, Ramesh -
kernel test robot