Hi Kees, I love your patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on linus/master v5.8-rc1 next-20200618] [cannot apply to wireless-drivers/master rw-ubifs/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Kees-Cook/Remove-uninitialized_v... base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-ne... master config: x86_64-randconfig-m001-20200619 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; New smatch warnings: drivers/gpu/drm/drm_edid.c:3078 drm_cvt_modes() error: uninitialized symbol 'width'. # https://github.com/0day-ci/linux/commit/f58ed1805d1492d80a38f58702a37a099... git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout f58ed1805d1492d80a38f58702a37a0996973ffc vim +/width +3078 drivers/gpu/drm/drm_edid.c 139315796778a6 Adam Jackson 2010-08-03 3043 static int drm_cvt_modes(struct drm_connector *connector, 139315796778a6 Adam Jackson 2010-08-03 3044 struct detailed_timing *timing) 139315796778a6 Adam Jackson 2010-08-03 3045 { 139315796778a6 Adam Jackson 2010-08-03 3046 int i, j, modes = 0; 139315796778a6 Adam Jackson 2010-08-03 3047 struct drm_display_mode *newmode; 139315796778a6 Adam Jackson 2010-08-03 3048 struct drm_device *dev = connector->dev; 139315796778a6 Adam Jackson 2010-08-03 3049 struct cvt_timing *cvt; 139315796778a6 Adam Jackson 2010-08-03 3050 const int rates[] = { 60, 85, 75, 60, 50 }; 139315796778a6 Adam Jackson 2010-08-03 3051 const u8 empty[3] = { 0, 0, 0 }; a327f6b806103e Adam Jackson 2010-03-29 3052 139315796778a6 Adam Jackson 2010-08-03 3053 for (i = 0; i < 4; i++) { f58ed1805d1492 Kees Cook 2020-06-19 3054 int width, height; 139315796778a6 Adam Jackson 2010-08-03 3055 cvt = &(timing->data.other_data.data.cvt[i]); 9cf00977da0920 Adam Jackson 2009-12-03 3056 139315796778a6 Adam Jackson 2010-08-03 3057 if (!memcmp(cvt->code, empty, 3)) 9cf00977da0920 Adam Jackson 2009-12-03 3058 continue; 9cf00977da0920 Adam Jackson 2009-12-03 3059 139315796778a6 Adam Jackson 2010-08-03 3060 height = (cvt->code[0] + ((cvt->code[1] & 0xf0) << 4) + 1) * 2; 139315796778a6 Adam Jackson 2010-08-03 3061 switch (cvt->code[1] & 0x0c) { 139315796778a6 Adam Jackson 2010-08-03 3062 case 0x00: 139315796778a6 Adam Jackson 2010-08-03 3063 width = height * 4 / 3; 139315796778a6 Adam Jackson 2010-08-03 3064 break; 139315796778a6 Adam Jackson 2010-08-03 3065 case 0x04: 139315796778a6 Adam Jackson 2010-08-03 3066 width = height * 16 / 9; 139315796778a6 Adam Jackson 2010-08-03 3067 break; 139315796778a6 Adam Jackson 2010-08-03 3068 case 0x08: 139315796778a6 Adam Jackson 2010-08-03 3069 width = height * 16 / 10; 139315796778a6 Adam Jackson 2010-08-03 3070 break; 139315796778a6 Adam Jackson 2010-08-03 3071 case 0x0c: 139315796778a6 Adam Jackson 2010-08-03 3072 width = height * 15 / 9; 139315796778a6 Adam Jackson 2010-08-03 3073 break; Default case? 139315796778a6 Adam Jackson 2010-08-03 3074 } 139315796778a6 Adam Jackson 2010-08-03 3075 139315796778a6 Adam Jackson 2010-08-03 3076 for (j = 1; j < 5; j++) { 139315796778a6 Adam Jackson 2010-08-03 3077 if (cvt->code[2] & (1 << j)) { 139315796778a6 Adam Jackson 2010-08-03 @3078 newmode = drm_cvt_mode(dev, width, height, 139315796778a6 Adam Jackson 2010-08-03 3079 rates[j], j == 0, 139315796778a6 Adam Jackson 2010-08-03 3080 false, false); 139315796778a6 Adam Jackson 2010-08-03 3081 if (newmode) { 139315796778a6 Adam Jackson 2010-08-03 3082 drm_mode_probed_add(connector, newmode); 139315796778a6 Adam Jackson 2010-08-03 3083 modes++; 139315796778a6 Adam Jackson 2010-08-03 3084 } 139315796778a6 Adam Jackson 2010-08-03 3085 } 139315796778a6 Adam Jackson 2010-08-03 3086 } f453ba0460742a Dave Airlie 2008-11-07 3087 } f453ba0460742a Dave Airlie 2008-11-07 3088 f453ba0460742a Dave Airlie 2008-11-07 3089 return modes; f453ba0460742a Dave Airlie 2008-11-07 3090 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org