Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on linusw-pinctrl/devel] [cannot apply to geert-renesas-drivers/renesas-pinctrl v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/pinctrl-Get-rid-... base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel config: x86_64-randconfig-a012-20211214 (https://download.01.org/0day-ci/archive/20211214/202112142358.CrwPNZbA-lk...) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/fb259425f395e043cd3ef074641937e28... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/pinctrl-Get-rid-of-duplicate-of_node-assignment-in-the-drivers/20211214-210027 git checkout fb259425f395e043cd3ef074641937e28d0cffb9 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): static const struct platform_device_id max77620_pinctrl_devtype[] = { ^ include/linux/platform_device.h:21:8: note: forward declaration of 'struct platform_device_id' struct platform_device_id; ^ 1 error generated. vim +649 drivers/pinctrl/pinctrl-max77620.c 2df723d49cdafb6 Laxman Dewangan 2016-05-13 648 2df723d49cdafb6 Laxman Dewangan 2016-05-13 @649 static const struct platform_device_id max77620_pinctrl_devtype[] = { 2df723d49cdafb6 Laxman Dewangan 2016-05-13 650 { .name = "max77620-pinctrl", }, 2df723d49cdafb6 Laxman Dewangan 2016-05-13 651 { .name = "max20024-pinctrl", }, 2df723d49cdafb6 Laxman Dewangan 2016-05-13 652 {}, 2df723d49cdafb6 Laxman Dewangan 2016-05-13 653 }; 2df723d49cdafb6 Laxman Dewangan 2016-05-13 654 MODULE_DEVICE_TABLE(platform, max77620_pinctrl_devtype); 2df723d49cdafb6 Laxman Dewangan 2016-05-13 655 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org