Hi Paolo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mptcp/export]
[cannot apply to shuah-kselftest/next linus/master v5.16-rc2 next-20211124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Paolo-Abeni/mptcp-improve-subflo...
base:
https://github.com/multipath-tcp/mptcp_net-next.git export
config: i386-randconfig-a002-20211124
(
https://download.01.org/0day-ci/archive/20211125/202111251042.JLoJ33k0-lk...)
compiler: clang version 14.0.0 (
https://github.com/llvm/llvm-project
67a1c45def8a75061203461ab0060c75c864df1c)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/6af8e28040c093866aa60ede3f980b53a...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Paolo-Abeni/mptcp-improve-subflow-creation-on-errors/20211125-005137
git checkout 6af8e28040c093866aa60ede3f980b53ab3594a5
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> net/mptcp/pm.c:203:6: warning: no previous prototype for function
'mptcp_pm_subflow_closed' [-Wmissing-prototypes]
void
mptcp_pm_subflow_closed(struct mptcp_sock *msk, u8 id)
^
net/mptcp/pm.c:203:1: note: declare 'static' if the function is not intended to
be used outside of this translation unit
void mptcp_pm_subflow_closed(struct mptcp_sock *msk, u8 id)
^
static
1 warning generated.
vim +/mptcp_pm_subflow_closed +203 net/mptcp/pm.c
6af8e28040c0938 Paolo Abeni 2021-11-24 202
1b1c7a0ef7f323f Peter Krystad 2020-03-27 @203 void mptcp_pm_subflow_closed(struct
mptcp_sock *msk, u8 id)
1b1c7a0ef7f323f Peter Krystad 2020-03-27 204 {
1b1c7a0ef7f323f Peter Krystad 2020-03-27 205 pr_debug("msk=%p", msk);
1b1c7a0ef7f323f Peter Krystad 2020-03-27 206 }
1b1c7a0ef7f323f Peter Krystad 2020-03-27 207
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org