Hi Tong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on chrome-platform/for-next] [also build test WARNING on v5.17-rc4 next-20220216] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Tong-Zhang/platform-chrome-cros_... base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220216/202202161903.6YHDLR8F-lk...) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/66345a4aecd6e4acba257476c6e44559f... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Tong-Zhang/platform-chrome-cros_ec-honor-acpi-off/20220216-142709 git checkout 66345a4aecd6e4acba257476c6e44559fccca143 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/chrome/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): drivers/platform/chrome/cros_ec_lpc.c: In function 'cros_ec_lpc_init': 553 | if (acpi_disable) | ^~~~~~~~~~~~ vim +553 drivers/platform/chrome/cros_ec_lpc.c 547 548 static int __init cros_ec_lpc_init(void) 549 { 550 int ret; 551 acpi_status status; 552 554 return -ENODEV; 555 556 status = acpi_get_devices(ACPI_DRV_NAME, cros_ec_lpc_parse_device, 557 &cros_ec_lpc_acpi_device_found, NULL); 558 if (ACPI_FAILURE(status)) 559 pr_warn(DRV_NAME ": Looking for %s failed\n", ACPI_DRV_NAME); 560 561 if (!cros_ec_lpc_acpi_device_found && 562 !dmi_check_system(cros_ec_lpc_dmi_table)) { 563 pr_err(DRV_NAME ": unsupported system.\n"); 564 return -ENODEV; 565 } 566 567 cros_ec_lpc_mec_init(EC_HOST_CMD_REGION0, 568 EC_LPC_ADDR_MEMMAP + EC_MEMMAP_SIZE); 569 570 /* Register the driver */ 571 ret = platform_driver_register(&cros_ec_lpc_driver); 572 if (ret) { 573 pr_err(DRV_NAME ": can't register driver: %d\n", ret); 574 cros_ec_lpc_mec_destroy(); 575 return ret; 576 } 577 578 if (!cros_ec_lpc_acpi_device_found) { 579 /* Register the device, and it'll get hooked up automatically */ 580 ret = platform_device_register(&cros_ec_lpc_device); 581 if (ret) { 582 pr_err(DRV_NAME ": can't register device: %d\n", ret); 583 platform_driver_unregister(&cros_ec_lpc_driver); 584 cros_ec_lpc_mec_destroy(); 585 } 586 } 587 588 return ret; 589 } 590 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org