[linuxtv-media:master 440/495] drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning: address of 'config->info' will always evaluate to 'true'
4:53 a.m.
CC: linux-media(a)vger.kernel.org
TO: Mauro Carvalho Chehab <mchehab(a)kernel.org>
CC: linux-media(a)vger.kernel.org
Hi Mauro,
First bad commit (maybe != root cause):
tree: git://linuxtv.org/media_tree.git master
head: 960b2dee908b0fc51cf670841de13b40b44aaaae
commit: 9d4fa1a16b28b1d12b0378993d2d48f572a045d9 [440/495] media: atomisp: cleanup
directory hierarchy
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 9d4fa1a16b28b1d12b0378993d2d48f572a045d9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
> drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning:
address of 'config->info' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!&config->info) {
~ ~~~~~~~~^~~~
1 warning generated.
--
> drivers/staging/media/atomisp/pci/sh_css.c:8621:14: warning:
address of 'pipe->output_stage' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (&pipe->output_stage)
~~ ~~~~~~^~~~~~~~~~~~
> drivers/staging/media/atomisp/pci/sh_css.c:8629:14: warning:
address of 'pipe->vf_stage' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (&pipe->vf_stage)
~~ ~~~~~~^~~~~~~~
> drivers/staging/media/atomisp/pci/sh_css.c:2460:1: warning: stack
frame size of 27088 bytes in function 'create_pipe' [-Wframe-larger-than=]
create_pipe(enum ia_css_pipe_mode mode,
^
3 warnings generated.
--
>
drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c:148:35:
warning: implicit conversion from 'unsigned long' to 'int32_t' (aka
'int') changes value from 18446744073709543424 to -8192 [-Wconstant-conversion]
return MAX(MIN(isp_strength, 0), -XNR_BLENDING_SCALE_FACTOR);
~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/media/atomisp//pci/hive_isp_css_include/math_support.h:35:52: note:
expanded from macro 'MAX'
#define MAX(a, b) (((a) > (b)) ? (a) : (b))
^
1 warning generated.
vim +4278 drivers/staging/media/atomisp/pci/atomisp_cmd.c
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4260
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4261 /*
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4262 * Function to set/get isp parameters to isp
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4263 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4264 int atomisp_param(struct atomisp_sub_device *asd, int flag,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4265 struct atomisp_parm *config)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4266 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4267 struct atomisp_device *isp = asd->isp;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4268 struct ia_css_pipe_config *vp_cfg =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4269 &asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL].
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4270 pipe_configs[IA_CSS_PIPE_ID_VIDEO];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4271
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4272 /* Read parameter for 3A binary info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4273 if (flag == 0) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4274 struct atomisp_css_dvs_grid_info *dvs_grid_info =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4275 atomisp_css_get_dvs_grid_info(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4276 &asd->params.curr_grid_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4277
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 @4278 if (!&config->info) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4279 dev_err(isp->dev, "ERROR: NULL pointer in
grid_info\n");
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4280 return -EINVAL;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4281 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4282 atomisp_curr_user_grid_info(asd, &config->info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4283
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4284 /* We always return the resolution and stride even if there is
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4285 * no valid metadata. This allows the caller to get the
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4286 * information needed to allocate user-space buffers. */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4287 config->metadata_config.metadata_height = asd->
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4288 stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4289 metadata_info.resolution.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4290 config->metadata_config.metadata_stride = asd->
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4291 stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4292 metadata_info.stride;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4293
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4294 /* update dvs grid info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4295 if (dvs_grid_info)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4296 memcpy(&config->dvs_grid,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4297 dvs_grid_info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4298 sizeof(struct atomisp_css_dvs_grid_info));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4299
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4300 if (asd->run_mode->val != ATOMISP_RUN_MODE_VIDEO) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4301 config->dvs_envelop.width = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4302 config->dvs_envelop.height = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4303 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4304 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4305
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4306 /* update dvs envelop info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4307 if (!asd->continuous_mode->val) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4308 config->dvs_envelop.width = vp_cfg->dvs_envelope.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4309 config->dvs_envelop.height =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4310 vp_cfg->dvs_envelope.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4311 } else {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4312 unsigned int dvs_w, dvs_h, dvs_w_max, dvs_h_max;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4313
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4314 dvs_w = vp_cfg->bayer_ds_out_res.width -
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4315 vp_cfg->output_info[0].res.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4316 dvs_h = vp_cfg->bayer_ds_out_res.height -
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4317 vp_cfg->output_info[0].res.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4318 dvs_w_max = rounddown(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4319 vp_cfg->output_info[0].res.width / 5,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4320 ATOM_ISP_STEP_WIDTH);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4321 dvs_h_max = rounddown(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4322 vp_cfg->output_info[0].res.height / 5,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4323 ATOM_ISP_STEP_HEIGHT);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4324
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4325 config->dvs_envelop.width = min(dvs_w, dvs_w_max);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4326 config->dvs_envelop.height = min(dvs_h, dvs_h_max);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4327 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4328
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4329 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4330 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4331
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4332 memcpy(&asd->params.css_param.wb_config,
&config->wb_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4333 sizeof(struct atomisp_css_wb_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4334 memcpy(&asd->params.css_param.ob_config,
&config->ob_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4335 sizeof(struct atomisp_css_ob_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4336 memcpy(&asd->params.css_param.dp_config,
&config->dp_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4337 sizeof(struct atomisp_css_dp_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4338 memcpy(&asd->params.css_param.de_config,
&config->de_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4339 sizeof(struct atomisp_css_de_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4340 memcpy(&asd->params.css_param.dz_config,
&config->dz_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4341 sizeof(struct atomisp_css_dz_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4342 memcpy(&asd->params.css_param.ce_config,
&config->ce_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4343 sizeof(struct atomisp_css_ce_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4344 memcpy(&asd->params.css_param.nr_config,
&config->nr_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4345 sizeof(struct atomisp_css_nr_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4346 memcpy(&asd->params.css_param.ee_config,
&config->ee_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4347 sizeof(struct atomisp_css_ee_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4348 memcpy(&asd->params.css_param.tnr_config,
&config->tnr_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4349 sizeof(struct atomisp_css_tnr_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4350
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4351 if (asd->params.color_effect == V4L2_COLORFX_NEGATIVE) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4352 asd->params.css_param.cc_config.matrix[3] =
-config->cc_config.matrix[3];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4353 asd->params.css_param.cc_config.matrix[4] =
-config->cc_config.matrix[4];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4354 asd->params.css_param.cc_config.matrix[5] =
-config->cc_config.matrix[5];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4355 asd->params.css_param.cc_config.matrix[6] =
-config->cc_config.matrix[6];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4356 asd->params.css_param.cc_config.matrix[7] =
-config->cc_config.matrix[7];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4357 asd->params.css_param.cc_config.matrix[8] =
-config->cc_config.matrix[8];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4358 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4359
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4360 if (asd->params.color_effect != V4L2_COLORFX_SEPIA
&&
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4361 asd->params.color_effect != V4L2_COLORFX_BW) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4362 memcpy(&asd->params.css_param.cc_config,
&config->cc_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4363 sizeof(struct atomisp_css_cc_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4364 atomisp_css_set_cc_config(asd,
&asd->params.css_param.cc_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4365 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4366
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4367 atomisp_css_set_wb_config(asd,
&asd->params.css_param.wb_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4368 atomisp_css_set_ob_config(asd,
&asd->params.css_param.ob_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4369 atomisp_css_set_de_config(asd,
&asd->params.css_param.de_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4370 atomisp_css_set_dz_config(asd,
&asd->params.css_param.dz_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4371 atomisp_css_set_ce_config(asd,
&asd->params.css_param.ce_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4372 atomisp_css_set_dp_config(asd,
&asd->params.css_param.dp_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4373 atomisp_css_set_nr_config(asd,
&asd->params.css_param.nr_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4374 atomisp_css_set_ee_config(asd,
&asd->params.css_param.ee_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4375 atomisp_css_set_tnr_config(asd,
&asd->params.css_param.tnr_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4376 asd->params.css_update_params_needed = true;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4377
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4378 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4379 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4380
:::::: The code at line 4278 was first introduced by commit
:::::: bdfe0beb95eebc864f341fd0c5e903672b90b1a2 media: atomisp: fix several coding style
issues
:::::: TO: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
5:42 a.m.
Hi Philip,
Any thoughts on why this wasn't sent to the author? I know we
restrict LLD warnings, but this case doesn't look like it's from LLD.
On Wed, May 20, 2020 at 11:54 AM kbuild test robot <lkp(a)intel.com> wrote:
CC: linux-media(a)vger.kernel.org
TO: Mauro Carvalho Chehab <mchehab(a)kernel.org>
CC: linux-media(a)vger.kernel.org
Hi Mauro,
First bad commit (maybe != root cause):
tree: git://linuxtv.org/media_tree.git master
head: 960b2dee908b0fc51cf670841de13b40b44aaaae
commit: 9d4fa1a16b28b1d12b0378993d2d48f572a045d9 [440/495] media: atomisp: cleanup
directory hierarchy
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 9d4fa1a16b28b1d12b0378993d2d48f572a045d9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning: address of
'config->info' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!&config->info) {
~ ~~~~~~~~^~~~
1 warning generated.
--
>> drivers/staging/media/atomisp/pci/sh_css.c:8621:14: warning: address of
'pipe->output_stage' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (&pipe->output_stage)
~~ ~~~~~~^~~~~~~~~~~~
>> drivers/staging/media/atomisp/pci/sh_css.c:8629:14: warning: address of
'pipe->vf_stage' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (&pipe->vf_stage)
~~ ~~~~~~^~~~~~~~
>> drivers/staging/media/atomisp/pci/sh_css.c:2460:1: warning: stack frame size of
27088 bytes in function 'create_pipe' [-Wframe-larger-than=]
create_pipe(enum ia_css_pipe_mode mode,
^
3 warnings generated.
--
>>
drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c:148:35:
warning: implicit conversion from 'unsigned long' to 'int32_t' (aka
'int') changes value from 18446744073709543424 to -8192 [-Wconstant-conversion]
return MAX(MIN(isp_strength, 0), -XNR_BLENDING_SCALE_FACTOR);
~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/media/atomisp//pci/hive_isp_css_include/math_support.h:35:52: note:
expanded from macro 'MAX'
#define MAX(a, b) (((a) > (b)) ? (a) : (b))
^
1 warning generated.
vim +4278 drivers/staging/media/atomisp/pci/atomisp_cmd.c
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4260
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4261 /*
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4262 * Function to set/get isp parameters to isp
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4263 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4264 int atomisp_param(struct atomisp_sub_device *asd, int flag,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4265 struct atomisp_parm *config)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4266 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4267 struct atomisp_device *isp = asd->isp;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4268 struct ia_css_pipe_config *vp_cfg =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4269
&asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL].
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4270 pipe_configs[IA_CSS_PIPE_ID_VIDEO];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4271
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4272 /* Read parameter for 3A binary info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4273 if (flag == 0) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4274 struct atomisp_css_dvs_grid_info *dvs_grid_info
=
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4275 atomisp_css_get_dvs_grid_info(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4276 &asd->params.curr_grid_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4277
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 @4278 if (!&config->info) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4279 dev_err(isp->dev, "ERROR: NULL
pointer in grid_info\n");
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4280 return -EINVAL;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4281 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4282 atomisp_curr_user_grid_info(asd,
&config->info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4283
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4284 /* We always return the resolution and stride
even if there is
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4285 * no valid metadata. This allows the caller to
get the
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4286 * information needed to allocate user-space
buffers. */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4287 config->metadata_config.metadata_height =
asd->
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4288
stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4289 metadata_info.resolution.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4290 config->metadata_config.metadata_stride =
asd->
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4291
stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4292 metadata_info.stride;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4293
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4294 /* update dvs grid info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4295 if (dvs_grid_info)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4296 memcpy(&config->dvs_grid,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4297 dvs_grid_info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4298 sizeof(struct
atomisp_css_dvs_grid_info));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4299
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4300 if (asd->run_mode->val !=
ATOMISP_RUN_MODE_VIDEO) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4301 config->dvs_envelop.width = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4302 config->dvs_envelop.height = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4303 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4304 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4305
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4306 /* update dvs envelop info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4307 if (!asd->continuous_mode->val) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4308 config->dvs_envelop.width =
vp_cfg->dvs_envelope.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4309 config->dvs_envelop.height =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4310 vp_cfg->dvs_envelope.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4311 } else {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4312 unsigned int dvs_w, dvs_h, dvs_w_max,
dvs_h_max;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4313
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4314 dvs_w = vp_cfg->bayer_ds_out_res.width
-
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4315
vp_cfg->output_info[0].res.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4316 dvs_h =
vp_cfg->bayer_ds_out_res.height -
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4317
vp_cfg->output_info[0].res.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4318 dvs_w_max = rounddown(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4319
vp_cfg->output_info[0].res.width / 5,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4320 ATOM_ISP_STEP_WIDTH);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4321 dvs_h_max = rounddown(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4322
vp_cfg->output_info[0].res.height / 5,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4323 ATOM_ISP_STEP_HEIGHT);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4324
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4325 config->dvs_envelop.width = min(dvs_w,
dvs_w_max);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4326 config->dvs_envelop.height =
min(dvs_h, dvs_h_max);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4327 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4328
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4329 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4330 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4331
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4332 memcpy(&asd->params.css_param.wb_config,
&config->wb_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4333 sizeof(struct atomisp_css_wb_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4334 memcpy(&asd->params.css_param.ob_config,
&config->ob_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4335 sizeof(struct atomisp_css_ob_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4336 memcpy(&asd->params.css_param.dp_config,
&config->dp_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4337 sizeof(struct atomisp_css_dp_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4338 memcpy(&asd->params.css_param.de_config,
&config->de_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4339 sizeof(struct atomisp_css_de_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4340 memcpy(&asd->params.css_param.dz_config,
&config->dz_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4341 sizeof(struct atomisp_css_dz_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4342 memcpy(&asd->params.css_param.ce_config,
&config->ce_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4343 sizeof(struct atomisp_css_ce_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4344 memcpy(&asd->params.css_param.nr_config,
&config->nr_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4345 sizeof(struct atomisp_css_nr_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4346 memcpy(&asd->params.css_param.ee_config,
&config->ee_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4347 sizeof(struct atomisp_css_ee_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4348 memcpy(&asd->params.css_param.tnr_config,
&config->tnr_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4349 sizeof(struct atomisp_css_tnr_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4350
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4351 if (asd->params.color_effect == V4L2_COLORFX_NEGATIVE)
{
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4352 asd->params.css_param.cc_config.matrix[3] =
-config->cc_config.matrix[3];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4353 asd->params.css_param.cc_config.matrix[4] =
-config->cc_config.matrix[4];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4354 asd->params.css_param.cc_config.matrix[5] =
-config->cc_config.matrix[5];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4355 asd->params.css_param.cc_config.matrix[6] =
-config->cc_config.matrix[6];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4356 asd->params.css_param.cc_config.matrix[7] =
-config->cc_config.matrix[7];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4357 asd->params.css_param.cc_config.matrix[8] =
-config->cc_config.matrix[8];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4358 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4359
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4360 if (asd->params.color_effect != V4L2_COLORFX_SEPIA
&&
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4361 asd->params.color_effect != V4L2_COLORFX_BW) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4362 memcpy(&asd->params.css_param.cc_config,
&config->cc_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4363 sizeof(struct atomisp_css_cc_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4364 atomisp_css_set_cc_config(asd,
&asd->params.css_param.cc_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4365 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4366
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4367 atomisp_css_set_wb_config(asd,
&asd->params.css_param.wb_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4368 atomisp_css_set_ob_config(asd,
&asd->params.css_param.ob_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4369 atomisp_css_set_de_config(asd,
&asd->params.css_param.de_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4370 atomisp_css_set_dz_config(asd,
&asd->params.css_param.dz_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4371 atomisp_css_set_ce_config(asd,
&asd->params.css_param.ce_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4372 atomisp_css_set_dp_config(asd,
&asd->params.css_param.dp_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4373 atomisp_css_set_nr_config(asd,
&asd->params.css_param.nr_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4374 atomisp_css_set_ee_config(asd,
&asd->params.css_param.ee_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4375 atomisp_css_set_tnr_config(asd,
&asd->params.css_param.tnr_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4376 asd->params.css_update_params_needed = true;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4377
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4378 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4379 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho
Chehab 2020-04-19 4380
:::::: The code at line 4278 was first introduced by commit
:::::: bdfe0beb95eebc864f341fd0c5e903672b90b1a2 media: atomisp: fix several coding style
issues
:::::: TO: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
You received this message because you are subscribed to the Google Groups "Clang
Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
clang-built-linux+unsubscribe(a)googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/clang-built-linux/202005210222.fkqS2pnd....
--
Thanks,
~Nick Desaulniers
10:49 a.m.
Hi Nick,
We ignored the "warning: stack frame size of 27088 bytes in function
'create_pipe' [-Wframe-larger-than=]" wrongly
according to https://lkml.org/lkml/2020/4/13/629, will revert it.
Best Regards,
Rong Chen
On 5/21/20 3:42 AM, Nick Desaulniers wrote:
Hi Philip,
Any thoughts on why this wasn't sent to the author? I know we
restrict LLD warnings, but this case doesn't look like it's from LLD.
On Wed, May 20, 2020 at 11:54 AM kbuild test robot <lkp(a)intel.com> wrote:
> CC: linux-media(a)vger.kernel.org
> TO: Mauro Carvalho Chehab <mchehab(a)kernel.org>
> CC: linux-media(a)vger.kernel.org
>
> Hi Mauro,
>
> First bad commit (maybe != root cause):
>
> tree: git://linuxtv.org/media_tree.git master
> head: 960b2dee908b0fc51cf670841de13b40b44aaaae
> commit: 9d4fa1a16b28b1d12b0378993d2d48f572a045d9 [440/495] media: atomisp: cleanup
directory hierarchy
> config: x86_64-allyesconfig (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
> reproduce:
> wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> git checkout 9d4fa1a16b28b1d12b0378993d2d48f572a045d9
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp(a)intel.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
>>> drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning: address of
'config->info' will always evaluate to 'true'
[-Wpointer-bool-conversion]
> if (!&config->info) {
> ~ ~~~~~~~~^~~~
> 1 warning generated.
> --
>>> drivers/staging/media/atomisp/pci/sh_css.c:8621:14: warning: address of
'pipe->output_stage' will always evaluate to 'true'
[-Wpointer-bool-conversion]
> if (&pipe->output_stage)
> ~~ ~~~~~~^~~~~~~~~~~~
>>> drivers/staging/media/atomisp/pci/sh_css.c:8629:14: warning: address of
'pipe->vf_stage' will always evaluate to 'true'
[-Wpointer-bool-conversion]
> if (&pipe->vf_stage)
> ~~ ~~~~~~^~~~~~~~
>>> drivers/staging/media/atomisp/pci/sh_css.c:2460:1: warning: stack frame size
of 27088 bytes in function 'create_pipe' [-Wframe-larger-than=]
> create_pipe(enum ia_css_pipe_mode mode,
> ^
> 3 warnings generated.
> --
>>>
drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c:148:35:
warning: implicit conversion from 'unsigned long' to 'int32_t' (aka
'int') changes value from 18446744073709543424 to -8192 [-Wconstant-conversion]
> return MAX(MIN(isp_strength, 0), -XNR_BLENDING_SCALE_FACTOR);
> ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/media/atomisp//pci/hive_isp_css_include/math_support.h:35:52: note:
expanded from macro 'MAX'
> #define MAX(a, b) (((a) > (b)) ? (a) : (b))
> ^
> 1 warning generated.
>
> vim +4278 drivers/staging/media/atomisp/pci/atomisp_cmd.c
>
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4260
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4261 /*
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4262 * Function to set/get isp parameters to isp
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4263 */
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4264 int atomisp_param(struct atomisp_sub_device *asd, int
flag,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4265 struct atomisp_parm *config)
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4266 {
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4267 struct atomisp_device *isp = asd->isp;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4268 struct ia_css_pipe_config *vp_cfg =
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4269
&asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL].
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4270 pipe_configs[IA_CSS_PIPE_ID_VIDEO];
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4271
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4272 /* Read parameter for 3A binary info */
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4273 if (flag == 0) {
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4274 struct atomisp_css_dvs_grid_info
*dvs_grid_info =
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4275 atomisp_css_get_dvs_grid_info(
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4276
&asd->params.curr_grid_info);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4277
> bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 @4278 if (!&config->info) {
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4279 dev_err(isp->dev,
"ERROR: NULL pointer in grid_info\n");
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4280 return -EINVAL;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4281 }
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4282 atomisp_curr_user_grid_info(asd,
&config->info);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4283
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4284 /* We always return the resolution and
stride even if there is
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4285 * no valid metadata. This allows the
caller to get the
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4286 * information needed to allocate
user-space buffers. */
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4287
config->metadata_config.metadata_height = asd->
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4288
stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4289
metadata_info.resolution.height;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4290
config->metadata_config.metadata_stride = asd->
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4291
stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4292 metadata_info.stride;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4293
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4294 /* update dvs grid info */
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4295 if (dvs_grid_info)
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4296
memcpy(&config->dvs_grid,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4297 dvs_grid_info,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4298 sizeof(struct
atomisp_css_dvs_grid_info));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4299
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4300 if (asd->run_mode->val !=
ATOMISP_RUN_MODE_VIDEO) {
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4301 config->dvs_envelop.width =
0;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4302 config->dvs_envelop.height =
0;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4303 return 0;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4304 }
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4305
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4306 /* update dvs envelop info */
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4307 if (!asd->continuous_mode->val) {
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4308 config->dvs_envelop.width =
vp_cfg->dvs_envelope.width;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4309 config->dvs_envelop.height =
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4310
vp_cfg->dvs_envelope.height;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4311 } else {
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4312 unsigned int dvs_w, dvs_h,
dvs_w_max, dvs_h_max;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4313
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4314 dvs_w =
vp_cfg->bayer_ds_out_res.width -
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4315
vp_cfg->output_info[0].res.width;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4316 dvs_h =
vp_cfg->bayer_ds_out_res.height -
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4317
vp_cfg->output_info[0].res.height;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4318 dvs_w_max = rounddown(
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4319
vp_cfg->output_info[0].res.width / 5,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4320
ATOM_ISP_STEP_WIDTH);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4321 dvs_h_max = rounddown(
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4322
vp_cfg->output_info[0].res.height / 5,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4323
ATOM_ISP_STEP_HEIGHT);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4324
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4325 config->dvs_envelop.width =
min(dvs_w, dvs_w_max);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4326 config->dvs_envelop.height =
min(dvs_h, dvs_h_max);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4327 }
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4328
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4329 return 0;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4330 }
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4331
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4332 memcpy(&asd->params.css_param.wb_config,
&config->wb_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4333 sizeof(struct atomisp_css_wb_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4334 memcpy(&asd->params.css_param.ob_config,
&config->ob_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4335 sizeof(struct atomisp_css_ob_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4336 memcpy(&asd->params.css_param.dp_config,
&config->dp_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4337 sizeof(struct atomisp_css_dp_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4338 memcpy(&asd->params.css_param.de_config,
&config->de_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4339 sizeof(struct atomisp_css_de_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4340 memcpy(&asd->params.css_param.dz_config,
&config->dz_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4341 sizeof(struct atomisp_css_dz_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4342 memcpy(&asd->params.css_param.ce_config,
&config->ce_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4343 sizeof(struct atomisp_css_ce_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4344 memcpy(&asd->params.css_param.nr_config,
&config->nr_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4345 sizeof(struct atomisp_css_nr_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4346 memcpy(&asd->params.css_param.ee_config,
&config->ee_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4347 sizeof(struct atomisp_css_ee_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4348 memcpy(&asd->params.css_param.tnr_config,
&config->tnr_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4349 sizeof(struct atomisp_css_tnr_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4350
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4351 if (asd->params.color_effect ==
V4L2_COLORFX_NEGATIVE) {
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4352
asd->params.css_param.cc_config.matrix[3] = -config->cc_config.matrix[3];
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4353
asd->params.css_param.cc_config.matrix[4] = -config->cc_config.matrix[4];
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4354
asd->params.css_param.cc_config.matrix[5] = -config->cc_config.matrix[5];
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4355
asd->params.css_param.cc_config.matrix[6] = -config->cc_config.matrix[6];
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4356
asd->params.css_param.cc_config.matrix[7] = -config->cc_config.matrix[7];
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4357
asd->params.css_param.cc_config.matrix[8] = -config->cc_config.matrix[8];
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4358 }
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4359
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4360 if (asd->params.color_effect !=
V4L2_COLORFX_SEPIA &&
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4361 asd->params.color_effect !=
V4L2_COLORFX_BW) {
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4362
memcpy(&asd->params.css_param.cc_config, &config->cc_config,
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4363 sizeof(struct
atomisp_css_cc_config));
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4364 atomisp_css_set_cc_config(asd,
&asd->params.css_param.cc_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4365 }
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4366
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4367 atomisp_css_set_wb_config(asd,
&asd->params.css_param.wb_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4368 atomisp_css_set_ob_config(asd,
&asd->params.css_param.ob_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4369 atomisp_css_set_de_config(asd,
&asd->params.css_param.de_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4370 atomisp_css_set_dz_config(asd,
&asd->params.css_param.dz_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4371 atomisp_css_set_ce_config(asd,
&asd->params.css_param.ce_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4372 atomisp_css_set_dp_config(asd,
&asd->params.css_param.dp_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4373 atomisp_css_set_nr_config(asd,
&asd->params.css_param.nr_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4374 atomisp_css_set_ee_config(asd,
&asd->params.css_param.ee_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4375 atomisp_css_set_tnr_config(asd,
&asd->params.css_param.tnr_config);
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4376 asd->params.css_update_params_needed = true;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4377
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4378 return 0;
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4379 }
> ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro
Carvalho Chehab 2020-04-19 4380
>
> :::::: The code at line 4278 was first introduced by commit
> :::::: bdfe0beb95eebc864f341fd0c5e903672b90b1a2 media: atomisp: fix several coding
style issues
>
> :::::: TO: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
> :::::: CC: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
> --
> You received this message because you are subscribed to the Google Groups "Clang
Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to
clang-built-linux+unsubscribe(a)googlegroups.com.
> To view this discussion on the web visit
https://groups.google.com/d/msgid/clang-built-linux/202005210222.fkqS2pnd....
852
days inactive
853
days old
2 comments
3 participants
participants (3)
-
kbuild test robot -
Nick Desaulniers -
Rong Chen