Hi Gayatri, Thank you for the patch! Yet something to improve: [auto build test ERROR on 7c60610d476766e128cc4284bb6349732cbd6606] url: https://github.com/0day-ci/linux/commits/Gayatri-Kammela/Add-Alder-Lake-P... base: 7c60610d476766e128cc4284bb6349732cbd6606 config: x86_64-rhel-8.3 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/2c7fa756944b862813729397f1fd1b383... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Gayatri-Kammela/Add-Alder-Lake-PCH-S-support-to-PMC-core-driver/20210817-010347 git checkout 2c7fa756944b862813729397f1fd1b383743b56b # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): ld: drivers/platform/x86/intel/pmc/core_platform.o: in function `pmc_core_platform_init': ld: drivers/platform/x86/intel/pmc/core_platform.o: in function `pmc_core_platform_exit': vim +49 drivers/platform/x86/intel/pmc/core_platform.c b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 47 b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 48 static int __init pmc_core_platform_init(void) b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 @49 { 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 50 int retval; 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 51 b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 52 /* Skip creating the platform device if ACPI already has a device */ b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 53 if (acpi_dev_present("INT33A1", NULL, -1)) b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 54 return -ENODEV; b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 55 b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 56 if (!x86_match_cpu(intel_pmc_core_platform_ids)) b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 57 return -ENODEV; b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 58 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 59 pmc_core_device = kzalloc(sizeof(*pmc_core_device), GFP_KERNEL); 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 60 if (!pmc_core_device) 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 61 return -ENOMEM; 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 62 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 63 pmc_core_device->name = "intel_pmc_core"; 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 64 pmc_core_device->dev.release = intel_pmc_core_release; 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 65 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 66 retval = platform_device_register(pmc_core_device); 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 67 if (retval) 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 68 kfree(pmc_core_device); 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 69 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 70 return retval; b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 71 } b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 72 b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 73 static void __exit pmc_core_platform_exit(void) b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 74 { 938835aa903ae1 drivers/platform/x86/intel_pmc_core_pltdrv.c Greg Kroah-Hartman 2020-09-23 @75 platform_device_unregister(pmc_core_device); b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 76 } b02f6a2ef0a14a drivers/platform/x86/intel_pmc_core_pltdrv.c Rajat Jain 2019-06-27 77 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org