Hi "Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.14-rc2 next-20210720] [cannot apply to xfs-linux/for-next block/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Folio-supp... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2734d6c1b1a089fb593ef6a23d4b70903526fe0c config: sparc-randconfig-r015-20210720 (attached as .config) compiler: sparc64-linux-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d611eec3f37483e1acbcc299bf47e9297... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Folio-support-in-block-iomap-layers/20210720-152323 git checkout d611eec3f37483e1acbcc299bf47e929766afc8d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/tracehook.h:50, from arch/sparc/kernel/signal_64.c:18: include/linux/bio.h: In function 'bio_first_folio': include/linux/bio.h:338:14: error: implicit declaration of function 'page_folio' [-Werror=implicit-function-declaration] 338 | fi->folio = page_folio(bvec->bv_page); | ^~~~~~~~~~ 338 | fi->folio = page_folio(bvec->bv_page); | ^ include/linux/bio.h:340:43: error: invalid use of undefined type 'struct folio' 340 | PAGE_SIZE * (bvec->bv_page - &fi->folio->page); | ^~ In file included from include/linux/kernel.h:16, from include/linux/list.h:9, from include/linux/rculist.h:10, from include/linux/pid.h:5, from include/linux/sched.h:14, from arch/sparc/kernel/signal_64.c:12: include/linux/bio.h:342:19: error: implicit declaration of function 'folio_size' [-Werror=implicit-function-declaration] 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~~~~~~~~ include/linux/minmax.h:20:21: note: in definition of macro '__typecheck' 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:342:15: note: in expansion of macro 'min' 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~ In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/tracehook.h:50, from arch/sparc/kernel/signal_64.c:18: include/linux/bio.h: In function 'bio_next_folio': include/linux/bio.h:350:15: error: implicit declaration of function 'folio_next' [-Werror=implicit-function-declaration] 350 | fi->folio = folio_next(fi->folio); | ^~~~~~~~~~ include/linux/bio.h:350:13: error: assignment to 'struct folio *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] 350 | fi->folio = folio_next(fi->folio); | ^ In file included from include/linux/kernel.h:16, from include/linux/list.h:9, from include/linux/rculist.h:10, from include/linux/pid.h:5, from include/linux/sched.h:14, from arch/sparc/kernel/signal_64.c:12: include/linux/minmax.h:20:28: error: comparison of distinct pointer types lacks a cast [-Werror] 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/minmax.h:26:4: note: in expansion of macro '__typecheck' 26 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:352:16: note: in expansion of macro 'min' 352 | fi->length = min(folio_size(fi->folio), fi->_seg_count); | ^~~ cc1: all warnings being treated as errors -- In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from arch/sparc/include/asm/tlb_64.h:5, from arch/sparc/include/asm/tlb.h:5, from arch/sparc/kernel/smp_64.c:49: include/linux/bio.h: In function 'bio_first_folio': include/linux/bio.h:338:14: error: implicit declaration of function 'page_folio'; did you mean 'page_endio'? [-Werror=implicit-function-declaration] 338 | fi->folio = page_folio(bvec->bv_page); | ^~~~~~~~~~ | page_endio 338 | fi->folio = page_folio(bvec->bv_page); | ^ include/linux/bio.h:340:43: error: invalid use of undefined type 'struct folio' 340 | PAGE_SIZE * (bvec->bv_page - &fi->folio->page); | ^~ In file included from include/linux/kernel.h:16, from arch/sparc/kernel/smp_64.c:8: include/linux/bio.h:342:19: error: implicit declaration of function 'folio_size' [-Werror=implicit-function-declaration] 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~~~~~~~~ include/linux/minmax.h:20:21: note: in definition of macro '__typecheck' 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:342:15: note: in expansion of macro 'min' 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~ In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from arch/sparc/include/asm/tlb_64.h:5, from arch/sparc/include/asm/tlb.h:5, from arch/sparc/kernel/smp_64.c:49: include/linux/bio.h: In function 'bio_next_folio': include/linux/bio.h:350:15: error: implicit declaration of function 'folio_next' [-Werror=implicit-function-declaration] 350 | fi->folio = folio_next(fi->folio); | ^~~~~~~~~~ include/linux/bio.h:350:13: error: assignment to 'struct folio *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] 350 | fi->folio = folio_next(fi->folio); | ^ In file included from include/linux/kernel.h:16, from arch/sparc/kernel/smp_64.c:8: include/linux/minmax.h:20:28: error: comparison of distinct pointer types lacks a cast [-Werror] 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/minmax.h:26:4: note: in expansion of macro '__typecheck' 26 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:352:16: note: in expansion of macro 'min' 352 | fi->length = min(folio_size(fi->folio), fi->_seg_count); | ^~~ cc1: all warnings being treated as errors -- In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/net/sock.h:53, from include/linux/tcp.h:19, from include/linux/ipv6.h:88, from arch/sparc/kernel/sys_sparc32.c:33: include/linux/bio.h: In function 'bio_first_folio': include/linux/bio.h:338:14: error: implicit declaration of function 'page_folio' [-Werror=implicit-function-declaration] 338 | fi->folio = page_folio(bvec->bv_page); | ^~~~~~~~~~ 338 | fi->folio = page_folio(bvec->bv_page); | ^ include/linux/bio.h:340:43: error: invalid use of undefined type 'struct folio' 340 | PAGE_SIZE * (bvec->bv_page - &fi->folio->page); | ^~ In file included from include/linux/kernel.h:16, from arch/sparc/kernel/sys_sparc32.c:11: include/linux/bio.h:342:19: error: implicit declaration of function 'folio_size' [-Werror=implicit-function-declaration] 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~~~~~~~~ include/linux/minmax.h:20:21: note: in definition of macro '__typecheck' 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:342:15: note: in expansion of macro 'min' 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~ In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/net/sock.h:53, from include/linux/tcp.h:19, from include/linux/ipv6.h:88, from arch/sparc/kernel/sys_sparc32.c:33: include/linux/bio.h: In function 'bio_next_folio': include/linux/bio.h:350:15: error: implicit declaration of function 'folio_next'; did you mean 'nla_next'? [-Werror=implicit-function-declaration] 350 | fi->folio = folio_next(fi->folio); | ^~~~~~~~~~ | nla_next include/linux/bio.h:350:13: error: assignment to 'struct folio *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] 350 | fi->folio = folio_next(fi->folio); | ^ In file included from include/linux/kernel.h:16, from arch/sparc/kernel/sys_sparc32.c:11: include/linux/minmax.h:20:28: error: comparison of distinct pointer types lacks a cast [-Werror] 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/minmax.h:26:4: note: in expansion of macro '__typecheck' 26 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:352:16: note: in expansion of macro 'min' 352 | fi->length = min(folio_size(fi->folio), fi->_seg_count); | ^~~ cc1: all warnings being treated as errors vim +338 include/linux/bio.h 332 333 static inline 334 void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i) 335 { 336 struct bio_vec *bvec = bio_first_bvec_all(bio) + i; 337 339 fi->offset = bvec->bv_offset + 340 PAGE_SIZE * (bvec->bv_page - &fi->folio->page); 341 fi->_seg_count = bvec->bv_len; 342 fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); 343 fi->_i = i; 344 } 345 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org