Hi Markus, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mac80211-next/master] [also build test WARNING on mac80211/master v5.8-rc2 next-20200622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Markus-Theil/mac80211-fix-contro... base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: c6x-randconfig-s032-20200622 (attached as .config) compiler: c6x-elf-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-dirty # save the attached .config to linux build tree make W=1 C=1 ARCH=c6x CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; sparse warnings: (new ones prefixed by >>) vim +642 net/mac80211/status.c 623 624 static void ieee80211_report_ack_skb(struct ieee80211_local *local, 625 struct ieee80211_tx_info *info, 626 bool acked, bool dropped) 627 { 628 struct sk_buff *skb; 629 unsigned long flags; 630 631 spin_lock_irqsave(&local->ack_status_lock, flags); 632 skb = idr_remove(&local->ack_status_frames, info->ack_frame_id); 633 spin_unlock_irqrestore(&local->ack_status_lock, flags); 634 635 if (!skb) 636 return; 637 638 if (info->flags & IEEE80211_TX_INTFL_NL80211_FRAME_TX) { 639 u64 cookie = IEEE80211_SKB_CB(skb)->ack.cookie; 640 struct ieee80211_sub_if_data *sdata; 641 struct ieee80211_hdr *hdr = (void *)skb->data; 643 644 if (skb->len >= ETH_HLEN && skb->protocol == cpu_to_be16(ETH_P_802_3)) 645 skb_copy_bits(skb, 2 * ETH_ALEN, &ethertype, ETH_TLEN); 646 647 rcu_read_lock(); 648 sdata = ieee80211_sdata_from_skb(local, skb); 649 if (sdata) { 650 if (ethertype == sdata->control_port_protocol || 651 ethertype == cpu_to_be16(ETH_P_PREAUTH)) 652 cfg80211_control_port_tx_status(&sdata->wdev, 653 cookie, 654 skb->data, 655 skb->len, 656 acked, 657 GFP_ATOMIC); 658 else if (ieee80211_is_any_nullfunc(hdr->frame_control)) 659 cfg80211_probe_status(sdata->dev, hdr->addr1, 660 cookie, acked, 661 info->status.ack_signal, 662 info->status.is_valid_ack_signal, 663 GFP_ATOMIC); 664 else if (ieee80211_is_mgmt(hdr->frame_control)) 665 cfg80211_mgmt_tx_status(&sdata->wdev, cookie, 666 skb->data, skb->len, 667 acked, GFP_ATOMIC); 668 else 669 pr_warn("Unknown status report in ack skb\n"); 670 671 } 672 rcu_read_unlock(); 673 674 dev_kfree_skb_any(skb); 675 } else if (dropped) { 676 dev_kfree_skb_any(skb); 677 } else { 678 /* consumes skb */ 679 skb_complete_wifi_ack(skb, acked); 680 } 681 } 682 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org