[staging:staging-testing 704/705] drivers/comedi/drivers/jr3_pci.c:507:22: warning: variable 'min_full_scale' set but not used
10:44 p.m.
Hi Greg,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 71d3edc61e29e45b613b841108688d711846f969
commit: 8ffdff6a8cfbdc174a3a390b6f825a277b5bb895 [704/705] staging: comedi: move out of
staging directory
config: parisc-randconfig-r022-20210415 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit...
git remote add staging
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git fetch --no-tags staging staging-testing
git checkout 8ffdff6a8cfbdc174a3a390b6f825a277b5bb895
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/comedi/drivers/jr3_pci.c: In function 'jr3_pci_poll_subdevice':
> drivers/comedi/drivers/jr3_pci.c:507:22: warning: variable
'min_full_scale' set but not used [-Wunused-but-set-variable]
507 |
struct six_axis_t min_full_scale;
| ^~~~~~~~~~~~~~
vim +/min_full_scale +507 drivers/comedi/drivers/jr3_pci.c
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 437
d5e59c967830f9 drivers/staging/comedi/drivers/jr3_pci.c Anson Jacob 2016-08-26 438
static struct jr3_pci_poll_delay
d5e59c967830f9 drivers/staging/comedi/drivers/jr3_pci.c Anson Jacob 2016-08-26 439
jr3_pci_poll_subdevice(struct comedi_subdevice *s)
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 440
{
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 441
struct jr3_pci_subdev_private *spriv = s->private;
da1331a50315a0 drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 442
struct jr3_pci_poll_delay result = poll_delay_min_max(1000, 2000);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 443
struct jr3_sensor __iomem *sensor;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 444
u16 model_no;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 445
u16 serial_no;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 446
int errors;
b1f68dc1d61015 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2009-09-21 447
int i;
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 448
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 449
sensor = spriv->sensor;
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 450
errors = get_u16(&sensor->errors);
7803d8e05d63d7 drivers/staging/comedi/drivers/jr3_pci.c Kumar Amit Mehta 2012-11-07 451
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 452
if (errors != spriv->errors)
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 453
spriv->errors = errors;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 454
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 455
/* Sensor communication lost? force poll mode */
7803d8e05d63d7 drivers/staging/comedi/drivers/jr3_pci.c Kumar Amit Mehta 2012-11-07 456
if (errors & (watch_dog | watch_dog2 | sensor_change))
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 457
spriv->state = state_jr3_poll;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 458
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 459
switch (spriv->state) {
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 460
case state_jr3_poll:
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 461
model_no = get_u16(&sensor->model_no);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 462
serial_no = get_u16(&sensor->serial_no);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 463
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 464
if ((errors & (watch_dog | watch_dog2)) ||
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 465
model_no == 0 || serial_no == 0) {
2696fb57e6af65 drivers/staging/comedi/drivers/jr3_pci.c Bill Pemberton 2009-03-27 466
/*
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 467
* Still no sensor, keep on polling.
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 468
* Since it takes up to 10 seconds for offsets to
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 469
* stabilize, polling each second should suffice.
2696fb57e6af65 drivers/staging/comedi/drivers/jr3_pci.c Bill Pemberton 2009-03-27 470
*/
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 471
} else {
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 472
spriv->retries = 0;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 473
spriv->state = state_jr3_init_wait_for_offset;
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 474
}
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 475
break;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 476
case state_jr3_init_wait_for_offset:
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 477
spriv->retries++;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 478
if (spriv->retries < 10) {
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 479
/*
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 480
* Wait for offeset to stabilize
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 481
* (< 10 s according to manual)
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 482
*/
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 483
} else {
0a44493fb18738 drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 484
struct jr3_pci_transform transf;
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 485
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 486
spriv->model_no = get_u16(&sensor->model_no);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 487
spriv->serial_no = get_u16(&sensor->serial_no);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 488
2696fb57e6af65 drivers/staging/comedi/drivers/jr3_pci.c Bill Pemberton 2009-03-27 489
/* Transformation all zeros */
b1f68dc1d61015 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2009-09-21 490
for (i = 0; i < ARRAY_SIZE(transf.link); i++) {
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 491
transf.link[i].link_type = (enum link_types)0;
b1f68dc1d61015 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2009-09-21 492
transf.link[i].link_amount = 0;
b1f68dc1d61015 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2009-09-21 493
}
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 494
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 495
set_transforms(sensor, &transf, 0);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 496
use_transform(sensor, 0);
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 497
spriv->state = state_jr3_init_transform_complete;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 498
/* Allow 20 ms for completion */
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 499
result = poll_delay_min_max(20, 100);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 500
}
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 501
break;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 502
case state_jr3_init_transform_complete:
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 503
if (!is_complete(sensor)) {
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 504
result = poll_delay_min_max(20, 100);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 505
} else {
2696fb57e6af65 drivers/staging/comedi/drivers/jr3_pci.c Bill Pemberton 2009-03-27 506
/* Set full scale */
050509fa558306 drivers/staging/comedi/drivers/jr3_pci.c Bill Pemberton 2009-03-16 @507
struct six_axis_t min_full_scale;
050509fa558306 drivers/staging/comedi/drivers/jr3_pci.c Bill Pemberton 2009-03-16 508
struct six_axis_t max_full_scale;
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 509
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 510
min_full_scale = get_min_full_scales(sensor);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 511
max_full_scale = get_max_full_scales(sensor);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 512
set_full_scales(sensor, max_full_scale);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 513
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 514
spriv->state = state_jr3_init_set_full_scale_complete;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 515
/* Allow 20 ms for completion */
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 516
result = poll_delay_min_max(20, 100);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 517
}
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 518
break;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 519
case state_jr3_init_set_full_scale_complete:
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 520
if (!is_complete(sensor)) {
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 521
result = poll_delay_min_max(20, 100);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 522
} else {
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 523
struct force_array __iomem *fs = &sensor->full_scale;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 524
union jr3_pci_single_range *r = spriv->range;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 525
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 526
/* Use ranges in kN or we will overflow around 2000N! */
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 527
r[0].l.range[0].min = -get_s16(&fs->fx) * 1000;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 528
r[0].l.range[0].max = get_s16(&fs->fx) * 1000;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 529
r[1].l.range[0].min = -get_s16(&fs->fy) * 1000;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 530
r[1].l.range[0].max = get_s16(&fs->fy) * 1000;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 531
r[2].l.range[0].min = -get_s16(&fs->fz) * 1000;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 532
r[2].l.range[0].max = get_s16(&fs->fz) * 1000;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 533
r[3].l.range[0].min = -get_s16(&fs->mx) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 534
r[3].l.range[0].max = get_s16(&fs->mx) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 535
r[4].l.range[0].min = -get_s16(&fs->my) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 536
r[4].l.range[0].max = get_s16(&fs->my) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 537
r[5].l.range[0].min = -get_s16(&fs->mz) * 100;
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 538
/* the next five are questionable */
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 539
r[5].l.range[0].max = get_s16(&fs->mz) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 540
r[6].l.range[0].min = -get_s16(&fs->v1) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 541
r[6].l.range[0].max = get_s16(&fs->v1) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 542
r[7].l.range[0].min = -get_s16(&fs->v2) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 543
r[7].l.range[0].max = get_s16(&fs->v2) * 100;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 544
r[8].l.range[0].min = 0;
4af8c8195188b5 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-02-17 545
r[8].l.range[0].max = 65535;
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 546
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 547
use_offset(sensor, 0);
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 548
spriv->state = state_jr3_init_use_offset_complete;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 549
/* Allow 40 ms for completion */
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 550
result = poll_delay_min_max(40, 100);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 551
}
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 552
break;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 553
case state_jr3_init_use_offset_complete:
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 554
if (!is_complete(sensor)) {
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 555
result = poll_delay_min_max(20, 100);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 556
} else {
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 557
set_s16(&sensor->offsets.fx, 0);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 558
set_s16(&sensor->offsets.fy, 0);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 559
set_s16(&sensor->offsets.fz, 0);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 560
set_s16(&sensor->offsets.mx, 0);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 561
set_s16(&sensor->offsets.my, 0);
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 562
set_s16(&sensor->offsets.mz, 0);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 563
713eab88c66de4 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2017-03-08 564
set_offset(sensor);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 565
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 566
spriv->state = state_jr3_done;
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 567
}
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 568
break;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 569
case state_jr3_done:
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 570
result = poll_delay_min_max(10000, 20000);
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 571
break;
abcdc99f7cb387 drivers/staging/comedi/drivers/jr3_pci.c Ian Abbott 2012-11-01 572
default:
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 573
break;
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 574
}
01fca4732b98ab drivers/staging/comedi/drivers/jr3_pci.c H Hartley Sweeten 2014-03-07 575
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 576
return result;
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 577
}
07b509e6584a55 drivers/staging/comedi/drivers/jr3_pci.c Anders Blomdell 2009-02-12 578
:::::: The code at line 507 was first introduced by commit
:::::: 050509fa558306399f2a987956514a8f849846ef Staging: comedi: Remove six_axis_t
typedef
:::::: TO: Bill Pemberton <wfp5p(a)virginia.edu>
:::::: CC: Greg Kroah-Hartman <gregkh(a)suse.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
523
days inactive
523
days old
0 comments
1 participants
participants (1)
-
kernel test robot