Hi Atish,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.8-rc5 next-20200717]
[cannot apply to efi/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Atish-Patra/Add-UEFI-support-for...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68
config: riscv-rv32_defconfig (attached as .config)
compiler: riscv32-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/firmware/efi/libstub/riscv-stub.c:59:17: warning: no
previous prototype for 'efi_enter_kernel' [-Wmissing-prototypes]
59 |
void __noreturn efi_enter_kernel(unsigned long entrypoint, unsigned long fdt,
| ^~~~~~~~~~~~~~~~
> drivers/firmware/efi/libstub/riscv-stub.c:76:14: warning: no
previous prototype for 'handle_kernel_image' [-Wmissing-prototypes]
76
| efi_status_t handle_kernel_image(unsigned long *image_addr,
| ^~~~~~~~~~~~~~~~~~~
vim +/efi_enter_kernel +59 drivers/firmware/efi/libstub/riscv-stub.c
58
59 void __noreturn efi_enter_kernel(unsigned long entrypoint,
unsigned long fdt,
60 unsigned long fdt_size)
61 {
62 unsigned long stext_offset = _start_kernel - _start;
63 unsigned long kernel_entry = entrypoint + stext_offset;
64 jump_kernel_func jump_kernel = (jump_kernel_func)kernel_entry;
65
66 /*
67 * Jump to real kernel here with following constraints.
68 * 1. MMU should be disabled.
69 * 2. a0 should contain hartid
70 * 3. a1 should DT address
71 */
72 csr_write(CSR_SATP, 0);
73 jump_kernel(hartid, fdt);
74 }
75
76 efi_status_t handle_kernel_image(unsigned long *image_addr,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org