Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20200915]
[cannot apply to drm-intel/for-linux-next arm/drm-armada-devel linus/master
arm/drm-armada-fixes anholt/for-next v5.9-rc5 v5.9-rc4 v5.9-rc3 v5.9-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/Convert-all-re...
base: 6b02addb1d1748d21dd1261e46029b264be4e5a0
config: arm64-randconfig-r015-20200916 (attached as .config)
compiler: clang version 12.0.0 (
https://github.com/llvm/llvm-project
9e3842d60351f986d77dfe0a94f76e4fd895f188)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
> drivers/gpu/drm/imx/dcss/dcss-kms.c:31:3: error: field designator
'gem_free_object_unlocked' does not refer to any field in type 'struct
drm_driver'
.gem_free_object_unlocked = drm_gem_cma_free_object,
^
> drivers/gpu/drm/imx/dcss/dcss-kms.c:32:3: error: field designator
'gem_vm_ops' does not refer to any field in type 'struct drm_driver'
.gem_vm_ops = &drm_gem_cma_vm_ops,
^
> drivers/gpu/drm/imx/dcss/dcss-kms.c:38:3: error: field designator
'gem_prime_export' does not refer to any field in type 'struct
drm_driver'; did you mean 'gem_prime_import'?
.gem_prime_export = drm_gem_prime_export,
^~~~~~~~~~~~~~~~
gem_prime_import
include/drm/drm_drv.h:370:28: note: 'gem_prime_import' declared here
struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
^
> drivers/gpu/drm/imx/dcss/dcss-kms.c:38:22: error: incompatible
function pointer types initializing 'struct drm_gem_object *(*)(struct drm_device *,
struct dma_buf *)' with an expression of type 'struct dma_buf *(struct
drm_gem_object *, int)' [-Werror,-Wincompatible-function-pointer-types]
.gem_prime_export = drm_gem_prime_export,
^~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/imx/dcss/dcss-kms.c:38:22: warning: initializer
overrides prior initialization of this subobject [-Winitializer-overrides]
.gem_prime_export = drm_gem_prime_export,
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imx/dcss/dcss-kms.c:37:22: note: previous initialization is here
.gem_prime_import = drm_gem_prime_import,
^~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/imx/dcss/dcss-kms.c:39:3: error: field designator
'gem_prime_get_sg_table' does not refer to any field in type 'struct
drm_driver'; did you mean 'gem_prime_import_sg_table'?
.gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
^~~~~~~~~~~~~~~~~~~~~~
gem_prime_import_sg_table
include/drm/drm_drv.h:378:27: note: 'gem_prime_import_sg_table' declared here
struct drm_gem_object *(*gem_prime_import_sg_table)(
^
> drivers/gpu/drm/imx/dcss/dcss-kms.c:39:28: error: incompatible
function pointer types initializing 'struct drm_gem_object *(*)(struct drm_device *,
struct dma_buf_attachment *, struct sg_table *)' with an expression of type
'struct sg_table *(struct drm_gem_object *)'
[-Werror,-Wincompatible-function-pointer-types]
.gem_prime_get_sg_table =
drm_gem_cma_prime_get_sg_table,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imx/dcss/dcss-kms.c:40:31: warning: initializer overrides prior
initialization of this subobject [-Winitializer-overrides]
.gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imx/dcss/dcss-kms.c:39:28: note: previous initialization is here
.gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/imx/dcss/dcss-kms.c:41:3: error: field designator
'gem_prime_vmap' does not refer to any field in type 'struct drm_driver';
did you mean 'gem_prime_mmap'?
.gem_prime_vmap =
drm_gem_cma_prime_vmap,
^~~~~~~~~~~~~~
gem_prime_mmap
include/drm/drm_drv.h:391:8: note: 'gem_prime_mmap' declared here
int (*gem_prime_mmap)(struct drm_gem_object *obj,
^
> drivers/gpu/drm/imx/dcss/dcss-kms.c:41:21: error: incompatible
function pointer types initializing 'int (*)(struct drm_gem_object *, struct
vm_area_struct *)' with an expression of type 'void *(struct drm_gem_object
*)' [-Werror,-Wincompatible-function-pointer-types]
.gem_prime_vmap
= drm_gem_cma_prime_vmap,
^~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/imx/dcss/dcss-kms.c:42:3: error: field designator
'gem_prime_vunmap' does not refer to any field in type 'struct
drm_driver'; did you mean 'gem_prime_mmap'?
.gem_prime_vunmap
= drm_gem_cma_prime_vunmap,
^~~~~~~~~~~~~~~~
gem_prime_mmap
include/drm/drm_drv.h:391:8: note: 'gem_prime_mmap' declared here
int (*gem_prime_mmap)(struct drm_gem_object *obj,
^
drivers/gpu/drm/imx/dcss/dcss-kms.c:42:22: error: incompatible function pointer types
initializing 'int (*)(struct drm_gem_object *, struct vm_area_struct *)' with an
expression of type 'void (struct drm_gem_object *, void *)'
[-Werror,-Wincompatible-function-pointer-types]
.gem_prime_vunmap = drm_gem_cma_prime_vunmap,
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imx/dcss/dcss-kms.c:42:22: warning: initializer overrides prior
initialization of this subobject [-Winitializer-overrides]
.gem_prime_vunmap = drm_gem_cma_prime_vunmap,
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imx/dcss/dcss-kms.c:41:21: note: previous initialization is here
.gem_prime_vmap = drm_gem_cma_prime_vmap,
^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imx/dcss/dcss-kms.c:43:21: warning: initializer overrides prior
initialization of this subobject [-Winitializer-overrides]
.gem_prime_mmap = drm_gem_cma_prime_mmap,
^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imx/dcss/dcss-kms.c:42:22: note: previous initialization is here
.gem_prime_vunmap = drm_gem_cma_prime_vunmap,
^~~~~~~~~~~~~~~~~~~~~~~~
4 warnings and 10 errors generated.
#
https://github.com/0day-ci/linux/commit/84300c9d089d60d5dc528a7bd6e287009...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Thomas-Zimmermann/Convert-all-remaining-drivers-to-GEM-object-functions/20200915-230157
git checkout 84300c9d089d60d5dc528a7bd6e2870090201f0e
vim +31 drivers/gpu/drm/imx/dcss/dcss-kms.c
9021c317b77024f Laurentiu Palcu 2020-07-31 28
9021c317b77024f Laurentiu Palcu 2020-07-31 29 static struct drm_driver dcss_kms_driver =
{
9021c317b77024f Laurentiu Palcu 2020-07-31 30 .driver_features = DRIVER_MODESET |
DRIVER_GEM | DRIVER_ATOMIC,
9021c317b77024f Laurentiu Palcu 2020-07-31 @31 .gem_free_object_unlocked =
drm_gem_cma_free_object,
9021c317b77024f Laurentiu Palcu 2020-07-31 @32 .gem_vm_ops = &drm_gem_cma_vm_ops,
9021c317b77024f Laurentiu Palcu 2020-07-31 33 .dumb_create = drm_gem_cma_dumb_create,
9021c317b77024f Laurentiu Palcu 2020-07-31 34
9021c317b77024f Laurentiu Palcu 2020-07-31 35 .prime_handle_to_fd =
drm_gem_prime_handle_to_fd,
9021c317b77024f Laurentiu Palcu 2020-07-31 36 .prime_fd_to_handle =
drm_gem_prime_fd_to_handle,
9021c317b77024f Laurentiu Palcu 2020-07-31 37 .gem_prime_import =
drm_gem_prime_import,
9021c317b77024f Laurentiu Palcu 2020-07-31 @38 .gem_prime_export =
drm_gem_prime_export,
9021c317b77024f Laurentiu Palcu 2020-07-31 @39 .gem_prime_get_sg_table =
drm_gem_cma_prime_get_sg_table,
9021c317b77024f Laurentiu Palcu 2020-07-31 40 .gem_prime_import_sg_table =
drm_gem_cma_prime_import_sg_table,
9021c317b77024f Laurentiu Palcu 2020-07-31 @41 .gem_prime_vmap =
drm_gem_cma_prime_vmap,
9021c317b77024f Laurentiu Palcu 2020-07-31 @42 .gem_prime_vunmap =
drm_gem_cma_prime_vunmap,
9021c317b77024f Laurentiu Palcu 2020-07-31 43 .gem_prime_mmap =
drm_gem_cma_prime_mmap,
9021c317b77024f Laurentiu Palcu 2020-07-31 44 .fops = &dcss_cma_fops,
9021c317b77024f Laurentiu Palcu 2020-07-31 45 .name = "imx-dcss",
9021c317b77024f Laurentiu Palcu 2020-07-31 46 .desc = "i.MX8MQ Display
Subsystem",
9021c317b77024f Laurentiu Palcu 2020-07-31 47 .date = "20190917",
9021c317b77024f Laurentiu Palcu 2020-07-31 48 .major = 1,
9021c317b77024f Laurentiu Palcu 2020-07-31 49 .minor = 0,
9021c317b77024f Laurentiu Palcu 2020-07-31 50 .patchlevel = 0,
9021c317b77024f Laurentiu Palcu 2020-07-31 51 };
9021c317b77024f Laurentiu Palcu 2020-07-31 52
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org