tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.tmp2 head: adcceb5eb7aee38e4a9c15bdf599655f0e1b1324 commit: 80b4a6d3c8c2325e072a36e473706f5165e0e9fb [348/364] sched/headers, locking/mutexes: Optimize <linux/mutex.h> header dependencies config: x86_64-rhel-8.3 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=80... git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git git fetch --no-tags tip tmp.tmp2 git checkout 80b4a6d3c8c2325e072a36e473706f5165e0e9fb # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): In file included from kernel/sysctl-test.c:6: include/kunit/test.h: In function 'kunit_resource_name_match': 503 | return res->name && strcmp(res->name, match_name) == 0; | ^~~~~~ include/kunit/test.h: In function 'kunit_find_resource': include/kunit/test.h:519:2: error: implicit declaration of function 'spin_lock' [-Werror=implicit-function-declaration] 519 | spin_lock(&test->lock); | ^~~~~~~~~ include/kunit/test.h:529:2: error: implicit declaration of function 'spin_unlock' [-Werror=implicit-function-declaration] 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ kernel/sysctl-test.c: In function 'sysctl_test_api_dointvec_null_tbl_data': include/kunit/test.h:778:9: error: implicit declaration of function '__typecheck'; did you mean 'typecheck'? [-Werror=implicit-function-declaration] 778 | ((void)__typecheck(__left, __right)); \ | ^~~~~~~~~~~ include/kunit/test.h:802:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION' 802 | KUNIT_BASE_BINARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:891:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION' 891 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:901:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION' 901 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1264:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION' 1264 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right) | ^~~~~~~~~~~~~~~~~~~~~~~~~ kernel/sysctl-test.c:49:2: note: in expansion of macro 'KUNIT_EXPECT_EQ' 49 | KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&null_data_table, | ^~~~~~~~~~~~~~~ kernel/sysctl-test.c: In function 'sysctl_test_dointvec_write_happy_single_positive': 263 | memcpy(buffer, input, len); | ^~~~~~ kernel/sysctl-test.c:8:1: note: include '<string.h>' or provide a declaration of 'memcpy' 7 | #include <linux/sysctl.h> +++ |+#include <string.h> 8 | kernel/sysctl-test.c: In function 'sysctl_test_dointvec_write_happy_single_negative': kernel/sysctl-test.c:293:2: warning: incompatible implicit declaration of built-in function 'memcpy' 293 | memcpy(buffer, input, len); | ^~~~~~ kernel/sysctl-test.c:293:2: note: include '<string.h>' or provide a declaration of 'memcpy' cc1: some warnings being treated as errors -- In file included from lib/list-test.c:8: include/kunit/test.h: In function 'kunit_resource_name_match': 503 | return res->name && strcmp(res->name, match_name) == 0; | ^~~~~~ include/kunit/test.h: In function 'kunit_find_resource': include/kunit/test.h:519:2: error: implicit declaration of function 'spin_lock' [-Werror=implicit-function-declaration] 519 | spin_lock(&test->lock); | ^~~~~~~~~ include/kunit/test.h:529:2: error: implicit declaration of function 'spin_unlock' [-Werror=implicit-function-declaration] 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ lib/list-test.c: In function 'list_test_list_init': 32 | memset(list5, 0xFF, sizeof(*list5)); | ^~~~~~ lib/list-test.c:9:1: note: include '<string.h>' or provide a declaration of 'memset' 8 | #include <kunit/test.h> +++ |+#include <string.h> 9 | In file included from lib/list-test.c:8: lib/list-test.c: In function 'list_test_list_add': include/kunit/test.h:778:9: error: implicit declaration of function '__typecheck'; did you mean 'typecheck'? [-Werror=implicit-function-declaration] 778 | ((void)__typecheck(__left, __right)); \ | ^~~~~~~~~~~ include/kunit/test.h:802:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION' 802 | KUNIT_BASE_BINARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:913:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION' 913 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:923:2: note: in expansion of macro 'KUNIT_BINARY_PTR_EQ_MSG_ASSERTION' 923 | KUNIT_BINARY_PTR_EQ_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1286:2: note: in expansion of macro 'KUNIT_BINARY_PTR_EQ_ASSERTION' 1286 | KUNIT_BINARY_PTR_EQ_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/list-test.c:55:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ' 55 | KUNIT_EXPECT_PTR_EQ(test, list.next, &b); | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from lib/kunit/kunit-test.c:8: include/kunit/test.h: In function 'kunit_resource_name_match': 503 | return res->name && strcmp(res->name, match_name) == 0; | ^~~~~~ include/kunit/test.h: In function 'kunit_find_resource': include/kunit/test.h:519:2: error: implicit declaration of function 'spin_lock' [-Werror=implicit-function-declaration] 519 | spin_lock(&test->lock); | ^~~~~~~~~ include/kunit/test.h:529:2: error: implicit declaration of function 'spin_unlock' [-Werror=implicit-function-declaration] 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ lib/kunit/kunit-test.c: In function 'kunit_resource_test_alloc_resource': include/kunit/test.h:778:9: error: implicit declaration of function '__typecheck'; did you mean 'typecheck'? [-Werror=implicit-function-declaration] 778 | ((void)__typecheck(__left, __right)); \ | ^~~~~~~~~~~ include/kunit/test.h:802:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION' 802 | KUNIT_BASE_BINARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:913:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION' 913 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:923:2: note: in expansion of macro 'KUNIT_BINARY_PTR_EQ_MSG_ASSERTION' 923 | KUNIT_BINARY_PTR_EQ_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1286:2: note: in expansion of macro 'KUNIT_BINARY_PTR_EQ_ASSERTION' 1286 | KUNIT_BINARY_PTR_EQ_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/kunit-test.c:155:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ' 155 | KUNIT_EXPECT_PTR_EQ(test, | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from lib/kunit/kunit-example-test.c:9: include/kunit/test.h: In function 'kunit_resource_name_match': 503 | return res->name && strcmp(res->name, match_name) == 0; | ^~~~~~ include/kunit/test.h: In function 'kunit_find_resource': include/kunit/test.h:519:2: error: implicit declaration of function 'spin_lock' [-Werror=implicit-function-declaration] 519 | spin_lock(&test->lock); | ^~~~~~~~~ include/kunit/test.h:529:2: error: implicit declaration of function 'spin_unlock' [-Werror=implicit-function-declaration] 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ lib/kunit/kunit-example-test.c: In function 'example_simple_test': include/kunit/test.h:778:9: error: implicit declaration of function '__typecheck'; did you mean 'typecheck'? [-Werror=implicit-function-declaration] 778 | ((void)__typecheck(__left, __right)); \ | ^~~~~~~~~~~ include/kunit/test.h:802:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION' 802 | KUNIT_BASE_BINARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:891:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION' 891 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:901:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION' 901 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1264:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION' 1264 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right) | ^~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/kunit-example-test.c:29:2: note: in expansion of macro 'KUNIT_EXPECT_EQ' 29 | KUNIT_EXPECT_EQ(test, 1 + 1, 2); | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from lib/kunit/test.c:9: include/kunit/test.h: In function 'kunit_resource_name_match': 503 | return res->name && strcmp(res->name, match_name) == 0; | ^~~~~~ include/kunit/test.h: In function 'kunit_find_resource': include/kunit/test.h:519:2: error: implicit declaration of function 'spin_lock' [-Werror=implicit-function-declaration] 519 | spin_lock(&test->lock); | ^~~~~~~~~ include/kunit/test.h:529:2: error: implicit declaration of function 'spin_unlock' [-Werror=implicit-function-declaration] 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ In file included from lib/kunit/string-stream.h:12, from lib/kunit/test.c:17: include/linux/spinlock.h: At top level: include/linux/spinlock.h:312:29: warning: conflicting types for 'spin_lock' 312 | static __always_inline void spin_lock(spinlock_t *lock) | ^~~~~~~~~ include/linux/spinlock.h:312:29: error: static declaration of 'spin_lock' follows non-static declaration In file included from lib/kunit/test.c:9: include/kunit/test.h:519:2: note: previous implicit declaration of 'spin_lock' was here 519 | spin_lock(&test->lock); | ^~~~~~~~~ In file included from lib/kunit/string-stream.h:12, from lib/kunit/test.c:17: include/linux/spinlock.h:352:29: warning: conflicting types for 'spin_unlock' 352 | static __always_inline void spin_unlock(spinlock_t *lock) | ^~~~~~~~~~~ include/linux/spinlock.h:352:29: error: static declaration of 'spin_unlock' follows non-static declaration In file included from lib/kunit/test.c:9: include/kunit/test.h:529:2: note: previous implicit declaration of 'spin_unlock' was here 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ lib/kunit/test.c: In function 'kunit_log_append': lib/kunit/test.c:72:2: warning: function 'kunit_log_append' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 72 | vsnprintf(line, sizeof(line), fmt, args); | ^~~~~~~~~ cc1: some warnings being treated as errors -- In file included from lib/kunit/string-stream.c:9: include/kunit/test.h: In function 'kunit_resource_name_match': 503 | return res->name && strcmp(res->name, match_name) == 0; | ^~~~~~ include/kunit/test.h: In function 'kunit_find_resource': include/kunit/test.h:519:2: error: implicit declaration of function 'spin_lock' [-Werror=implicit-function-declaration] 519 | spin_lock(&test->lock); | ^~~~~~~~~ include/kunit/test.h:529:2: error: implicit declaration of function 'spin_unlock' [-Werror=implicit-function-declaration] 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ In file included from lib/kunit/string-stream.h:12, from lib/kunit/string-stream.c:13: include/linux/spinlock.h: At top level: include/linux/spinlock.h:312:29: warning: conflicting types for 'spin_lock' 312 | static __always_inline void spin_lock(spinlock_t *lock) | ^~~~~~~~~ include/linux/spinlock.h:312:29: error: static declaration of 'spin_lock' follows non-static declaration In file included from lib/kunit/string-stream.c:9: include/kunit/test.h:519:2: note: previous implicit declaration of 'spin_lock' was here 519 | spin_lock(&test->lock); | ^~~~~~~~~ In file included from lib/kunit/string-stream.h:12, from lib/kunit/string-stream.c:13: include/linux/spinlock.h:352:29: warning: conflicting types for 'spin_unlock' 352 | static __always_inline void spin_unlock(spinlock_t *lock) | ^~~~~~~~~~~ include/linux/spinlock.h:352:29: error: static declaration of 'spin_unlock' follows non-static declaration In file included from lib/kunit/string-stream.c:9: include/kunit/test.h:529:2: note: previous implicit declaration of 'spin_unlock' was here 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ lib/kunit/string-stream.c: In function 'string_stream_vadd': lib/kunit/string-stream.c:85:2: warning: function 'string_stream_vadd' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 85 | len = vsnprintf(NULL, 0, fmt, args_for_counting) + 1; | ^~~ lib/kunit/string-stream.c:95:2: warning: function 'string_stream_vadd' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 95 | len = vsnprintf(frag_container->fragment, len, fmt, args); | ^~~ cc1: some warnings being treated as errors -- In file included from lib/kunit/assert.c:9: include/kunit/test.h: In function 'kunit_resource_name_match': 503 | return res->name && strcmp(res->name, match_name) == 0; | ^~~~~~ include/kunit/test.h: In function 'kunit_find_resource': include/kunit/test.h:519:2: error: implicit declaration of function 'spin_lock' [-Werror=implicit-function-declaration] 519 | spin_lock(&test->lock); | ^~~~~~~~~ include/kunit/test.h:529:2: error: implicit declaration of function 'spin_unlock' [-Werror=implicit-function-declaration] 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ In file included from lib/kunit/string-stream.h:12, from lib/kunit/assert.c:11: include/linux/spinlock.h: At top level: include/linux/spinlock.h:312:29: warning: conflicting types for 'spin_lock' 312 | static __always_inline void spin_lock(spinlock_t *lock) | ^~~~~~~~~ include/linux/spinlock.h:312:29: error: static declaration of 'spin_lock' follows non-static declaration In file included from lib/kunit/assert.c:9: include/kunit/test.h:519:2: note: previous implicit declaration of 'spin_lock' was here 519 | spin_lock(&test->lock); | ^~~~~~~~~ In file included from lib/kunit/string-stream.h:12, from lib/kunit/assert.c:11: include/linux/spinlock.h:352:29: warning: conflicting types for 'spin_unlock' 352 | static __always_inline void spin_unlock(spinlock_t *lock) | ^~~~~~~~~~~ include/linux/spinlock.h:352:29: error: static declaration of 'spin_unlock' follows non-static declaration In file included from lib/kunit/assert.c:9: include/kunit/test.h:529:2: note: previous implicit declaration of 'spin_unlock' was here 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from lib/kunit/try-catch.c:10: include/kunit/test.h: In function 'kunit_resource_name_match': 503 | return res->name && strcmp(res->name, match_name) == 0; | ^~~~~~ include/kunit/test.h: In function 'kunit_find_resource': include/kunit/test.h:519:2: error: implicit declaration of function 'spin_lock' [-Werror=implicit-function-declaration] 519 | spin_lock(&test->lock); | ^~~~~~~~~ include/kunit/test.h:529:2: error: implicit declaration of function 'spin_unlock' [-Werror=implicit-function-declaration] 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ In file included from include/linux/swait.h:7, from include/linux/completion.h:12, from lib/kunit/try-catch.c:11: include/linux/spinlock.h: At top level: include/linux/spinlock.h:312:29: warning: conflicting types for 'spin_lock' 312 | static __always_inline void spin_lock(spinlock_t *lock) | ^~~~~~~~~ include/linux/spinlock.h:312:29: error: static declaration of 'spin_lock' follows non-static declaration In file included from lib/kunit/try-catch.c:10: include/kunit/test.h:519:2: note: previous implicit declaration of 'spin_lock' was here 519 | spin_lock(&test->lock); | ^~~~~~~~~ In file included from include/linux/swait.h:7, from include/linux/completion.h:12, from lib/kunit/try-catch.c:11: include/linux/spinlock.h:352:29: warning: conflicting types for 'spin_unlock' 352 | static __always_inline void spin_unlock(spinlock_t *lock) | ^~~~~~~~~~~ include/linux/spinlock.h:352:29: error: static declaration of 'spin_unlock' follows non-static declaration In file included from lib/kunit/try-catch.c:10: include/kunit/test.h:529:2: note: previous implicit declaration of 'spin_unlock' was here 529 | spin_unlock(&test->lock); | ^~~~~~~~~~~ In file included from lib/kunit/try-catch.c:13: lib/kunit/try-catch.c: In function 'kunit_try_catch_run': include/linux/kthread.h:28:41: error: 'NUMA_NO_NODE' undeclared (first use in this function) 28 | kthread_create_on_node(threadfn, data, NUMA_NO_NODE, namefmt, ##arg) | ^~~~~~~~~~~~ include/linux/kthread.h:53:5: note: in expansion of macro 'kthread_create' 53 | = kthread_create(threadfn, data, namefmt, ## __VA_ARGS__); \ | ^~~~~~~~~~~~~~ lib/kunit/try-catch.c:68:16: note: in expansion of macro 'kthread_run' 68 | task_struct = kthread_run(kunit_generic_run_threadfn_adapter, | ^~~~~~~~~~~ include/linux/kthread.h:28:41: note: each undeclared identifier is reported only once for each function it appears in 28 | kthread_create_on_node(threadfn, data, NUMA_NO_NODE, namefmt, ##arg) | ^~~~~~~~~~~~ include/linux/kthread.h:53:5: note: in expansion of macro 'kthread_create' 53 | = kthread_create(threadfn, data, namefmt, ## __VA_ARGS__); \ | ^~~~~~~~~~~~~~ lib/kunit/try-catch.c:68:16: note: in expansion of macro 'kthread_run' 68 | task_struct = kthread_run(kunit_generic_run_threadfn_adapter, | ^~~~~~~~~~~ include/linux/kthread.h:55:3: error: implicit declaration of function 'wake_up_process'; did you mean 'wake_up_poll'? [-Werror=implicit-function-declaration] 55 | wake_up_process(__k); \ | ^~~~~~~~~~~~~~~ lib/kunit/try-catch.c:68:16: note: in expansion of macro 'kthread_run' 68 | task_struct = kthread_run(kunit_generic_run_threadfn_adapter, | ^~~~~~~~~~~ cc1: some warnings being treated as errors .. vim +/strcmp +503 include/kunit/test.h d4cdd146d0db90 Alan Maguire 2020-05-29 492 725aca95859566 Alan Maguire 2020-05-29 493 /** 725aca95859566 Alan Maguire 2020-05-29 494 * kunit_resource_name_match() - Match a resource with the same name. 725aca95859566 Alan Maguire 2020-05-29 495 * @test: Test case to which the resource belongs. 725aca95859566 Alan Maguire 2020-05-29 496 * @res: The resource. 725aca95859566 Alan Maguire 2020-05-29 497 * @match_name: The name to match against. 725aca95859566 Alan Maguire 2020-05-29 498 */ 725aca95859566 Alan Maguire 2020-05-29 499 static inline bool kunit_resource_name_match(struct kunit *test, 725aca95859566 Alan Maguire 2020-05-29 500 struct kunit_resource *res, 725aca95859566 Alan Maguire 2020-05-29 501 void *match_name) 725aca95859566 Alan Maguire 2020-05-29 502 { 725aca95859566 Alan Maguire 2020-05-29 @503 return res->name && strcmp(res->name, match_name) == 0; 725aca95859566 Alan Maguire 2020-05-29 504 } 725aca95859566 Alan Maguire 2020-05-29 505 :::::: The code at line 503 was first introduced by commit :::::: 725aca9585956676687c4cb803e88f770b0df2b2 kunit: add support for named resources :::::: TO: Alan Maguire <alan.maguire(a)oracle.com&gt; :::::: CC: Shuah Khan <skhan(a)linuxfoundation.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org