11:27 p.m.
Hi "Linus,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mac80211-next/master]
[also build test WARNING on mac80211/master v5.8-rc1 next-20200616]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Linus-L-ssing/mac80211-mesh-add-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: arm64-randconfig-s031-20200615 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-rc1-3-g55607964-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=arm64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> net/wireless/nl80211.c:7099:9: sparse: sparse: macro
"FILL_IN_MESH_PARAM_IF_SET" passed 8 arguments, but takes just 6
net/wireless/nl80211.c:7099:9: sparse: sparse: undefined identifier
'FILL_IN_MESH_PARAM_IF_SET'
# https://github.com/0day-ci/linux/commit/d86bcd2b4a9457a527e9c5dd610ad12c0...
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout d86bcd2b4a9457a527e9c5dd610ad12c07d386a4
vim +/FILL_IN_MESH_PARAM_IF_SET +7099 net/wireless/nl80211.c
bd90fdcc5fbd99 Johannes Berg 2010-12-03 6979
24bdd9f4c9af75 Javier Cardona 2010-12-16 6980 if
(!info->attrs[NL80211_ATTR_MESH_CONFIG])
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 6981 return -EINVAL;
8cb081746c031f Johannes Berg 2019-04-26 6982 if (nla_parse_nested_deprecated(tb,
NL80211_MESHCONF_ATTR_MAX, info->attrs[NL80211_ATTR_MESH_CONFIG],
nl80211_meshconf_params_policy, info->extack))
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 6983 return -EINVAL;
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 6984
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 6985 /* This makes sure that there
aren't more than 32 mesh config
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 6986 * parameters (otherwise our bitfield
scheme would not work.) */
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 6987 BUILD_BUG_ON(NL80211_MESHCONF_ATTR_MAX
> 32);
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 6988
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 6989 /* Fill in the params struct */
ab0d76f6823cc3 Johannes Berg 2018-10-02 6990 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshRetryTimeout, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 6991 NL80211_MESHCONF_RETRY_TIMEOUT,
nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 6992 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshConfirmTimeout, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 6993
NL80211_MESHCONF_CONFIRM_TIMEOUT,
ab0d76f6823cc3 Johannes Berg 2018-10-02 6994 nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 6995 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHoldingTimeout, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 6996
NL80211_MESHCONF_HOLDING_TIMEOUT,
ab0d76f6823cc3 Johannes Berg 2018-10-02 6997 nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 6998 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshMaxPeerLinks, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 6999 NL80211_MESHCONF_MAX_PEER_LINKS,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7000 nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7001 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshMaxRetries, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7002 NL80211_MESHCONF_MAX_RETRIES,
nla_get_u8);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7003 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshTTL, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7004 NL80211_MESHCONF_TTL,
nla_get_u8);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7005 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
element_ttl, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7006 NL80211_MESHCONF_ELEMENT_TTL,
nla_get_u8);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7007 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
auto_open_plinks, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7008
NL80211_MESHCONF_AUTO_OPEN_PLINKS,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7009 nla_get_u8);
ea54fba20985b7 Marco Porsch 2013-01-07 7010 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshNbrOffsetMaxNeighbor,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7011 mask,
a4f606ea73d56d Chun-Yeow Yeoh 2012-06-11 7012
NL80211_MESHCONF_SYNC_OFFSET_MAX_NEIGHBOR,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7013 nla_get_u32);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7014 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHWMPmaxPREQretries, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7015
NL80211_MESHCONF_HWMP_MAX_PREQ_RETRIES,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7016 nla_get_u8);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7017 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
path_refresh_time, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7018
NL80211_MESHCONF_PATH_REFRESH_TIME,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7019 nla_get_u32);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7020 if (mask &
BIT(NL80211_MESHCONF_PATH_REFRESH_TIME) &&
ab0d76f6823cc3 Johannes Berg 2018-10-02 7021 (cfg->path_refresh_time < 1
|| cfg->path_refresh_time > 65535))
ab0d76f6823cc3 Johannes Berg 2018-10-02 7022 return -EINVAL;
ab0d76f6823cc3 Johannes Berg 2018-10-02 7023 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
min_discovery_timeout, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7024
NL80211_MESHCONF_MIN_DISCOVERY_TIMEOUT,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7025 nla_get_u16);
ea54fba20985b7 Marco Porsch 2013-01-07 7026 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHWMPactivePathTimeout,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7027 mask,
a4f606ea73d56d Chun-Yeow Yeoh 2012-06-11 7028
NL80211_MESHCONF_HWMP_ACTIVE_PATH_TIMEOUT,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7029 nla_get_u32);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7030 if (mask &
BIT(NL80211_MESHCONF_HWMP_ACTIVE_PATH_TIMEOUT) &&
ab0d76f6823cc3 Johannes Berg 2018-10-02 7031
(cfg->dot11MeshHWMPactivePathTimeout < 1 ||
ab0d76f6823cc3 Johannes Berg 2018-10-02 7032
cfg->dot11MeshHWMPactivePathTimeout > 65535))
ab0d76f6823cc3 Johannes Berg 2018-10-02 7033 return -EINVAL;
ab0d76f6823cc3 Johannes Berg 2018-10-02 7034 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHWMPpreqMinInterval, mask,
ea54fba20985b7 Marco Porsch 2013-01-07 7035
NL80211_MESHCONF_HWMP_PREQ_MIN_INTERVAL,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7036 nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7037 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHWMPperrMinInterval, mask,
ea54fba20985b7 Marco Porsch 2013-01-07 7038
NL80211_MESHCONF_HWMP_PERR_MIN_INTERVAL,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7039 nla_get_u16);
93da9cc17c5ae8 colin(a)cozybit.com 2008-10-21 7040 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7041
dot11MeshHWMPnetDiameterTraversalTime, mask,
a4f606ea73d56d Chun-Yeow Yeoh 2012-06-11 7042
NL80211_MESHCONF_HWMP_NET_DIAM_TRVS_TIME,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7043 nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7044 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHWMPRootMode, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7045 NL80211_MESHCONF_HWMP_ROOTMODE,
nla_get_u8);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7046 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHWMPRannInterval, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7047
NL80211_MESHCONF_HWMP_RANN_INTERVAL,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7048 nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7049 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshGateAnnouncementProtocol,
ea54fba20985b7 Marco Porsch 2013-01-07 7050 mask,
NL80211_MESHCONF_GATE_ANNOUNCEMENTS,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7051 nla_get_u8);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7052 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshForwarding, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7053 NL80211_MESHCONF_FORWARDING,
nla_get_u8);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7054 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
rssi_threshold, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7055 NL80211_MESHCONF_RSSI_THRESHOLD,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7056 nla_get_s32);
01d66fbd5b18ac Bob Copeland 2018-10-25 7057 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshConnectedToMeshGate, mask,
01d66fbd5b18ac Bob Copeland 2018-10-25 7058
NL80211_MESHCONF_CONNECTED_TO_GATE,
01d66fbd5b18ac Bob Copeland 2018-10-25 7059 nla_get_u8);
9757235f451c27 Masashi Honma 2016-08-03 7060 /*
9757235f451c27 Masashi Honma 2016-08-03 7061 * Check HT operation mode based on
188f60ab8e787f Bob Copeland 2018-06-24 7062 * IEEE 802.11-2016 9.4.2.57 HT
Operation element.
9757235f451c27 Masashi Honma 2016-08-03 7063 */
9757235f451c27 Masashi Honma 2016-08-03 7064 if (tb[NL80211_MESHCONF_HT_OPMODE]) {
9757235f451c27 Masashi Honma 2016-08-03 7065 ht_opmode =
nla_get_u16(tb[NL80211_MESHCONF_HT_OPMODE]);
9757235f451c27 Masashi Honma 2016-08-03 7066
9757235f451c27 Masashi Honma 2016-08-03 7067 if (ht_opmode &
~(IEEE80211_HT_OP_MODE_PROTECTION |
9757235f451c27 Masashi Honma 2016-08-03 7068
IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT |
9757235f451c27 Masashi Honma 2016-08-03 7069
IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT))
9757235f451c27 Masashi Honma 2016-08-03 7070 return -EINVAL;
9757235f451c27 Masashi Honma 2016-08-03 7071
188f60ab8e787f Bob Copeland 2018-06-24 7072 /* NON_HT_STA bit is reserved, but
some programs set it */
188f60ab8e787f Bob Copeland 2018-06-24 7073 ht_opmode &=
~IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT;
9757235f451c27 Masashi Honma 2016-08-03 7074
9757235f451c27 Masashi Honma 2016-08-03 7075 cfg->ht_opmode = ht_opmode;
fd551bac479585 Masashi Honma 2017-01-26 7076 mask |= (1 <<
(NL80211_MESHCONF_HT_OPMODE - 1));
9757235f451c27 Masashi Honma 2016-08-03 7077 }
728b19e5fb9bbe Chun-Yeow Yeoh 2012-06-14 7078 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7079
dot11MeshHWMPactivePathToRootTimeout, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7080
NL80211_MESHCONF_HWMP_PATH_TO_ROOT_TIMEOUT,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7081 nla_get_u32);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7082 if (mask &
BIT(NL80211_MESHCONF_HWMP_PATH_TO_ROOT_TIMEOUT) &&
ab0d76f6823cc3 Johannes Berg 2018-10-02 7083
(cfg->dot11MeshHWMPactivePathToRootTimeout < 1 ||
ab0d76f6823cc3 Johannes Berg 2018-10-02 7084
cfg->dot11MeshHWMPactivePathToRootTimeout > 65535))
ab0d76f6823cc3 Johannes Berg 2018-10-02 7085 return -EINVAL;
ab0d76f6823cc3 Johannes Berg 2018-10-02 7086 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHWMProotInterval, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7087
NL80211_MESHCONF_HWMP_ROOT_INTERVAL,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7088 nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7089 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshHWMPconfirmationInterval,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7090 mask,
728b19e5fb9bbe Chun-Yeow Yeoh 2012-06-14 7091
NL80211_MESHCONF_HWMP_CONFIRMATION_INTERVAL,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7092 nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7093 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
power_mode, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7094 NL80211_MESHCONF_POWER_MODE,
nla_get_u32);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7095 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshAwakeWindowDuration, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7096 NL80211_MESHCONF_AWAKE_WINDOW,
nla_get_u16);
ab0d76f6823cc3 Johannes Berg 2018-10-02 7097 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
plink_timeout, mask,
ab0d76f6823cc3 Johannes Berg 2018-10-02 7098 NL80211_MESHCONF_PLINK_TIMEOUT,
nla_get_u32);
d86bcd2b4a9457 Linus Lüssing 2020-06-16 @7099 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
dot11MeshNolearn, 0, 1,
d86bcd2b4a9457 Linus Lüssing 2020-06-16 7100 mask, NL80211_MESHCONF_NOLEARN,
d86bcd2b4a9457 Linus Lüssing 2020-06-16 7101 nl80211_check_bool);
bd90fdcc5fbd99 Johannes Berg 2010-12-03 7102 if (mask_out)
bd90fdcc5fbd99 Johannes Berg 2010-12-03 7103 *mask_out = mask;
c80d545da3f7c0 Javier Cardona 2010-12-16 7104
bd90fdcc5fbd99 Johannes Berg 2010-12-03 7105 return 0;
bd90fdcc5fbd99 Johannes Berg 2010-12-03 7106
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
825
days inactive
825
days old
0 comments
1 participants
participants (1)
-
kernel test robot