Hi Tony,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.9-rc4]
[also build test WARNING on next-20200911]
[cannot apply to jkirsher-next-queue/dev-queue]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Tony-Nguyen/i40e-add-support-for...
base: f4d51dffc6c01a9e94650d95ce0104964f8ae822
config: x86_64-randconfig-s022-20200911 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-191-g10164920-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> drivers/net/ethernet/intel/i40e/i40e_ptp.c:1021:50: sparse:
sparse: mixing different enum types:
> drivers/net/ethernet/intel/i40e/i40e_ptp.c:1021:50: sparse: int enum
i40e_ptp_led_pin_state
> drivers/net/ethernet/intel/i40e/i40e_ptp.c:1021:50: sparse: int enum
i40e_ptp_gpio_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1022:50:
sparse: sparse: mixing different enum types:
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1022:50: sparse: int enum
i40e_ptp_led_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1022:50: sparse: int enum
i40e_ptp_gpio_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1023:50: sparse: sparse: mixing different
enum types:
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1023:50: sparse: int enum
i40e_ptp_led_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1023:50: sparse: int enum
i40e_ptp_gpio_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1024:50: sparse: sparse: mixing different
enum types:
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1024:50: sparse: int enum
i40e_ptp_led_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1024:50: sparse: int enum
i40e_ptp_gpio_pin_state
#
https://github.com/0day-ci/linux/commit/4e1948e563d6b25eca54bd9d4d23c4693...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Tony-Nguyen/i40e-add-support-for-PTP-external-synchronization-clock/20200912-081754
git checkout 4e1948e563d6b25eca54bd9d4d23c46936515ba4
vim +1021 drivers/net/ethernet/intel/i40e/i40e_ptp.c
1000
1001 /**
1002 * i40e_ptp_set_pins_hw - Set HW GPIO pins
1003 * @pf: Board private structure
1004 *
1005 * This function sets GPIO pins for PTP
1006 **/
1007 static void i40e_ptp_set_pins_hw(struct i40e_pf *pf)
1008 {
1009 const struct i40e_ptp_pins_settings *pins = pf->ptp_pins;
1010 struct i40e_hw *hw = &pf->hw;
1011
1012 /* pin must be disabled before it may be used */
1013 i40e_ptp_set_pin_hw(hw, I40E_SDP3_2, off);
1014 i40e_ptp_set_pin_hw(hw, I40E_SDP3_3, off);
1015 i40e_ptp_set_pin_hw(hw, I40E_GPIO_4, off);
1016
1017 i40e_ptp_set_pin_hw(hw, I40E_SDP3_2, pins->sdp3_2);
1018 i40e_ptp_set_pin_hw(hw, I40E_SDP3_3, pins->sdp3_3);
1019 i40e_ptp_set_pin_hw(hw, I40E_GPIO_4, pins->gpio_4);
1020
1021 i40e_ptp_set_led_hw(hw, I40E_LED2_0, pins->led2_0);
1022 i40e_ptp_set_led_hw(hw, I40E_LED2_1, pins->led2_1);
1023 i40e_ptp_set_led_hw(hw, I40E_LED3_0, pins->led3_0);
1024 i40e_ptp_set_led_hw(hw, I40E_LED3_1, pins->led3_1);
1025
1026 dev_info(&pf->pdev->dev,
1027 "PTP configuration set to: SDP3_2: %s, SDP3_3: %s, GPIO_4: %s.\n",
1028 i40e_ptp_gpio_pin_state2str[pins->sdp3_2],
1029 i40e_ptp_gpio_pin_state2str[pins->sdp3_3],
1030 i40e_ptp_gpio_pin_state2str[pins->gpio_4]);
1031 }
1032
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org