Hi Russ, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.16-rc1 next-20211118] [cannot apply to xilinx-xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Russ-Weight/fpga-Use-standard-cl... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8ab774587903771821b59471cc723bba6d893942 config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/cbab51e5108b1de0ce5fca9901f5b462c... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Russ-Weight/fpga-Use-standard-class-dev_release-function/20211117-092426 git checkout cbab51e5108b1de0ce5fca9901f5b462cc62a71d # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/fpga/altera-fpga2sdram.c: In function 'alt_fpga_bridge_probe': 127 | return PTR_ERR(mgr); | ^~~ drivers/fpga/altera-fpga2sdram.c:127:32: note: each undeclared identifier is reported only once for each function it appears in vim +/mgr +127 drivers/fpga/altera-fpga2sdram.c 93 94 static int alt_fpga_bridge_probe(struct platform_device *pdev) 95 { 96 struct device *dev = &pdev->dev; 97 struct alt_fpga2sdram_data *priv; 98 struct fpga_bridge *br; 99 u32 enable; 100 struct regmap *sysmgr; 101 int ret = 0; 102 103 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); 104 if (!priv) 105 return -ENOMEM; 106 107 priv->dev = dev; 108 109 priv->sdrctl = syscon_regmap_lookup_by_compatible("altr,sdr-ctl"); 110 if (IS_ERR(priv->sdrctl)) { 111 dev_err(dev, "regmap for altr,sdr-ctl lookup failed.\n"); 112 return PTR_ERR(priv->sdrctl); 113 } 114 115 sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr"); 116 if (IS_ERR(sysmgr)) { 117 dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n"); 118 return PTR_ERR(sysmgr); 119 } 120 121 /* Get f2s bridge configuration saved in handoff register */ 122 regmap_read(sysmgr, SYSMGR_ISWGRP_HANDOFF3, &priv->mask); 123 124 br = fpga_bridge_register(dev, F2S_BRIDGE_NAME, 125 &altera_fpga2sdram_br_ops, priv); 126 if (IS_ERR(br)) 128 129 platform_set_drvdata(pdev, br); 130 131 dev_info(dev, "driver initialized with handoff %08x\n", priv->mask); 132 133 if (!of_property_read_u32(dev->of_node, "bridge-enable", &enable)) { 134 if (enable > 1) { 135 dev_warn(dev, "invalid bridge-enable %u > 1\n", enable); 136 } else { 137 dev_info(dev, "%s bridge\n", 138 (enable ? "enabling" : "disabling")); 139 ret = _alt_fpga2sdram_enable_set(priv, enable); 140 if (ret) { 141 fpga_bridge_unregister(br); 142 return ret; 143 } 144 } 145 } 146 147 return ret; 148 } 149 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org