Hi Ansuel,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net/master]
[also build test ERROR on linus/master next-20211111]
[cannot apply to pavel-leds/for-next robh/for-next net-next/master v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Ansuel-Smith/Adds-support-for-PH...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
e5d5aadcf3cd59949316df49c27cb21788d7efe4
config: openrisc-buildonly-randconfig-r003-20211111 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/9d84c5c79622ad5b17b116d01303f74a4...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Ansuel-Smith/Adds-support-for-PHY-LEDs-with-offload-triggers/20211111-093724
git checkout 9d84c5c79622ad5b17b116d01303f74a4ae94d10
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=openrisc SHELL=/bin/bash drivers/i2c/ drivers/leds/trigger/ kernel/bpf/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/leds/trigger/ledtrig-netdev.c: In function 'set_baseline_state':
> drivers/leds/trigger/ledtrig-netdev.c:61:33: error: 'struct
led_classdev' has no member named 'hw_control_start'
61 |
led_cdev->hw_control_start(led_cdev);
| ^~
vim +61 drivers/leds/trigger/ledtrig-netdev.c
44
45 static void set_baseline_state(struct led_netdev_data *trigger_data)
46 {
47 int current_brightness, can_offload;
48 struct led_classdev *led_cdev = trigger_data->led_cdev;
49
50 if (LED_HARDWARE_CONTROLLED & led_cdev->flags) {
51 /* Check if blink mode can he set in hardware mode.
52 * The LED driver will chose a interval based on the trigger_data
53 * and its implementation.
54 */
55 can_offload = led_cdev->blink_set(led_cdev, 0, 0);
56
57 /* If blink_set doesn't return error we can run in hardware mode
58 * So actually activate it.
59 */
60 if (!can_offload) {
61 led_cdev->hw_control_start(led_cdev);
62 return;
63 }
64 }
65
66 /* If LED supports only hardware mode and we reach this point,
67 * then skip any software handling.
68 */
69 if (!(LED_SOFTWARE_CONTROLLED & led_cdev->flags))
70 return;
71
72 current_brightness = led_cdev->brightness;
73 if (current_brightness)
74 led_cdev->blink_brightness = current_brightness;
75 if (!led_cdev->blink_brightness)
76 led_cdev->blink_brightness = led_cdev->max_brightness;
77
78 if (!trigger_data->carrier_link_up) {
79 led_set_brightness(led_cdev, LED_OFF);
80 } else {
81 if (test_bit(TRIGGER_NETDEV_LINK, &trigger_data->mode))
82 led_set_brightness(led_cdev,
83 led_cdev->blink_brightness);
84 else
85 led_set_brightness(led_cdev, LED_OFF);
86
87 /* If we are looking for RX/TX start periodically
88 * checking stats
89 */
90 if (test_bit(TRIGGER_NETDEV_TX, &trigger_data->mode) ||
91 test_bit(TRIGGER_NETDEV_RX, &trigger_data->mode))
92 schedule_delayed_work(&trigger_data->work, 0);
93 }
94 }
95
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org