Hi Tomer,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Tomer-Samara/staging-android-Rem...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
bc752d2f345bf55d71b3422a6a24890ea03168dc
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/staging/android/ion/ion_page_pool.c: In function 'ion_page_pool_free':
> drivers/staging/android/ion/ion_page_pool.c:83:2: error: expected
';' before 'ion_page_pool_add'
83 | ion_page_pool_add(pool,
page);
| ^~~~~~~~~~~~~~~~~
At top level:
drivers/staging/android/ion/ion_page_pool.c:28:13: warning: 'ion_page_pool_add'
defined but not used [-Wunused-function]
28 | static void ion_page_pool_add(struct ion_page_pool *pool, struct page *page)
| ^~~~~~~~~~~~~~~~~
#
https://github.com/0day-ci/linux/commit/855a2d27af07d8bf02bc2f5cd75a7f87d...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Tomer-Samara/staging-android-Remove-BUG-BUG_ON-from-ion/20200821-233003
git checkout 855a2d27af07d8bf02bc2f5cd75a7f87d1e94686
vim +83 drivers/staging/android/ion/ion_page_pool.c
0214c7f20bf4d5d Rebecca Schultz Zavin 2013-12-13 78
0214c7f20bf4d5d Rebecca Schultz Zavin 2013-12-13 79 void ion_page_pool_free(struct
ion_page_pool *pool, struct page *page)
0214c7f20bf4d5d Rebecca Schultz Zavin 2013-12-13 80 {
855a2d27af07d8b Tomer Samara 2020-08-21 81 WARN_ON(pool->order !=
compound_order(page))
bdeb9f1c4276864 Heesub Shin 2014-05-28 82
a3f75c43594ccfe Yisheng Xie 2018-02-12 @83 ion_page_pool_add(pool, page);
0214c7f20bf4d5d Rebecca Schultz Zavin 2013-12-13 84 }
0214c7f20bf4d5d Rebecca Schultz Zavin 2013-12-13 85
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org