Hi Pablo, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] [cannot apply to nf/master v5.16 next-20220110] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/nf_tables-data... base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: arc-randconfig-p002-20220109 (https://download.01.org/0day-ci/archive/20220110/202201101936.U3a6qUVG-lk...) compiler: arc-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3570cf7af56824fc1640caee7c5609f79... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pablo-Neira-Ayuso/nf_tables-datapath-ruleset-blob-and-register-tracking/20220110-001256 git checkout 3570cf7af56824fc1640caee7c5609f7959d26fe # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash net/netfilter/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): net/netfilter/nf_tables_api.c: In function 'nf_tables_commit_chain_prepare': 8266 | int i; | ^ vim +/i +8266 net/netfilter/nf_tables_api.c ffe8923f109b7e Florian Westphal 2020-07-24 8258 0cbc06b3faba75 Florian Westphal 2018-05-25 8259 static int nf_tables_commit_chain_prepare(struct net *net, struct nft_chain *chain) 0cbc06b3faba75 Florian Westphal 2018-05-25 8260 { 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8261 const struct nft_expr *expr, *last; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8262 unsigned int size, data_size; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8263 void *data, *data_boundary; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8264 struct nft_rule_dp *prule; 0cbc06b3faba75 Florian Westphal 2018-05-25 8265 struct nft_rule *rule; 0cbc06b3faba75 Florian Westphal 2018-05-25 @8266 int i; 0cbc06b3faba75 Florian Westphal 2018-05-25 8267 0cbc06b3faba75 Florian Westphal 2018-05-25 8268 /* already handled or inactive chain? */ 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8269 if (chain->blob_next || !nft_is_active_next(net, chain)) 0cbc06b3faba75 Florian Westphal 2018-05-25 8270 return 0; 0cbc06b3faba75 Florian Westphal 2018-05-25 8271 0cbc06b3faba75 Florian Westphal 2018-05-25 8272 rule = list_entry(&chain->rules, struct nft_rule, list); 0cbc06b3faba75 Florian Westphal 2018-05-25 8273 i = 0; 0cbc06b3faba75 Florian Westphal 2018-05-25 8274 0cbc06b3faba75 Florian Westphal 2018-05-25 8275 list_for_each_entry_continue(rule, &chain->rules, list) { 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8276 if (nft_is_active_next(net, rule)) { 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8277 data_size += sizeof(*prule) + rule->dlen; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8278 if (data_size > INT_MAX) 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8279 return -ENOMEM; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8280 } 0cbc06b3faba75 Florian Westphal 2018-05-25 8281 } 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8282 data_size += offsetof(struct nft_rule_dp, data); /* last rule */ 0cbc06b3faba75 Florian Westphal 2018-05-25 8283 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8284 chain->blob_next = nf_tables_chain_alloc_rules(data_size); 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8285 if (!chain->blob_next) 0cbc06b3faba75 Florian Westphal 2018-05-25 8286 return -ENOMEM; 0cbc06b3faba75 Florian Westphal 2018-05-25 8287 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8288 data = (void *)chain->blob_next->data; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8289 data_boundary = data + data_size; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8290 size = 0; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8291 0cbc06b3faba75 Florian Westphal 2018-05-25 8292 list_for_each_entry_continue(rule, &chain->rules, list) { 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8293 if (!nft_is_active_next(net, rule)) 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8294 continue; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8295 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8296 prule = (struct nft_rule_dp *)data; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8297 data += offsetof(struct nft_rule_dp, data); 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8298 if (WARN_ON_ONCE(data > data_boundary)) 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8299 return -ENOMEM; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8300 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8301 nft_rule_for_each_expr(expr, last, rule) { 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8302 if (WARN_ON_ONCE(data + expr->ops->size > data_boundary)) 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8303 return -ENOMEM; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8304 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8305 memcpy(data + size, expr, expr->ops->size); 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8306 size += expr->ops->size; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8307 } 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8308 if (WARN_ON_ONCE(size >= 1 << 12)) 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8309 return -ENOMEM; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8310 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8311 prule->handle = rule->handle; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8312 prule->dlen = size; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8313 prule->is_last = 0; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8314 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8315 data += size; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8316 size = 0; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8317 chain->blob_next->size += (unsigned long)(data - (void *)prule); 0cbc06b3faba75 Florian Westphal 2018-05-25 8318 } 0cbc06b3faba75 Florian Westphal 2018-05-25 8319 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8320 prule = (struct nft_rule_dp *)data; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8321 data += offsetof(struct nft_rule_dp, data); 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8322 if (WARN_ON_ONCE(data > data_boundary)) 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8323 return -ENOMEM; 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8324 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8325 nft_last_rule(chain->blob_next, prule); 3570cf7af56824 Pablo Neira Ayuso 2022-01-09 8326 0cbc06b3faba75 Florian Westphal 2018-05-25 8327 return 0; 0cbc06b3faba75 Florian Westphal 2018-05-25 8328 } 0cbc06b3faba75 Florian Westphal 2018-05-25 8329 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org