Hi Dan, Thanks for the mail. As rightly mentioned, the intention was && instead of ||. I will fix the issue in the next version of the patch. Thanks & Regards, Ankit On 12/9/2020 11:20 PM, Dan Carpenter wrote: > Hi Ankit, > > url: https://github.com/0day-ci/linux/commits/Ankit-Nautiyal/Add-support-for-D... > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: i386-randconfig-m021-20201209 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp(a)intel.com&gt; > Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; > > smatch warnings: > drivers/gpu/drm/drm_dp_helper.c:3185 drm_dp_pcon_convert_rgb_to_ycbcr() warn: was && intended here instead of ||? > > vim +3185 drivers/gpu/drm/drm_dp_helper.c > > +int drm_dp_pcon_convert_rgb_to_ycbcr(struct drm_dp_aux *aux, u8 color_spc) > +{ > + int ret; > + u8 buf; > + > + if (color_spc != DP_CONVERSION_BT601_RGB_YCBCR_ENABLE || > + color_spc != DP_CONVERSION_BT709_RGB_YCBCR_ENABLE || > + color_spc != DP_CONVERSION_BT2020_RGB_YCBCR_ENABLE) > + return -EINVAL; > > "color_spc" cannot possibly be equal to three different values so this > function will always return -EINVAL. > > + > + ret = drm_dp_dpcd_readb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, &buf); > + if (ret < 0) > + return ret; > + > + buf |= color_spc; > + ret = drm_dp_dpcd_writeb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, buf); > + if (ret < 0) > + return ret; > + > + return 0; > +} > > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel