[chrome-os:chromeos-5.4 180/242] drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared; did you mean 'sq'?
1:15 p.m.
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: 03c601082f2f279deba7e2b6923e735273c65587
commit: 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e [180/242] UPSTREAM: mt76: rely on AQL for
burst size limits on tx queueing
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add chrome-os
https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-5.4
git checkout 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the chrome-os/chromeos-5.4 HEAD 03c601082f2f279deba7e2b6923e735273c65587 builds
fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/tx.c: In function 'mt76_txq_send_burst':
> drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q'
undeclared (first use in this function); did you mean 'sq'?
504 | if
(q->queued + MT_TXQ_FREE_THR >= q->ndesc)
| ^
| sq
drivers/net/wireless/mediatek/mt76/tx.c:504:7: note: each undeclared identifier is
reported only once for each function it appears in
drivers/net/wireless/mediatek/mt76/tx.c: In function 'mt76_txq_schedule_list':
drivers/net/wireless/mediatek/mt76/tx.c:547:7: error: 'q' undeclared (first use
in this function); did you mean 'sq'?
547 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
| ^
| sq
vim +504 drivers/net/wireless/mediatek/mt76/tx.c
461
462 static int
463 mt76_txq_send_burst(struct mt76_phy *phy, struct mt76_sw_queue *sq,
464 struct mt76_txq *mtxq)
465 {
466 struct mt76_dev *dev = phy->dev;
467 struct ieee80211_txq *txq = mtxq_to_txq(mtxq);
468 enum mt76_txq_id qid = mt76_txq_get_qid(txq);
469 struct mt76_wcid *wcid = mtxq->wcid;
470 struct mt76_queue *hwq = sq->q;
471 struct ieee80211_tx_info *info;
472 struct sk_buff *skb;
473 int n_frames = 1;
474 bool stop = false;
475 int idx;
476
477 if (test_bit(MT_WCID_FLAG_PS, &wcid->flags))
478 return 0;
479
480 if (atomic_read(&wcid->non_aql_packets) >= MT_MAX_NON_AQL_PKT)
481 return 0;
482
483 skb = mt76_txq_dequeue(phy, mtxq, false);
484 if (!skb)
485 return 0;
486
487 info = IEEE80211_SKB_CB(skb);
488 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
489 ieee80211_get_tx_rates(txq->vif, txq->sta, skb,
490 info->control.rates, 1);
491
492 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid, txq->sta, &stop);
493 if (idx < 0)
494 return idx;
495
496 do {
497 if (test_bit(MT76_STATE_PM, &phy->state) ||
498 test_bit(MT76_RESET, &phy->state))
499 return -EBUSY;
500
501 if (stop)
502 break;
503
504 if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
505 break;
506
507 skb = mt76_txq_dequeue(phy, mtxq, false);
508 if (!skb)
509 break;
510
511 info = IEEE80211_SKB_CB(skb);
512 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
513 ieee80211_get_tx_rates(txq->vif, txq->sta, skb,
514 info->control.rates, 1);
515
516 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid, txq->sta, &stop);
517 if (idx < 0)
518 break;
519
520 n_frames++;
521 } while (1);
522
523 dev->queue_ops->kick(dev, hwq);
524
525 return n_frames;
526 }
527
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1:52 p.m.
+Claire Chang <tientzu(a)google.com>
On Sat, Apr 17, 2021 at 11:16 AM kernel test robot <lkp(a)intel.com> wrote:
tree:
https://chromium.googlesource.com/chromiumos/third_party/kernel
chromeos-5.4
head: 03c601082f2f279deba7e2b6923e735273c65587
commit: 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e [180/242] UPSTREAM: mt76:
rely on AQL for burst size limits on tx queueing
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add chrome-os
https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-5.4
git checkout 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1
ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the chrome-os/chromeos-5.4 HEAD
03c601082f2f279deba7e2b6923e735273c65587 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_send_burst':
>> drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared
(first use in this function); did you mean 'sq'?
504 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
| ^
| sq
drivers/net/wireless/mediatek/mt76/tx.c:504:7: note: each undeclared
identifier is reported only once for each function it appears in
drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule_list':
drivers/net/wireless/mediatek/mt76/tx.c:547:7: error: 'q' undeclared
(first use in this function); did you mean 'sq'?
547 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
| ^
| sq
vim +504 drivers/net/wireless/mediatek/mt76/tx.c
461
462 static int
463 mt76_txq_send_burst(struct mt76_phy *phy, struct mt76_sw_queue *sq,
464 struct mt76_txq *mtxq)
465 {
466 struct mt76_dev *dev = phy->dev;
467 struct ieee80211_txq *txq = mtxq_to_txq(mtxq);
468 enum mt76_txq_id qid = mt76_txq_get_qid(txq);
469 struct mt76_wcid *wcid = mtxq->wcid;
470 struct mt76_queue *hwq = sq->q;
471 struct ieee80211_tx_info *info;
472 struct sk_buff *skb;
473 int n_frames = 1;
474 bool stop = false;
475 int idx;
476
477 if (test_bit(MT_WCID_FLAG_PS, &wcid->flags))
478 return 0;
479
480 if (atomic_read(&wcid->non_aql_packets) >=
MT_MAX_NON_AQL_PKT)
481 return 0;
482
483 skb = mt76_txq_dequeue(phy, mtxq, false);
484 if (!skb)
485 return 0;
486
487 info = IEEE80211_SKB_CB(skb);
488 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
489 ieee80211_get_tx_rates(txq->vif, txq->sta, skb,
490 info->control.rates, 1);
491
492 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid, txq->sta,
&stop);
493 if (idx < 0)
494 return idx;
495
496 do {
497 if (test_bit(MT76_STATE_PM, &phy->state) ||
498 test_bit(MT76_RESET, &phy->state))
499 return -EBUSY;
500
501 if (stop)
502 break;
503
> 504 if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
505 break;
506
507 skb = mt76_txq_dequeue(phy, mtxq, false);
508 if (!skb)
509 break;
510
511 info = IEEE80211_SKB_CB(skb);
512 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
513 ieee80211_get_tx_rates(txq->vif, txq->sta,
skb,
514
info->control.rates, 1);
515
516 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid,
txq->sta, &stop);
517 if (idx < 0)
518 break;
519
520 n_frames++;
521 } while (1);
522
523 dev->queue_ops->kick(dev, hwq);
524
525 return n_frames;
526 }
527
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
You received this message because you are subscribed to the Google Groups
"cros-kernel-buildreports" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to cros-kernel-buildreports+unsubscribe(a)googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/cros-kernel-buildreports/202104171103.b...
.
1:36 p.m.
IIUC, this is caused by the patch order and should be fixed already. Sorry
for the inconvenience.
On Sat, Apr 17, 2021 at 11:52 AM Nicolas Boichat <drinkcat(a)google.com>
wrote:
+Claire Chang <tientzu(a)google.com>
On Sat, Apr 17, 2021 at 11:16 AM kernel test robot <lkp(a)intel.com> wrote:
> tree: https://chromium.googlesource.com/chromiumos/third_party/kernel
> chromeos-5.4
> head: 03c601082f2f279deba7e2b6923e735273c65587
> commit: 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e [180/242] UPSTREAM:
> mt76: rely on AQL for burst size limits on tx queueing
> config: nios2-allyesconfig (attached as .config)
> compiler: nios2-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git remote add chrome-os
> https://chromium.googlesource.com/chromiumos/third_party/kernel
> git fetch --no-tags chrome-os chromeos-5.4
> git checkout 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> W=1 ARCH=nios2
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp(a)intel.com>
>
> Note: the chrome-os/chromeos-5.4 HEAD
> 03c601082f2f279deba7e2b6923e735273c65587 builds fine.
> It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
> drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_send_burst':
> >> drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q'
undeclared
> (first use in this function); did you mean 'sq'?
> 504 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
> | ^
> | sq
> drivers/net/wireless/mediatek/mt76/tx.c:504:7: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_schedule_list':
> drivers/net/wireless/mediatek/mt76/tx.c:547:7: error: 'q' undeclared
> (first use in this function); did you mean 'sq'?
> 547 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
> | ^
> | sq
>
>
> vim +504 drivers/net/wireless/mediatek/mt76/tx.c
>
> 461
> 462 static int
> 463 mt76_txq_send_burst(struct mt76_phy *phy, struct mt76_sw_queue
> *sq,
> 464 struct mt76_txq *mtxq)
> 465 {
> 466 struct mt76_dev *dev = phy->dev;
> 467 struct ieee80211_txq *txq = mtxq_to_txq(mtxq);
> 468 enum mt76_txq_id qid = mt76_txq_get_qid(txq);
> 469 struct mt76_wcid *wcid = mtxq->wcid;
> 470 struct mt76_queue *hwq = sq->q;
> 471 struct ieee80211_tx_info *info;
> 472 struct sk_buff *skb;
> 473 int n_frames = 1;
> 474 bool stop = false;
> 475 int idx;
> 476
> 477 if (test_bit(MT_WCID_FLAG_PS, &wcid->flags))
> 478 return 0;
> 479
> 480 if (atomic_read(&wcid->non_aql_packets) >=
> MT_MAX_NON_AQL_PKT)
> 481 return 0;
> 482
> 483 skb = mt76_txq_dequeue(phy, mtxq, false);
> 484 if (!skb)
> 485 return 0;
> 486
> 487 info = IEEE80211_SKB_CB(skb);
> 488 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
> 489 ieee80211_get_tx_rates(txq->vif, txq->sta, skb,
> 490 info->control.rates, 1);
> 491
> 492 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid, txq->sta,
> &stop);
> 493 if (idx < 0)
> 494 return idx;
> 495
> 496 do {
> 497 if (test_bit(MT76_STATE_PM, &phy->state) ||
> 498 test_bit(MT76_RESET, &phy->state))
> 499 return -EBUSY;
> 500
> 501 if (stop)
> 502 break;
> 503
> > 504 if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
> 505 break;
> 506
> 507 skb = mt76_txq_dequeue(phy, mtxq, false);
> 508 if (!skb)
> 509 break;
> 510
> 511 info = IEEE80211_SKB_CB(skb);
> 512 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
> 513 ieee80211_get_tx_rates(txq->vif,
> txq->sta, skb,
> 514
> info->control.rates, 1);
> 515
> 516 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid,
> txq->sta, &stop);
> 517 if (idx < 0)
> 518 break;
> 519
> 520 n_frames++;
> 521 } while (1);
> 522
> 523 dev->queue_ops->kick(dev, hwq);
> 524
> 525 return n_frames;
> 526 }
> 527
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
> --
> You received this message because you are subscribed to the Google Groups
> "cros-kernel-buildreports" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to cros-kernel-buildreports+unsubscribe(a)googlegroups.com.
> To view this discussion on the web visit
>
https://groups.google.com/d/msgid/cros-kernel-buildreports/202104171103.b...
> .
>
519
days inactive
521
days old
2 comments
3 participants
participants (3)
-
Claire Chang -
kernel test robot -
Nicolas Boichat