Hi Joel, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on powerpc/next] [also build test ERROR on v5.17-rc4 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Joel-Stanley/powerpc-Implement-h... base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-maple_defconfig (https://download.01.org/0day-ci/archive/20220218/202202180215.17kX4jBX-lk...) compiler: powerpc-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e46f18f09e3df750b90d68f472c81be48... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Joel-Stanley/powerpc-Implement-hotplug-smt-control/20220217-150555 git checkout e46f18f09e3df750b90d68f472c81be484f0cac2 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): kernel/cpu.c: In function 'cpuhp_smt_disable': 2220 | ret = cpu_down_maps_locked(cpu, CPUHP_OFFLINE); | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/cpu_down_maps_locked +2220 kernel/cpu.c dc8d37ed304eee Arnd Bergmann 2019-12-10 2211 dc8d37ed304eee Arnd Bergmann 2019-12-10 2212 int cpuhp_smt_disable(enum cpuhp_smt_control ctrlval) dc8d37ed304eee Arnd Bergmann 2019-12-10 2213 { dc8d37ed304eee Arnd Bergmann 2019-12-10 2214 int cpu, ret = 0; dc8d37ed304eee Arnd Bergmann 2019-12-10 2215 dc8d37ed304eee Arnd Bergmann 2019-12-10 2216 cpu_maps_update_begin(); dc8d37ed304eee Arnd Bergmann 2019-12-10 2217 for_each_online_cpu(cpu) { dc8d37ed304eee Arnd Bergmann 2019-12-10 2218 if (topology_is_primary_thread(cpu)) dc8d37ed304eee Arnd Bergmann 2019-12-10 2219 continue; dc8d37ed304eee Arnd Bergmann 2019-12-10 @2220 ret = cpu_down_maps_locked(cpu, CPUHP_OFFLINE); dc8d37ed304eee Arnd Bergmann 2019-12-10 2221 if (ret) dc8d37ed304eee Arnd Bergmann 2019-12-10 2222 break; dc8d37ed304eee Arnd Bergmann 2019-12-10 2223 /* dc8d37ed304eee Arnd Bergmann 2019-12-10 2224 * As this needs to hold the cpu maps lock it's impossible dc8d37ed304eee Arnd Bergmann 2019-12-10 2225 * to call device_offline() because that ends up calling dc8d37ed304eee Arnd Bergmann 2019-12-10 2226 * cpu_down() which takes cpu maps lock. cpu maps lock dc8d37ed304eee Arnd Bergmann 2019-12-10 2227 * needs to be held as this might race against in kernel dc8d37ed304eee Arnd Bergmann 2019-12-10 2228 * abusers of the hotplug machinery (thermal management). dc8d37ed304eee Arnd Bergmann 2019-12-10 2229 * dc8d37ed304eee Arnd Bergmann 2019-12-10 2230 * So nothing would update device:offline state. That would dc8d37ed304eee Arnd Bergmann 2019-12-10 2231 * leave the sysfs entry stale and prevent onlining after dc8d37ed304eee Arnd Bergmann 2019-12-10 2232 * smt control has been changed to 'off' again. This is dc8d37ed304eee Arnd Bergmann 2019-12-10 2233 * called under the sysfs hotplug lock, so it is properly dc8d37ed304eee Arnd Bergmann 2019-12-10 2234 * serialized against the regular offline usage. dc8d37ed304eee Arnd Bergmann 2019-12-10 2235 */ dc8d37ed304eee Arnd Bergmann 2019-12-10 2236 cpuhp_offline_cpu_device(cpu); dc8d37ed304eee Arnd Bergmann 2019-12-10 2237 } dc8d37ed304eee Arnd Bergmann 2019-12-10 2238 if (!ret) dc8d37ed304eee Arnd Bergmann 2019-12-10 2239 cpu_smt_control = ctrlval; dc8d37ed304eee Arnd Bergmann 2019-12-10 2240 cpu_maps_update_done(); dc8d37ed304eee Arnd Bergmann 2019-12-10 2241 return ret; dc8d37ed304eee Arnd Bergmann 2019-12-10 2242 } dc8d37ed304eee Arnd Bergmann 2019-12-10 2243 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org